Re: 8.5.2 "integral" - "integer"

2023-01-07 Thread David G. Johnston
On Saturday, January 7, 2023, Tom Lane wrote: > PG Doc comments form writes: > > I think, the "integer" will be good choice instead "integral'": > > 8.5.2 > > ... > > "The offset will be shown as hh (hours only) if it is an integral number > of > > hours, else as hh:mm if it is an integral numbe

Re: https://www.postgresql.org/account/comments/new/15/sql-alterdatabase.html/

2023-01-24 Thread David G. Johnston
On Tue, Jan 24, 2023 at 12:43 PM PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-alterdatabase.html > Description: > > Would love to see more information about each of the A

Re: gen_random_uuid is only available with pgcrypto enabled

2023-01-24 Thread David G. Johnston
On Tue, Jan 24, 2023 at 12:43 PM PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/functions-uuid.html > Description: > > Regarding the documentation on this page: > https://www.p

Re: Naming of network_ops vs. inet_ops for SP-GIST

2023-01-24 Thread David G. Johnston
Michael, please see below: On Tue, Jan 24, 2023 at 12:44 PM PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/spgist-builtin-opclasses.html > Description: > > I wanted to add an

Re: unclear syntax explanation for multiple window definitions in a SELECT query

2023-02-16 Thread David G. Johnston
On Thu, Feb 16, 2023 at 5:13 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-select.html > Description: > > The syntax documentation for SELECT in SQL COMMANDS section is unclear in > explaining

Re: unclear syntax explanation for multiple window definitions in a SELECT query

2023-02-17 Thread David G. Johnston
On Thu, Feb 16, 2023 at 10:18 AM Adam Mackler wrote: > > Maybe the reference section for SELECT is the wrong place for that longer > form, but section 4.2.8 (or some other referenced from there) could be. > > Expanding Section 7.2.5 to be more consistent in level-of-detail with the rest of that p

Re: MERGE examples not clear

2023-02-21 Thread David G. Johnston
On Tue, Feb 21, 2023 at 8:35 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-merge.html > Description: > > On this page: https://www.postgresql.org/docs/15/sql-merge.html > the first and second e

Re: Mistake in statement example

2023-03-01 Thread David G. Johnston
On Wed, Mar 1, 2023 at 9:34 AM Tom Lane wrote: > PG Doc comments form writes: > > I believe there is a mistake in an example on > > https://www.postgresql.org/docs/current/transaction-iso.html section > > 13.2.1: > > BEGIN; > > UPDATE accounts SET balance = balance + 100.00 WHERE acctnum = 12345

Re: Seeming contradiction in 22.1

2023-03-22 Thread David G. Johnston
On Monday, March 20, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/database-roles.html > Description: > > In chapter 22.1 the following text seems to imply the role will have "the > same name as

Re: Seeming contradiction in 22.1

2023-03-22 Thread David G. Johnston
On Wed, Mar 22, 2023 at 3:41 PM maja zaloznik wrote: > My issue is that - at least as far as i can recall - the default superuser > was already named postgres > There is no compiled-in default for the name of the bootstrap superuser. It is chosen during initdb using the algorithm described (i.e.

Seeming contradiction in 22.1

2023-03-23 Thread David G. Johnston
On Thursday, March 23, 2023, maja zaloznik wrote: > > My point being that if what you say is true but runs counter to what > essentially all other instructions on the internet say, it would seem > prudent to mention this disparity and the reasons for it in the canonical > documentation, which wou

Re: Confusion between psql options and pg_service file config

2023-03-28 Thread David G. Johnston
On Tue, Mar 28, 2023 at 1:30 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/libpq-connect.html > Description: > I feel like I'm going in circles trying to square `psql` options (15: psql) > with con

Re: I think that the transaction tutorial document (3.4) should mention transaction isolation

2023-03-29 Thread David G. Johnston
On Wed, Mar 29, 2023 at 12:56 PM Bruce Momjian wrote: > On Thu, Mar 2, 2023 at 01:55:31PM +, PG Doc comments form wrote: > > > I think that a notice saying that for absolute transaction isolation you > > should set the default transaction isolation to serializable, and be > > prepared to hav

Re: DROP INDEX - dropping index of a table in a named schema

2023-05-22 Thread David G. Johnston
On Monday, May 22, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-dropindex.html > Description: > > I had to find out (as it is not in the given documentation) that to drop an > index for a t

Re: Typo

2023-05-23 Thread David G. Johnston
On Tue, May 23, 2023 at 3:32 PM Michael Paquier wrote: > On Tue, May 23, 2023 at 08:52:25PM +, PG Doc comments form wrote: > > There appears to be a typo, here: > > > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20ANSI%20C > . > > A word or

Re: Typo

2023-05-23 Thread David G. Johnston
On Tuesday, May 23, 2023, Tom Lane wrote: > Laurenz Albe writes: > > On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote: > >> This is the current sentence, and it sounds kind of OK to me, FWIW: > >> "Postgres95 code was completely ANSI C and trimmed in size by 25%. > > > That uses "ANSI C"

Re: bpchar datatype is not equal to character(1) data type

2023-06-06 Thread David G. Johnston
On Tue, Jun 6, 2023 at 7:31 AM yanliang lei wrote: > > Based on the above description, there is a deduction as follows: > bpchar datatype is equal to character(1) data type > Nope, bpchar is not equal to any user-facing data type by virtue of it being an internal implementation-only data type.

Re: Sequence Dependency

2023-06-12 Thread David G. Johnston
On Saturday, June 10, 2023, Umut TEKİN wrote: > > it does not create any pg_depend entry for this sequence and table pair. So, > it is not possible to track down to find the pairs. Is there any other way to > find the sequence and the table pairs created using method 2? > > Parse the defaults a

Re: Further clarification in documentation: No deletion of unreferenced large objects

2023-06-12 Thread David G. Johnston
On Mon, Jun 12, 2023 at 8:32 AM PG Doc comments form wrote: You may be onto something, but: > > Page: https://www.postgresql.org/docs/15/datatype-binary.html This page isn't relevant to the discussion at hand as it doesn't have anything to do with large objects. Whether it should would be a d

Re: group by can use alias from select list

2023-07-11 Thread David G. Johnston
On Tue, Jul 11, 2023 at 7:19 AM Laurenz Albe wrote: > On Fri, 2023-07-07 at 07:36 +, PG Doc comments form wrote: > > i have a discussion in pgsql-b...@lists.postgresql.org about this and > it is > > mentioned in the answers that it is documented and a "feature" of > Postgres > > that this can

Re: Confusing reference to MERGE use inside WITH

2023-07-16 Thread David G. Johnston
On Sun, Jul 16, 2023 at 5:48 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/queries-with.html > Description: > > Hi. > > In the queries WITH documentation > https://www.postgresql.org/docs/15/querie

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson wrote: > The actual results (shown below) are different than shown on this doc > page. The reason is because the second parameter to the UDF that is > passed to SPI_exec is the maximum number of rows to return, or 0 for > no limit. It is not the maxim

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 6:22 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Mon, Jul 17, 2023 at 4:53 PM Curt Kolovson > wrote: > >> The actual results (shown below) are different than shown on this doc > >> page. > > > SPI_exec

Re: Bug in documentation: https://www.postgresql.org/docs/current/spi-examples.html

2023-07-17 Thread David G. Johnston
On Mon, Jul 17, 2023 at 7:45 PM Curt Kolovson wrote: > I’d vote for showing both (with RETURNING and without), since without it > the second argument to SPI_exec has no effect in this example, which may > not be obvious. That seems to be one of the subtle points illustrated by > this example. >

Re: Uniquness of ctid

2023-07-19 Thread David G. Johnston
On Wed, Jul 19, 2023 at 2:31 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/ddl-system-columns.html > Description: > > Hi, > Looking at the explanation abour ctid, it is "The physical location of th

Re: word incorrectly on document

2023-08-01 Thread David G. Johnston
On Tue, Aug 1, 2023 at 1:39 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/executor.html > Description: > > Document location: 52.6. Executor > fed up -> feed up > My instinct says the existing wor

Re: ALTER TABLE "table" ALTER COLUMN "id" SET RESTART WITH nnn raises error

2023-08-20 Thread David G. Johnston
On Sun, Aug 20, 2023 at 8:56 AM PG Doc comments form wrote: > When the folloing SQL is executed: > ALTER TABLE "table" ALTER COLUMN "id" SET RESTART WITH nnn raises error > then an error is returned: > Yes, because if you take the RESTART branch in the syntax there is no word SET preceding RESTA

Re: In docs there is no "Installation from Binaries" section

2023-08-20 Thread David G. Johnston
On Sun, Aug 20, 2023 at 8:56 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/install-binaries.html > Description: > > Installing software from ZIP archive is a common practice, pgsql provides > such

Re: Create Role Documentation - Not Clear for new users

2023-08-22 Thread David G. Johnston
On Monday, August 21, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/database-roles.html > Description: > > Hi! Hope you are doing great! > > I'm trying to learn about PostgreSQL, I'm totally ne

Re: General Feedback

2023-08-28 Thread David G. Johnston
On Mon, Aug 28, 2023 at 7:33 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-createschema.html > Description: > > "To create a schema, the invoking user must have the CREATE privilege for > the c

Ambiguous statement about order

2023-09-15 Thread David G. Johnston
On Thursday, September 14, 2023, PG Doc comments form < nore...@postgresql.org> wrote: > > I observed that arrays inside JSONB preserved order of insertion. An > explicit line about whether the array order will be preserved or not would > be helpful. We don’t take on responsibility for teaching p

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread David G. Johnston
On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian wrote: > On Mon, Sep 18, 2023 at 08:14:04PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/pgupgrade.html > > Description: > > > > I feel lik

Re: `pg_restore --if-exists` clarification

2023-09-28 Thread David G. Johnston
On Thursday, September 28, 2023, Gulyás Attila wrote: > So `--if-exists` simply suppresses any notice / warning that would occur? > That switch causes the drop DDL produced by pg_restore to include if exists clauses. The server then simply treats the DDL as a no-op if said object being dropped

Re: Not clear spelling about transaction

2023-09-30 Thread David G. Johnston
On Sat, Sep 30, 2023 at 1:07 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html > Description: > > >No committed transactions will be lost > > Hello. It is not clear to me. Did

Re: missing GRANTED BY explanations

2023-09-30 Thread David G. Johnston
On Sat, Sep 30, 2023 at 1:56 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-revoke.html > Description: > > Hi, > In the documentation for revoke command, there is no description for > GRANTED >

Re: missing GRANTED BY explanations

2023-09-30 Thread David G. Johnston
On Saturday, September 30, 2023, PG Doc comments form < nore...@postgresql.org> wrote: > > > In the documentation for revoke command, there is no description for > GRANTED > BY clause. > > As the doc says read the grant page for more detailed information. Repeating everything here was deemed redund

Re: Corresponding documentation page does not mention about `spread` mode

2023-10-03 Thread David G. Johnston
On Tue, Oct 3, 2023 at 2:48 PM PG Doc comments form wrote: > > On [this > page](https://www.postgresql.org/docs/current/app-pgbasebackup.html) > `spread` is mentioned: > > -c {fast|spread} > --checkpoint={fast|spread} > > Sets checkpoint mode to fast (immediate) or spread (the default) (see >

Re: This is too implicit that recovery.signal will be removed

2023-10-05 Thread David G. Johnston
On Thu, Oct 5, 2023 at 8:15 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/runtime-config-wal.html > Description: > > Hello. > On the page > https://www.postgresql.org/docs/current/runtime-config-wa

Re: Unclear guarantees about sort order on https://www.postgresql.org/docs/current/queries-order.html

2023-10-05 Thread David G. Johnston
On Wed, Oct 4, 2023 at 6:37 PM Erik Wienhold wrote: > On 2023-10-04 16:24 +0200, PG Doc comments form write: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/queries-order.html > > Description: > > > > The document only says

Re: It is not clear from documentation when and how I should restore base backup

2023-10-05 Thread David G. Johnston
On Thu, Oct 5, 2023, 11:11 PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html > Description: > > Hello. > > On page: > > https://www.postgresql.org/docs/current/continuous-archivi

Re: Typo in PL/pgSQL trigger Example 43.4?

2023-10-07 Thread David G. Johnston
On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker wrote: > > INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= > ARGUMENT IN QUESTION > The emp_audit table has a column named 'userid', which in actual usage > (next-to-last line quoted) is populated by 'user' which seems undefined

Re: 31.7.1. Initial Snapshot

2023-10-11 Thread David G. Johnston
On Wed, Oct 11, 2023 at 9:32 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/16/logical-replication-architecture.html > Description: > > There are dublicated section named "31.7.1. Initial Snapshot" o

Re: Wrong article SET AUTOCOMMIT

2023-10-11 Thread David G. Johnston
On Wed, Oct 11, 2023 at 9:34 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/ecpg-sql-set-autocommit.html > Description: > > This article should be removed as this parameter does not exist since a >

Re: 31.7.1. Initial Snapshot

2023-10-11 Thread David G. Johnston
On Wed, Oct 11, 2023 at 9:41 AM Alvaro Herrera wrote: > Maybe a fix for this would be to style chapter TOCs in some way that > makes it clear that they are TOCs -- for example, add a (subtly) visible > bounding box, or something. Or maybe if a chapter has a single section, > just do not print th

Clarify: default precision on timestamps is 6

2023-10-13 Thread David G. Johnston
On Friday, October 13, 2023, PG Doc comments form wrote: > both of them round any precision > beyond microseconds, and neither returns timestamps with greater precision > than the value that was inserted. > That is precisely what a no default with maximum of six means. If we say the default is

Re: docs: set role permission checking, do I read this wrong?

2023-10-18 Thread David G. Johnston
On Wednesday, October 18, 2023, Daniel Westermann < daniel.westerm...@dbi-services.com> wrote: > > "After |SET ROLE|, permissions checking for SQL commands is carried out as > though the named role were the one that had logged in originally." > > Isn't it the other way around and permission checki

Re: docs: set role permission checking, do I read this wrong?

2023-10-18 Thread David G. Johnston
On Wednesday, October 18, 2023, Daniel Westermann < daniel.westerm...@dbi-services.com> wrote: > > Thank you, this is what I see in the small example. Maybe it is my > English, but this sentence sounds confusing. > How would you document that behavior? The sentence is correct; that doesn’t mean it

Re: opclass. See below for details. cannot found the "below".

2023-10-22 Thread David G. Johnston
On Sunday, October 22, 2023, jian he wrote: > https://www.postgresql.org/docs/current/sql-createindex.html > << > opclass > The name of an operator class. See below for details. > << > > there is no "below"? > Browser search, there are only four appearances of keyword "opclass". > > The notes on

Re: pg_isready --dbname option is broken. So it should not be in the manual

2023-10-26 Thread David G. Johnston
On Thursday, October 26, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/app-pg-isready.html > Description: > > the --dbname option in pg_isready seems not to work propperly. the tool > returns 'o

Re: pg_isready --dbname option is broken. So it should not be in the manual

2023-10-26 Thread David G. Johnston
On Thursday, October 26, 2023, Daniel Gustafsson wrote: > > On 26 Oct 2023, at 14:20, David G. Johnston > wrote: > > > > On Thursday, October 26, 2023, PG Doc comments form < > nore...@postgresql.org <mailto:nore...@postgresql.org>> wrote: > > The follo

Re: Full Text Search

2023-10-29 Thread David G. Johnston
On Sun, Oct 29, 2023, 13:58 PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/textsearch-limitations.html > Description: > > Hello, > > In the FTS/Limitations part of the documentation, it says : > > "Ano

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread David G. Johnston
On Wednesday, November 1, 2023, Bruce Momjian wrote: > On Tue, Nov 10, 2020 at 08:28:08AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/13/bug-reporting.html > > Description: > > > > Tablesp

Re: jsonb array accessors

2023-11-04 Thread David G. Johnston
On Saturday, November 4, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/datatype-json.html > Description: > > https://dbfiddle.uk/Dr-c-nqL > > multiple subscripts for jsonb arrays do not behave a

Re: Example for Unique Partial Indexes

2023-11-07 Thread David G. Johnston
On Tue, Nov 7, 2023, 09:25 PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/indexes-unique.html > Description: > > I would like to request an improvement to the PostgreSQL documentation, > specifically i

Re: Example for Unique Partial Indexes

2023-11-07 Thread David G. Johnston
On Tue, Nov 7, 2023 at 10:08 AM Tom Lane wrote: > "David G. Johnston" writes: > > On Tue, Nov 7, 2023, 09:25 PG Doc comments form > > wrote: > >> Currently, the documentation does not provide information on how to > create > >> unique partial in

Another user complaint regarding visibility of pg_catalog data

2023-11-07 Thread David G. Johnston
Hey, This comes up every so often (including today on Discord) and I keep having trouble figuring out where to point people for our official assertion and explanation for why anyone with a login can view routine bodies, view specifications, and comments. Apparently I griped about this a while ago

Re: Another user complaint regarding visibility of pg_catalog data

2023-11-07 Thread David G. Johnston
On Tue, Nov 7, 2023 at 12:28 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > Is this something we just don't want to go into detail within our > documentation, or just no one has cared enough to write something up > (beyond my first draft back then) and form it i

Re: Another user complaint regarding visibility of pg_catalog data

2023-11-08 Thread David G. Johnston
On Wednesday, November 8, 2023, Laurenz Albe wrote: > > > When people ask my "why?", I tend to answer "why not?". It is not a > security > problem, in my opinion. Every user is allowed to know that I have a table > "purchase" with a column "credit_card_nr". As long as the permissions are > set

Re: CREATE SUBSCRIPTION issue

2023-11-08 Thread David G. Johnston
On Wed, Nov 8, 2023 at 5:42 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/15/logical-replication-row-filter.html > Description: > > Hey I'm using create subscription to subscribe to a table. I have

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-17 Thread David G. Johnston
On Fri, Nov 17, 2023 at 3:13 PM Bruce Momjian wrote: > On Fri, Apr 27, 2018 at 01:47:49PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/9.5/static/sql-select.html > > Description: > > > > In

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread David G. Johnston
On Mon, Nov 20, 2023 at 7:04 PM Bruce Momjian wrote: > On Fri, Nov 17, 2023 at 03:44:04PM -0700, David G. Johnston wrote: > > I don't like this particular solution to the stated complaint. When a > FROM > > entry has an alias it must be referenced via that alias anywhere

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread David G. Johnston
On Mon, Nov 20, 2023 at 8:16 PM Bruce Momjian wrote: > On Mon, Nov 20, 2023 at 07:19:39PM -0700, David G. Johnston wrote: > > The placement in the numbered listing section feels wrong, I am OK with > > the wording. It should be down in the clause details. > > >

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread David G. Johnston
On Wed, Nov 22, 2023 at 12:26 PM Bruce Momjian wrote: > On Wed, Nov 22, 2023 at 06:26:45PM +0100, Álvaro Herrera wrote: > > On 2023-Nov-22, Laurenz Albe wrote: > > > > > I think the example had best be at "8.5.2. Date/Time Output", in > > > doc/src/sgml/datatype.sgml around line 2552. > > > > Act

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread David G. Johnston
On Wed, Nov 22, 2023 at 2:13 PM Bruce Momjian wrote: > On Wed, Nov 22, 2023 at 10:31:25AM +0100, Laurenz Albe wrote: > > I agree that the paragraph you are trying to improve needs it. > > > > I am not sure about that last sentence you added: > > > > The modification of > > EXCLUDED columns ha

Re: Mention that there will be no feedback.

2023-11-23 Thread David G. Johnston
On Thursday, November 23, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/tutorial-createdb.html > Description: > > You might want to mention that createdb will give no feedback after > creating >

Re: Table-space documentation

2023-11-27 Thread David G. Johnston
On Sunday, November 26, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/manage-ag-tablespaces.html > Description: > > While reading the table-space documentation > https://www.postgresql.org/docs/

Re: Clarification regarding CREATE TABLE LIKE and FOREIGN KEYS

2023-12-01 Thread David G. Johnston
On Fri, Dec 1, 2023 at 7:07 AM David Virebayre wrote: > "INCLUDING ALL" leads people to believe *everything* is copied. > > The fact that it doesn't seem counter intuitive, at least to me. > > Therefore, it doesn't seem absurd to me to warn people about what is not > copied. > > I wrote the origi

Re: Missing "CONSTRAINT" keyword in ADD CONSTRAINT form?

2023-12-04 Thread David G. Johnston
On Monday, December 4, 2023, Tim Needham wrote: > Bah, scratch that, sorry again. It's because "CONSTRAINT" is implied by > the reference to CREATE DOMAIN, isn't it? > Yes, we require the reader to go to the create domain page to read the “domain_constraint” portion of the syntax. David J.

Re: Where is using a table name as a "row value" documented?

2023-12-08 Thread David G. Johnston
On Friday, December 8, 2023, Gulyás Attila wrote: > > Unfortunately, neither the row constructor docs[7] nor the pages > referenced there mention this usage anywhere (unless I missed it somehow). > I also found this answer[8] helpful when trying to find the relevant docs. > I found this fairly,q

Re: unclear wording re: spoofing prevention on network connections

2023-12-09 Thread David G. Johnston
On Saturday, December 9, 2023, Stephen Frost wrote: > > > The idea is that you can use both TLS and GSSAPI-with-encryption at the > same time within a given cluster for connections but you wouldn’t use them > on the same connection. Certainly would welcome suggestions as to the best > way to phr

Re: Documentation does not describes format for access privileges: =Tc/user

2023-12-24 Thread David G. Johnston
On Friday, December 22, 2023, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/ddl-priv.html > Description: > > Hello. > The page https://www.postgresql.org/docs/current/ddl-priv.html does not > describe

Re: Documentation does not describes format for access privileges: =Tc/user

2023-12-25 Thread David G. Johnston
On Monday, December 25, 2023, Eugen Konkov wrote: > No, it does not. If you refer to `An empty grantee field in an aclitem > stands for PUBLIC.` then "grantee field" was never described. What is > this? > > It would be very clear if it was described in this way: > The access privileges has the fo

Re: Documentation does not describes format for access privileges: =Tc/user

2023-12-25 Thread David G. Johnston
On Monday, December 25, 2023, David G. Johnston wrote: > On Monday, December 25, 2023, Eugen Konkov wrote: > >> No, it does not. If you refer to `An empty grantee field in an aclitem >> stands for PUBLIC.` then "grantee field" was never described. What is >>

Re: string_agg

2023-12-28 Thread David G. Johnston
On Wednesday, December 27, 2023, PG Doc comments form < nore...@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/functions-aggregate.html > Description: > > Please add the argument "distinct" to the documentat

Re: Transition relation clarification

2024-01-01 Thread David G. Johnston
On Mon, Jan 1, 2024 at 9:35 AM Dull Bananas wrote: > The docs should mention that transition relations aren't automatically > made available in functions called by the trigger function. This unknown > behavior caused a lot of frustration for me. Seems to fall into the "if it isn't documented it

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
from a more ambitious patch. > > Author: David G. Johnston > Discussion: https://postgr.es/m/CAKFQuwZC4K0XYBm0bwBMDOZySBqhO > sekdhluaw4vpi+ozi8...@mail.gmail.com > > used this text for the --username option: > >-U username >--usern

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
On Saturday, January 6, 2024, Bruce Momjian wrote: > On Sat, Jan 6, 2024 at 08:11:14PM -0700, David G. Johnston wrote: > > On Saturday, January 6, 2024, Bruce Momjian wrote: > > > > This commit: > > > > commit 910cab820d >

Re: initdb username doc bug

2024-01-06 Thread David G. Johnston
On Saturday, January 6, 2024, David G. Johnston wrote: > On Saturday, January 6, 2024, Bruce Momjian wrote: > >> >> geteuid() returns the effective user ID of the calling process. >> >> so it is not the owner of the data dirctory, but the installation u

Re: Grammar suggestion

2024-01-08 Thread David G. Johnston
On Monday, January 8, 2024, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/ddl-constraints.html > Description: > > Dear postgres Team, > > I happened to have stumbled across a tricky to read sentence i

Re: initdb username doc bug

2024-01-08 Thread David G. Johnston
On Mon, Jan 8, 2024 at 2:26 PM Bruce Momjian wrote: > On Sat, Jan 6, 2024 at 11:27:14PM -0500, Tom Lane wrote: > > "David G. Johnston" writes: > > > Or just the bit more verbose “user running the initdb command” and > don’t > > > bother giving it a lab

Re: Question on doc for RETURNING clause

2024-01-11 Thread David G. Johnston
On Thu, Jan 11, 2024 at 11:55 AM Russell, John wrote: > ``` > postgres=> insert into generatedfields (x) values (0), (10), (100) order > by 2 desc returning id, x; > ERROR: ORDER BY position 2 is not in select list > LINE 1: ...eratedfields (x) values (0), (10), (100) order by 2 desc ret... >

Re: CREATE ROLE inheritance details

2024-01-17 Thread David G. Johnston
oth parts of the sentence instead of switching to "... roles are given" for the second half. More of a style choice but I didn't think switching really added much and just makes it a bit wordier and possibly a bit more effort to mentally parse. Patch built on top of Bruce's role

Re: Creating the scripts and compiling the C files containing user-defined functions and types.

2024-01-18 Thread David G. Johnston
On Thursday, January 18, 2024, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/tutorial-sql-intro.html > Description: > > " Directory of C:\postgresql-16.1\src\tutorial > > 11/06/2023 11:17 PM

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-18 Thread David G. Johnston
presenting an alternative approach to introducing namespacing when we explain why schemas exist. David J. From 4ba026d1a42e074df103a769e0f6b71629631c87 Mon Sep 17 00:00:00 2001 From: "David G. Johnston" Date: Thu, 18 Jan 2024 14:15:33 -0700 Subject: [PATCH] Doc-objects-in-pg_class-share

Re: About COPY

2024-01-19 Thread David G. Johnston
On Friday, January 19, 2024, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/tutorial-populate.html > Description: > > COPY weather FROM '/home/user/weather.txt'; is not working it requires > additional

Re: Missing information on '-X' in section 26.3.6.1.

2024-01-23 Thread David G. Johnston
On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/continuous-archiving.html > Description: > > I noticed, that in section 26.3.6.1. it's not specified, what the -X > parame

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 8:35 AM Laurenz Albe wrote: > On Wed, 2024-01-24 at 15:40 +0100, gp...@free.fr wrote: > > maybe a misunderstanding of my part, but your proposed modification > doesn't matched > > with the current behaviour of the command as precisely the object > privileges of the old own

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 9:13 AM Laurenz Albe wrote: > On Wed, 2024-01-24 at 08:47 -0700, David G. Johnston wrote: > > I dislike this change, ownership of an object is completely independent > of > > the grant system of privileges. The granted privileges of the old row do >

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 9:23 AM wrote:- > [postgres] $ psql > psql (14.10) > > You really should add commentary, especially since you never demonstrated the tst role (I advise picking different names for all of the objects in the future) being unable to login. Which they should be able to since

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 9:56 AM Alvaro Herrera wrote: > On 2024-Jan-24, Laurenz Albe wrote: > > > The permissions are transferred to the new owner, so the old owner > doesn't > > have any privileges on the object (and, in your case, cannot connect to > > the database any more). > > However, if th

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 10:13 AM Tom Lane wrote: > "David G. Johnston" writes: > > postgres=# grant all on database newdb2 to testowner; > > -- as I am logged in as davidj this grant should actually happen, with > > davidj as the grantor > > -- the grants th

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-24 Thread David G. Johnston
On Wed, Jan 24, 2024 at 7:23 AM Laurenz Albe wrote: > On Wed, 2024-01-24 at 11:08 +0100, gp...@free.fr wrote: > > for this "ALTER DATABASE" form, it should be mentioned that after > execution of the command, > > the old database owner loses all his privileges on it (even connection) > although it

Re: SQL command : ALTER DATABASE OWNER TO

2024-01-25 Thread David G. Johnston
. On Thu, Jan 25, 2024 at 7:35 AM Laurenz Albe wrote: > On Wed, 2024-01-24 at 16:04 -0700, David G. Johnston wrote: > > Here's a slightly more detailed patch to consider to cover both the > transference of ownership as well as documenting precisely what ownership > means. >

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-26 Thread David G. Johnston
On Fri, Jan 19, 2024 at 3:46 AM Laurenz Albe wrote: > In the attached patch, I have copied the enumeration of relations from > the CREATE INDEX page. I think this small redundance is alright, but I > wouldn't mind if this gets removed from CREATE INDEX. > > Tweaking the main paragraph a little.

Re: CREATE ROLE inheritance details

2024-01-28 Thread David G. Johnston
On Fri, Jan 26, 2024 at 5:18 PM Bruce Momjian wrote: > > Just a reminder, this is for PG 16 and master. > > +Role membership with the inherit attribute can automatically use +whatever database privileges have been granted to all roles it +is directly or indirectly a memb

Re: CREATE ROLE inheritance details

2024-01-30 Thread David G. Johnston
50ab3e95871 Mon Sep 17 00:00:00 2001 From: "David G. Johnston" Date: Tue, 30 Jan 2024 13:17:47 -0700 Subject: [PATCH] base rev description addition and tweaks grant tweaks --- doc/src/sgml/ref/create_role.sgml | 87 +++ doc/src/sgml/ref/grant.sgml | 29

Re: Missed information about clientname=CN option

2024-01-31 Thread David G. Johnston
On Wednesday, January 31, 2024, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/auth-cert.html > Description: > > Hello. > > This page missed information about supported clientname=CN/DN option and > de

Re: Missed information about clientname=CN option

2024-02-01 Thread David G. Johnston
On Thu, Feb 1, 2024 at 3:16 AM Daniel Gustafsson wrote: > > On 1 Feb 2024, at 08:35, David G. Johnston > wrote: > > > maybe move the wording to the cert page and replace the content in > pg_hba.conf with a link to there. Leaning toward the later ATM. > > That sound

Re: Missing information on '-X' in section 26.3.6.1.

2024-02-02 Thread David G. Johnston
On Wed, Jan 24, 2024 at 2:19 AM Daniel Gustafsson wrote: > > On 23 Jan 2024, at 21:43, David G. Johnston > wrote: > > > > On Tue, Jan 23, 2024 at 1:30 PM PG Doc comments form < > nore...@postgresql.org <mailto:nore...@postgresql.org>> wrote: > > Th

Re: system column

2024-02-07 Thread David G. Johnston
On Wednesday, February 7, 2024, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/ddl-system-columns.html > Description: > > Will be clear to have a picture of how they are in the database. > Do you have

  1   2   3   4   5   >