The docs use PostgreSQL and not Postgres in all but two places, which I think
we should change like in the attached to be consistent. Any objections to this?
--
Daniel Gustafsson
postgres_title.diff
Description: Binary data
> On 14 Mar 2023, at 13:55, Jonathan S. Katz wrote:
>
> On 3/14/23 7:31 AM, Alvaro Herrera wrote:
>> On 2023-Mar-14, Daniel Gustafsson wrote:
>>> The docs use PostgreSQL and not Postgres in all but two places, which I
>>> think
>>> we should change
-99499::numeric(2, -3) as neg, 99499::numeric(2, -3) as pos;
neg | pos
+---
-99000 | 99000
(1 row)
--
Daniel Gustafsson
htly to something like this to make it clearer?
"For more information on character sets refer to Section 24.3"
> A really minor point, but it caught me off-guard.
In Postgres we excel at caring about minor points, so thanks for your report!
--
Daniel Gustafsson
o report is too small to be
valuable.
--
Daniel Gustafsson
ot;second query" or something like that, though.
Reading this section I agree that the mix of ok/danger in the same example can
be tad misleading though. Something like the attached is what I would prefer
as a reader.
--
Daniel Gustafsson
adv_lock_limit.diff
Description: Binary data
> On 31 Mar 2023, at 14:35, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Reading this section I agree that the mix of ok/danger in the same example
>> can
>> be tad misleading though. Something like the attached is what I would prefer
>> as a reader.
&g
ces with something a bit more
> spelled-out, perhaps "mcv_freqs".
I was inclined to spell it out as mcv_frequencies but we use xxx_freqs
elsewhere on the same page so keeping it consistent seems better. The attached
does this as well as adding mcf/mcv as acronyms as previously mentioned (since
they are both tagged as ).
--
Daniel Gustafsson
mcf_mcv.diff
Description: Binary data
> On 12 Apr 2023, at 14:14, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> I was inclined to spell it out as mcv_frequencies but we use xxx_freqs
>> elsewhere on the same page so keeping it consistent seems better. The
>> attached
>> does this as well
fic code for Windows.
We have pq_setkeepaliveswin32() for Windows which can work on Windows 2000 and
later versions based on the existence of SIO_KEEPALIVE_VALS.
> Random googling suggests that TCP_KEEPCNT does exist on Windows.
For Windows what you want is SIO_KEEPALIVE_VALS.
--
Daniel Gustafsson
> On 26 Apr 2023, at 10:18, Daniel Gustafsson wrote:
>
>> On 26 Apr 2023, at 08:08, Peter Eisentraut
>> wrote:
>
>> I wonder if the notes are even true. The text for tcp_keepalives_interval
>> already says that it is only supported if TCP_KEEPCNT is supporte
he acronyms list but I think it's more appropriate in
> the glossary, so I moved things around a bit.
+1 LGTM.
+
+ LSN
+
+
The other entries doesn't have a glossentry id
attribute set, is the use here related to the glossentry.show.acronym param?
--
Daniel Gustafsson
> On 2 May 2023, at 12:24, Alvaro Herrera wrote:
>
> On 2023-May-02, Daniel Gustafsson wrote:
>
>> +
>> + LSN
>> +
>> +
>>
>> The other entries doesn't have a glossentry id
>> attribute set, is the use here related to the gl
ions which are still in use,
but until there is a report from a more recent version than 7.3 there isn't
much cause for concern I reckon.
--
Daniel Gustafsson
> On 5 May 2023, at 15:42, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> This is actually not an error in the 7.3 docs (which we clearly wouldn't
>> address) but an error in pgweb in the warning for unsupported versions; it
>> assumes it can link to the same
tom
> table layout, looks fine. Anyone feel like looking into this further?
Can you post a screenshot of what it looks like? I just built the manpages
from HEAD on macOS and while they report the UNSUPP error the table itself
looks like I would expect it to.
--
Daniel Gustafsson
re to maintain.
Not sure what the best path going forward is, relying on in-column formatting
for tables seems problematic when mandoc is used.
--
Daniel Gustafsson
mandoc_para_tbl.diff
Description: Binary data
> On 10 May 2023, at 17:35, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> I took a look at this using macOS as the initial testbed; the TLDR is that
>> mandoc doesn't support macros in tables, and our single-column function
>> signature tables rely on that. m
> On 10 May 2023, at 22:08, Daniel Gustafsson wrote:
>
>> On 10 May 2023, at 17:35, Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> I took a look at this using macOS as the initial testbed; the TLDR is that
>>> mandoc doesn't support m
indows but the latter two are not.
I think this is a clear improvement over the current docs.
Should we call out Windows explicitly in the same way in the corresponding
options in the libpq connection string param docs as well?
--
Daniel Gustafsson
call that out. The original gripe was about readability, but
> if we think the description in the other settings is no clear enough, we can
> edit it.
TCP_USER_TIMEOUT is not widely available, AFAIK FreeBSD, OpenBSD and macOS do
not support it yet.
--
Daniel Gustafsson
habetical and
grouped last, and pg_amcheck groups options by type.
Whether or not an option has a short option as well as a long option is an
implementation detail that I don't think should drive how we present the
information to the users in order to help them find what they need.
--
Daniel Gustafsson
ly spelled out
further down on the page, but for anyone looking for a quick answer and not
reading the whole page the current example might be misleading.
--
Daniel Gustafsson
errhint_example.diff
Description: Binary data
> On 12 Jul 2023, at 15:30, Jonathan S. Katz wrote:
>
> On 7/12/23 3:08 AM, Daniel Gustafsson wrote:
>> It was noted in 20230712015948.byqaftt57glwk...@awork3.anarazel.de that the
>> errhint example in sources.sgml isn't as helpful as it could be. errhint
>> sho
> On 14 Jul 2023, at 14:22, Niels Bom wrote:
> I found a dead link on this page: https://www.postgresql.org/download/macosx/
Thanks for your report! This was recently reported by someone else as well and
we’re currently discussing on the -www mailinglist on how to address it best.
./daniel
ders will likely skim over and immediately look at
the table, missing the small disclaimer. I wonder if we aren't serving our
users better by removing the table and only referring to the Wiki page? Having
two lists will prompt the discussion of what to include where over and over
again, whi
think we should attempt to describe them in more detail than what
we currently do.
--
Daniel Gustafsson
> On 22 Aug 2023, at 05:23, Jonathan S. Katz wrote:
>
> On 8/21/23 10:55 AM, Jonathan S. Katz wrote:
>> On 8/21/23 7:58 AM, Daniel Gustafsson wrote:
>>>> On 11 Aug 2023, at 02:23, Jonathan S. Katz wrote:
>>>
>>>> The last time this came u
trix
>>>
>>> Similar to this thread[1], I wonder if we just link to the wiki from the
>>> documentation, given it will be easier to maintain the list from there.
>> Makes sense.
>
> Please see attached patch that does exactly this. It follows similar
> semantics as [1].
LGTM, let's apply it along with the patch in [1] to all branches.
--
Daniel Gustafsson
> On 22 Aug 2023, at 16:25, Jonathan S. Katz wrote:
>
> On 8/22/23 3:10 AM, Daniel Gustafsson wrote:
>
>> This is in line with what I imagined as well, so unless anyone thinks
>> otherwise
>> I will apply this and backpatch it to all branches.
>
> I could
It might be worth replacing this to make the docs more
uniform, but that's for another patch (and thread), for now it's using the same
syntax already present here.
--
Daniel Gustafsson
file_fdw_options.diff
Description: Binary data
> On 13 Sep 2023, at 22:10, Boshomi Phenix wrote:
>
> Am Di., 12. Sept. 2023 um 12:25 Uhr schrieb Daniel Gustafsson
> mailto:dan...@yesql.se>>:
>
> Considering that we don't really have the OPTIONS syntax documented in an
> example, and that we reference COPY
lmost".
While I'm not a native english speaker I do believe this wording is correct
(although I guess your version would be semantically the same or very close to
it). It was done in commit 83501ef4ca some 20+ years ago.
--
Daniel Gustafsson
ather than any change of technical content.
> I propose the attached. (I also modified the para's last sentence to
> speak of "kind" not "type", for consistency with the relkind field name
> and the rest of the para.)
LGTM.
--
Daniel Gustafsson
e that we might as well sort out now what to do about that.
--
Daniel Gustafsson
> On 25 Sep 2023, at 14:22, Alvaro Herrera wrote:
>
> On 2023-Sep-25, Daniel Gustafsson wrote:
>
>> This does of course present a question for the backbranches, pointing to the
>> HEAD version in the docs for a previous major release isn't entirely
>> accurat
od point, how is this attached patch?
LGTM.
--
Daniel Gustafsson
> On 27 Sep 2023, at 15:18, Peter Eisentraut wrote:
>
> On 25.09.23 13:09, Daniel Gustafsson wrote:
>> Commit b73c3a11963 introduced xyz
>> hyperlinks for files in the postgres source tree by linking to the gitweb
>> interface at git.postgresql.org. This, IMO, ma
's intended to be a variable or column reference than
> a built-in function.
Agreed, and "user" is a hard search term to use for discovering what it is. +1
for changing to current_user.
--
Daniel Gustafsson
docs/11/view-pg-sequences.html) is incorrect, so
> I've fixed it. Patches are attached, please have a look.
Thanks for the report, this is indeed incorrect. I've applied this patch to 11
and 12.
--
Daniel Gustafsson
book referred to for the example, we don't
expect our readers to either so it seems to me that we could remove it from the
example to avoid risk of confusion. Would you like to propose a patch for this?
--
Daniel Gustafsson
0604%40agliodbs.com>
>
> Read the notes section.
The notes section is pretty hidden though, I can sympathize with anyone missing
it and maybe making the info a bit more visible would be good?
--
Daniel Gustafsson
not I
think it should be backpatched all the way since it exists for all supported
versions.
--
Daniel Gustafsson
for
Indexes and one for Relations. In the attached diff I propose that we add a
glossary entry for Access Method (suggested better wording much appreciated)
which the acronym can refer to. Being such a core concept it doesn't seem like
a bad idea to explain it.
--
Daniel Gustafsson
am_acronym.diff
Description: Binary data
es.
No need for an apology. *All* contributions are valuable, big and small. I'll
go ahead and fix this, thanks for the report!
--
Daniel Gustafsson
> On 13 Nov 2023, at 12:20, Alvaro Herrera wrote:
>
> On 2023-Nov-13, Daniel Gustafsson wrote:
>
>> That's a fair point. It's sort of hard to refer back from the acronym list
>> though since we don't have a single Access Method section but instead o
This form is not intended to be used for general questions about postgres,
please use the appropriate mailinglist for this. In your case I would
recomment pgsql-general.
https://www.postgresql.org/list/
--
Daniel Gustafsson
_data_wrapper where fdwname='dummy';
fdwoptions
--
{foo=1,drop=bar}
(1 row)
This has been incorrect since forever so I will backpatch this into all
supported versions.
--
Daniel Gustafsson
t, the attached diff updates the compiler and comment as
per the above. Unless there are objections I'll go ahead with that.
--
Daniel Gustafsson
freebsd_compiler.diff
Description: Binary data
it doesn't hurt to spell out what we take for granted but a
newcomer have to figure out in order to make the documentation easy to follow
for new users. Something like the attached would be enough I think.
--
Daniel Gustafsson
pg_basebackup_X.diff
Description: Binary data
inherit the privileges of the
>owning role) and able to SET ROLE to the new owning
> role.
> + All object privileges of the old owner are transferred to the new owner
> + along with the ownership.
>
Doesn't seem unreasonable to me, it won't make the docs harder to read and use
for experienced users while it may make them easier to follow for new users.
--
Daniel Gustafsson
login_trigger enable always trigger;
^
The attached trivial patch removes the extra keyword, which needs to be
backpatched all the way down.
--
Daniel Gustafsson
alter_evt.diff
Description: Binary data
eral mailinglist
or pgsql-novice list for help getting started:
https://www.postgresql.org/list/
--
Daniel Gustafsson
ingle dash. Thanks for the report, I'll fix
this backpatched down to 14 where it was introduced.
--
Daniel Gustafsson
> On 1 Feb 2024, at 08:35, David G. Johnston wrote:
> maybe move the wording to the cert page and replace the content in
> pg_hba.conf with a link to there. Leaning toward the later ATM.
That sounds like the best option IMHO, care to propose a patch?
--
Daniel Gustafsson
ase notes though.
While not directly to the v12 release notes, it leads to a page where the
release notes are linked from which seems good enough here. This is a note on
a change that happened in the oldest still supported version, with the previous
behavior EOL.
--
Daniel Gustafsson
> On 6 Feb 2024, at 11:46, Alvaro Herrera wrote:
>
> On 2024-Feb-06, Daniel Gustafsson wrote:
>
>>> On 5 Feb 2024, at 22:23, PG Doc comments form
>>> wrote:
>>
>>> This page has a link that says "See the release notes for Postgr
> On 7 Feb 2024, at 22:33, PG Doc comments form wrote:
> [ STRATEGY [=] strategy ] ]
>
> ...has a superfluous ], I think?
Nice catch, it sure seems like so. Will fix, thanks for the report!
--
Daniel Gustafsson
writer GUCs so it doesn't seem like an
unreasonable idea. It might not help too many, but not printing it at all
clearly doesn't really help anyone.
--
Daniel Gustafsson
is unlikely to provide more insights than what more
curated sites can do.
--
Daniel Gustafsson
> On 13 Feb 2024, at 20:42, Tom Lane wrote:
>
> Magnus Hagander writes:
>> On Tue, Feb 13, 2024 at 7:12 PM Daniel Gustafsson wrote:
>>> However, I wonder if we aren't better off removing the "Useful Reading"
>>> section
>>> altog
> On 13 Feb 2024, at 21:24, Magnus Hagander wrote:
>
> On Tue, Feb 13, 2024 at 9:08 PM Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> On 13 Feb 2024, at 20:42, Tom Lane wrote:
>>>> I'm a little dubious about the "Technical References
> On 21 Feb 2024, at 03:24, Erik Wienhold wrote:
>
> The docs on pg_reload_conf() in v15, v16, and devel have an incorrect
> link to pg_ident_file_mappings. The attached patch fixes that.
Nice catch, will fix.
--
Daniel Gustafsson
, unless Peter (on cc:) objects.
--
Daniel Gustafsson
f303.diff
Description: Binary data
x27;t have a copy of the standard though so
I'll leave it to someone who does comment.
--
Daniel Gustafsson
e changed, will fix.
>> - Add a statement 'The option specified on a table overrides an option
>> specified for the server.'
>
> I think that applies to all options. It would be better to have a general
> statement to that effect at the beginning of the "Options" section.
Yeah, that might be a good idead.
--
Daniel Gustafsson
locations.
--
Daniel Gustafsson
v1-0001-doc-Update-links-to-RFC-documents-to-avoid-redire.patch
Description: Binary data
> On 3 Apr 2024, at 14:23, Magnus Hagander wrote:
>
> On Wed, Apr 3, 2024 at 1:18 PM Daniel Gustafsson <mailto:dan...@yesql.se>> wrote:
> The tools.ietf.org <http://tools.ietf.org/> server which we use for all
> RFC/BCP links in the docs has
> been deco
> On 9 Apr 2024, at 16:02, Arne Sommerfelt wrote:
>
Thats the documentation for v16, not the version you are running.
--
Daniel Gustafsson
reading for your version if Postgres:
https://www.postgresql.org/docs/12/index.html
--
Daniel Gustafsson
ion which the project still supports with bugfixes.
--
Daniel Gustafsson
gt;
> https://www.postgresql.org/docs/current/app-psql.html
Nice catch, will fix.
--
Daniel Gustafsson
> On 9 Apr 2024, at 18:33, Daniel Gustafsson wrote:
>
>> On 9 Apr 2024, at 16:05, PG Doc comments form wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/app-psql.html
>>
> On 4 Apr 2024, at 12:41, Daniel Gustafsson wrote:
>
>> On 3 Apr 2024, at 14:23, Magnus Hagander wrote:
>>
>> On Wed, Apr 3, 2024 at 1:18 PM Daniel Gustafsson > <mailto:dan...@yesql.se>> wrote:
>> The tools.ietf.org <http://tools.ietf.org/> serv
> On 16 Apr 2024, at 12:42, Pavel Luzanov wrote:
>
> Please consider a small correction of the link to the initial data
> synchronization section on the pg_createsubscriber page.
Agreed, that makes sense. Applied.
--
Daniel Gustafsson
stdb(> FROM my_table t1 CROSS JOIN my_table t2 ORDER BY 1 DESC
> testdb(> \crosstabview "A" "B" "AxB" ord
> ```
That's an impressively eagle-eyed observation, it is indeed showing an open
parenthesis where none is. Will fix.
--
Daniel Gustafsson
gt; documentation is needed here.
This sounds like a question for the Homebrew maintainers, the postgres project
is not packaging postgres for Homebrew and have no insight into how they do it.
--
Daniel Gustafsson
> On 22 Apr 2024, at 10:45, Daniel Gustafsson wrote:
>
>> On 21 Apr 2024, at 12:57, PG Doc comments form
>> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/app-psql.html
e schema/table in the backup file.
+least one schema/table in the file to be restored.
Would it make sense to use "import" in some cases instead?
--
Daniel Gustafsson
dds proper markup in the
paragraph while in there).
--
Daniel Gustafsson
ssl_prefer_cipher.diff
Description: Binary data
> On 3 Jul 2024, at 18:22, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> In the documentation for ssl_prefer_server_ciphers we only say it's not in
>> "older version" but we omit to specify it further. Since it's a fairly
>> important setting
appened in PostgreSQL since then can be found
in Appendix E."
While technically true, it seems a bit overpromising in a history section to
refer to the release notes which are written in a very different way from the
prose here (and the release notes are not even in Appendix E anymore).
--
Daniel Gustafsson
> On 3 Jul 2024, at 11:49, Peter Eisentraut wrote:
>
> On 03.07.24 11:23, Daniel Gustafsson wrote:
>> In the documentation for ssl_prefer_server_ciphers we only say it's not in
>> "older version" but we omit to specify it further. Since it's a fairly
>
Ports, in the
> bibliography leads to a forbidden page.
Does it still do that? Clicking the link leads me to the referenced paper.
--
Daniel Gustafsson
> On 4 Jul 2024, at 17:12, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Unrelated to that, but reading history.sgml I found this sentend at the end
>> of
>> the page to be sort of misleading:
>
>> "Details about what has happened in PostgreSQL
> On 4 Jul 2024, at 22:22, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 4 Jul 2024, at 07:40, Tom Lane wrote:
>>> I happened to come across this:
>>> https://arxiv.org/pdf/1901.01973
>>> I found this to be really interesting reading,
ndard the pilcrow [0] is, AFAICT from a bit of looking at other
docs, commonly used for this. There is a lot of variability though so
whichever we choose it will be wrong one for someone.
--
Daniel Gustafsson
[0] https://en.wikipedia.org/wiki/Pilcrow
> On 18 Jul 2024, at 15:49, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> While not a standard the pilcrow [0] is, AFAICT from a bit of looking at
>> other
>> docs, commonly used for this. There is a lot of variability though so
>> whichever we choose
ight have misunderstood the grammarfrom not being a native speaker), but I'm still inclined to change since weconsistently use "result sets" in the rest of the documentation.
--Daniel Gustafsson
0001-doc-Consistent-use-result-set-in-documentation.patch
Description: Binary data
n the description to avoid any confusion.
Something like:
-INSERT command. The value specified must be a
+INSERT command to be
nrows. The value specified must be a
There are many more options without parameters named in the description though.
--
Daniel Gustafsson
This is probably the source of your problem. IIRC, pg_upgrade
> needs to be pointed at the actual old data directory, not
> PGDATA=/var/lib/pgsql/10/data.
Correct, pg_upgrade use the PGDATANEW and PGDATAOLD env variables for the
cluster data directories.
--
Daniel Gustafsson
for NOT NULL constraints at all, so they are not
This seems mostly to be a question of taste, I don't think not-null is
incorrect here.
--
Daniel Gustafsson
laces on that same page which should be built-in
rather than builtin to separate the concept from the parameter value.
--
Daniel Gustafsson
When looking at review comments on one of my patches, I noticed that commit
41ea0c23761 didn’t include the PARALLEL keyword for the old style CREATE
AGGREGATE syntax. Since it is supported, and commit 59b71c6fe6c use it in a
testcase, it seems reasonable to add something along the lines of the att
> On 24 Jan 2018, at 03:52, Bruce Momjian wrote:
>
> Robert, can you review the attached patch since it references your
> commit? Thanks.
Another approach is the patch in 62991614-9673-4276-99cc-6754e7a05...@yesql.se
which contains a fix which allows for PARALLEL to be unquoted in the old synta
Is there a reason for not ending all partitioning commands with semicolons in
the declarative partitioning example?
https://www.postgresql.org/docs/devel/static/ddl-partitioning.html
The two last commands with TABLESPACE clauses are ended with semicolons, the
first three arent. Attached
> On 01 Feb 2018, at 13:09, PG Doc comments form wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/9.3/static/sql-keywords-appendix.html
> Description:
>
> Hello, my client has a plethora of reserved words in their PostgreSQ
WaitForBackgroundWorkerShutdown() was added in 924bcf4f16d, but never
documented which seems like an oversight for such a useful function. The
attached patch adds this to bgworker.sgml, and also fixes what I believe are
typos in the WaitForBackgroundWorkerStartup paragraph.
cheers ./daniel
bgw
> On 26 Feb 2018, at 16:18, Indrek K wrote:
> Please upgrade PostgreSQL document to latest version
> https://www.postgresql.org/download/linux/ubuntu/
> Change apt-get install postgresql-9.6 > postgresql-10
The download pages are not guaranteed to always be up to date with the current
release v
> On 01 Mar 2018, at 17:46, Andres Freund wrote:
>
> On 2018-02-09 23:43:26 +0100, Daniel Gustafsson wrote:
>> WaitForBackgroundWorkerShutdown() was added in 924bcf4f16d, but never
>> documented which seems like an oversight for such a useful function. The
>>
1 - 100 of 263 matches
Mail list logo
