Re: broken link

2023-01-18 Thread Bruce Momjian
link at the > very bottom: "Bruce Momjian's presentation" > http://momjian.us/main/presentations/features.html#securing URL fixed to https://momjian.us/main/presentations/administration.html#securing, though it feels the item was just appened to the FAQ. -- Bruce Mo

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
_ syntaxes in the "Synopsis" section, so we could just remove them. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Embrace your flaws. They make you human, rather than perfect, which you will never be.

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 09:52:15PM +0100, Tomisław Kityński wrote: > W dniu 30.01.2023 o 21:39, Bruce Momjian pisze: > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: &g

Re: Suggestion for deprecated spellings

2023-01-30 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > >> From time to time some spelling for given command gets obsolete, yet it is > >> shown in the syntax on &q

Re: I think that the transaction tutorial document (3.4) should mention transaction isolation

2023-03-29 Thread Bruce Momjian
ns fail, and referring to the more details > document, would help users prevent consistency bugs. Well, the point is that the application is _not_ retrieving a value and setting is +100, but rather having the SQL add 100, which is kind of the point. I don't think a tutorial should get into

Re: PostgreSQL 16 release notes: could cloud

2023-06-05 Thread Bruce Momjian
the release notes on the community website are unchanged since beta1 was packaged; please see the current contents here: https://momjian.us/pgsql_docs/release-16.html -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: PostgreSQL 16 release notes: could cloud

2023-06-05 Thread Bruce Momjian
On Mon, Jun 5, 2023 at 07:12:35PM +0200, Erik Rijkers wrote: > Op 6/5/23 om 17:44 schreef Bruce Momjian: > > On Mon, Jun 5, 2023 at 08:26:07AM +, Daniel Westermann (DWE) wrote: > > > > > > > I guess one "could" should be enough? > > > >

Re: [PATCH] two minor fixes to MVCC docs

2023-06-20 Thread Bruce Momjian
and > (SELECT, INSERT, > - UPDATE, or DELETE), so > - it is possible to obtain locks explicitly before the snapshot is > - frozen. > + UPDATE, DELETE, or > + MERGE), so it is possible to obtain locks explicitly > + before the snapshot is frozen. > > > > -- > 2.25.1 > -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Change "two" to "three" for decades of development in history

2023-06-21 Thread Bruce Momjian
ly_ correct. Attached patch applied back to PG 11. Seems we will need to change this to "four" in a few years too. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. com

Re: Change "two" to "three" for decades of development in history

2023-06-22 Thread Bruce Momjian
uppose DocBook has macro and system-variable capabilities? That could > provide a set-and-forget solution to this? Uh, I am not aware of any. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: bad choice of the word in sentence

2023-06-23 Thread Bruce Momjian
t; "<...>Also note that two successive SELECT commands can see different data, > even though they are within a single transaction, if other transactions > commit changes after the first SELECT starts and before the second SELECT > starts. <...>&qu

Re: bad choice of the word in sentence

2023-06-23 Thread Bruce Momjian
On Fri, Jun 23, 2023 at 09:16:39PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Thu, Jun 22, 2023 at 06:38:37PM +, PG Doc comments form wrote: > >> Quote: > >> "<...>When a transaction uses this isolation level, a SELECT query (without > >

Re: Change "two" to "three" for decades of development in history

2023-06-23 Thread Bruce Momjian
hanging this. > > +1. With the proposed language, we can revisit it once it gets to > "centuries." Applied patch is "With decades of development". -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Include rust as an externally maintained procedural language

2023-08-12 Thread Bruce Momjian
> Similar to this thread[1], I wonder if we just link to the wiki from the > documentation, given it will be easier to maintain the list from there. Makes sense. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Replica vs standby

2023-09-05 Thread Bruce Momjian
rsion 10 (that adds it) was EOL more than 9 months ago. > > > [1] https://www.postgresql.org/docs/current/glossary.html > [2] https://www.postgresql.org/docs/current/logical-replication-config.html > [3] https://www.postgresql.org/docs/current/runtime-config-replication.html > > > -- > Euler Taveira > EDB https://www.enterprisedb.com/ > -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Replica vs standby

2023-09-06 Thread Bruce Momjian
On Wed, Sep 6, 2023 at 09:02:02AM +0200, Peter Eisentraut wrote: > On 06.09.23 03:42, Bruce Momjian wrote: > > There are other cases in our docs where we call something a standby and > > mean only a physical standby/replica. Should these be clarified? > > When "hot st

Re: to_char(numeric type, text) rounding instead of truncating

2023-09-06 Thread Bruce Momjian
1235::real/(2::real+1235::real)*100,'90D0%') > > The output becomes 99.8% > > > > It would be nice to have this behavior explained in the documentation so > > people get more predictable results. > > +1 > > How about the following: I slightly mo

Re: group by can use alias from select list

2023-09-06 Thread Bruce Momjian
improvement if we really want the order of operations to be the main > reference entry point for people trying to work out query behavior.  Something > like:  "(while unadvised it is possible for the aliases defined in the next > step to be used here as well)". How is the attached p

Re: group by can use alias from select list

2023-09-07 Thread Bruce Momjian
On Wed, Sep 6, 2023 at 08:01:30PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 11, 2023 at 07:31:26AM -0700, David G. Johnston wrote: > >> I think the complaint is that someone seeing the behavior in the wild > >> comes to > >> this order-of

Re: pg_class.relpages documentation does not mention relpages corner case

2023-09-07 Thread Bruce Momjian
.postgresql.org/message-id/20230112232747.GA2111950@nathanxps13 If we set the relpages to zero, that would not be reflecting the partitions. I feel -1 is probably the best unless we want to put the total of all partitions in there, but that would be confusing too. -- Bruce Momjian

Re: Cross-Product JOIN?

2023-09-07 Thread Bruce Momjian
ften in the > > documentation > > overall. > > > > But the same page [0] also uses cross product when talking about grouping > > sets. > > > > [0] https://www.postgresql.org/docs/15/queries-table-expressions.html > > Here's a patch that fixes thos

Re: Incorrect/confusing information about timetz

2023-09-07 Thread Bruce Momjian
int32 zone; /* numeric time zone, in seconds */ } TimeTzADT; Do we want to document this? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Incorrect/confusing information about timetz

2023-09-07 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 04:41:48PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Uh, yes to the storage part, no to the output part. ;-) Postgres does > > store the timetz time zone offset, but it doesn't adust it once it is > > stored so doesn't a

Re: Remove obsolete mention of backslashes as escapes

2023-09-08 Thread Bruce Momjian
e the standard syntax for specifying string constants is usually > convenient, it can be difficult to understand when the desired string > - contains many single quotes or backslashes, since each of those must > + contains many single quotes, since each of those must >

Re: correct documentation in set role

2023-09-26 Thread Bruce Momjian
e must be a role that the current session user is a > member of "and has SET True option on it." > The second part missed in documentation for set role command. Good point. How is the attached patch? -- Bruce Momjian https://momjian.us EDB

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
- and since the catalog version is not accessible from SGML, it will usually not match the major version's catalog number. I would apply this only to Postgres 17 since it isn't really a fix. -- Bruce Momjian https://momjian.us EDB

Re: correct documentation in set role

2023-09-26 Thread Bruce Momjian
On Tue, Sep 26, 2023 at 11:44:42AM -0400, Bruce Momjian wrote: > On Mon, Sep 25, 2023 at 07:46:18AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/sql-set-role

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-09-26 Thread Bruce Momjian
On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > On Tue, Sep 26, 2023 at 10:35 AM Bruce Momjian wrote: > > On Mon, Sep 18, 2023 at 08:14:04PM +, PG Doc comments form wrote: > > The following documentation comment has been logged

Re: group by can use alias from select list

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 10:11:00AM -0400, Bruce Momjian wrote: > We do farther down the docs in the GROUP BY section: > > https://www.postgresql.org/docs/devel/sql-select.html > > GROUP BY will condense into a single row all selected rows that share > the s

Re: Incorrect/confusing information about timetz

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 05:00:59PM -0400, Bruce Momjian wrote: > On Thu, Sep 7, 2023 at 04:41:48PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Uh, yes to the storage part, no to the output part. ;-) Postgres does > > > store the timetz time zone offset, b

Re: Certificate authentication docs in multiple places

2023-09-27 Thread Bruce Momjian
to find it while thinking about > > authentication. > > > > Should we add a link from the former to the latter? > > Sure, some cross-linking between those two sections seems sensible. Attached is a patch which accomplishes this. -- Bruce Momjian https://momjian.us EDB

Re: Seeming contradiction in 22.1

2023-09-27 Thread Bruce Momjian
> That way it avoids the passive tense which leaves some ambiguity as to who or > what and when is naming this superuser. I think the paragraph was trying to do too much so I simplified it, patch attached. -- Bruce Momjian https://momjian.us EDB

Re: Make SSPI documentation clearer

2023-09-27 Thread Bruce Momjian
henticate to a server which > is using either SSPI or GSSAPI, and a GSSAPI client can authenticate to > a server which is using either SSPI or GSSAPI. Generally speaking, > clients and servers on Windows are recommended to use SSPI while clients > and servers on Unix (non-Windows

Re: Mistake in statement example

2023-09-27 Thread Bruce Momjian
example, I mentioned a "second" transaciton, I changed the account number so I can talk about the second statement, because read committed changes the row visibility of the non-first statements, and I changed "transaction" to "statement". -- Bruce Momjian

Re: MERGE examples not clear

2023-09-27 Thread Bruce Momjian
While here...source_alias (...completely hides...the fact that a query was > issued).  What?  Probably it should read (not verified) that it is actually > required when the source is a query (maybe tweaking the syntax to match). The attached patch removes the second example, which

Re: Suggestion for deprecated spellings

2023-09-27 Thread Bruce Momjian
On Mon, Jan 30, 2023 at 04:17:14PM -0500, Bruce Momjian wrote: > On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > On Thu, Jan 26, 2023 at 12:19:29PM +, PG Doc comments form wrote: > > >> From time to time some spelling f

Re: Make SSPI documentation clearer

2023-09-28 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 07:09:02PM -0400, Bruce Momjian wrote: > On Sun, Mar 12, 2023 at 08:36:53PM -0400, Stephen Frost wrote: > > > When the server is on a non-Windows platform then the server must use > > > GSSAPI > > > if it wants to authenticate the client eit

Re: The documentation for storage type 'plain' actually allows single byte header

2023-09-29 Thread Bruce Momjian
/sgml/storage.sgml > @@ -456,9 +456,7 @@ for storing TOAST-able columns on disk: > > >PLAIN prevents either compression or > - out-of-line storage; furthermore it disables use of single-byte headers > - for varlena ty

Re: Do we really want to mention 8.3 in current versions of the docs?

2023-09-29 Thread Bruce Momjian
> > The examples seem to be more or less fine,. Agreed. Removed in the attached applied patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/

Re: ODBC options

2023-10-06 Thread Bruce Momjian
lace or format where I can post that? > > Spreadsheet is here if anyone wants to look at it. > https://www.dropbox.com/scl/fi/v1uj1umtj20k1ljenodvy/ > psqlODBC-Configuration-Options.xlsx?rlkey=fit9kbgy0fv0fr9vt0u0a9oim&dl=0 Please see: https://odbc.postgresq

Re: Seeming contradiction in 22.1

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 06:11:44PM -0400, Bruce Momjian wrote: > On Thu, Mar 23, 2023 at 05:45:03PM +0100, maja zaloznik wrote: > > Thanks David, this is very helpful! > > > > I would have to agree with Tom, that while technically true, the text could > > be >

Re: Certificate authentication docs in multiple places

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 05:28:04PM -0400, Bruce Momjian wrote: > On Tue, Mar 28, 2023 at 04:28:24PM +0200, Peter Eisentraut wrote: > > On 23.03.23 14:33, Steve Atkins wrote: > > > A couple of times recently I’ve been chatting with someone about using > > > certificate a

Re: Suggestion for deprecated spellings

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 08:17:54PM -0400, Bruce Momjian wrote: > On Mon, Jan 30, 2023 at 04:17:14PM -0500, Bruce Momjian wrote: > > On Mon, Jan 30, 2023 at 04:07:46PM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Thu, Jan 26, 2023 at 12:19:29PM +00

Re: Make SSPI documentation clearer

2023-10-10 Thread Bruce Momjian
On Thu, Sep 28, 2023 at 09:55:43AM -0400, Bruce Momjian wrote: > On Wed, Sep 27, 2023 at 07:09:02PM -0400, Bruce Momjian wrote: > > On Sun, Mar 12, 2023 at 08:36:53PM -0400, Stephen Frost wrote: > > > > When the server is on a non-Windows platform then the server mus

Re: pg_upgrade doc uses inconsistent versions within the doc.

2023-10-10 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 09:42:49AM +0200, Daniel Gustafsson wrote: > > On 26 Sep 2023, at 22:26, Bruce Momjian wrote: > > On Tue, Sep 26, 2023 at 10:56:27AM -0700, David G. Johnston wrote: > > >> I would get rid of any mentions of our old pre-v10 versioning sc

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
havior of shared_preload_libraries, I have to use double-quotes inside single quotes: ALTER SYSTEM SET listen_addresses TO 'a, "b x", c'; .conf listen_addresses = 'a, "b x", c' Do we want to retain this difference in list processing? I hav

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch to document this. > > This seems a little imprecise: > > + Values with non-alphanumeric characters must be quoted. > > I think accurate is

Re: Getting started

2023-10-24 Thread Bruce Momjian
otstrap superuser. I looked at this and initdb is mentioned in the installation section, and an incorrect user name is mentions as part of craetedb failure. I don't see what we can add to improve things here. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: 19.9. Secure TCP/IP Connections with SSL

2023-10-26 Thread Bruce Momjian
. If the key you use is does not meet or exceed this > minimum length PostgreSQL will fail to start. It's common practice to > require a key of at least length 2048. I think this is based on the SSL/TLS library in use which is why we don't mention it in our docs, e.g.:

Re: First Person (I) Should be avoided

2023-10-27 Thread Bruce Momjian
> $ # I wonder what file 155173 is ... > > suggested change: > $ # what Postgres object does file 155173 represent ... Fixed with the attached, applied patch to master. -- Bruce Momjian https://momjian.us EDB https://enterprised

Re: [very minor] Documentation suggestion

2023-10-27 Thread Bruce Momjian
ser] catalog table. but it still needs help ;-) Here is the text I just applied: Note that these commands can cause deadlocks not only for the system catalog tables listed above but for other catalog tables. Attached is the applied patch to master. -- Bruce Momjian

Re: Minor inconsistencies

2023-10-27 Thread Bruce Momjian
iew. I liked all these improvements and applied a modified version of your patch to master, thanks. Sorry for the delay. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Typo in docs for "recovery_init_sync_method" parameter.

2023-10-27 Thread Bruce Momjian
ing system to synchronize whole file systems that > contain the data directory... I ended up with this rewording, attached, and applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
; exist in the template. > > cf: https://www.postgresql.org/docs/13/manage-ag-templatedbs.html I have created the attached patch to document this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 12:18:50PM -0400, Bruce Momjian wrote: > On Tue, Aug 9, 2022 at 08:33:11PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/14/manag

Re: Intro enhancement proposal

2023-10-28 Thread Bruce Momjian
Agreed. I adjusted some of the links and applied the attached patch to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/intro.sgml b/doc/src/sgml/intro.s

Re: "22.3. Template Databases" documentation is incomplete

2023-10-28 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Sorry, I attached a _colorized_ diff; here is a normal one. > > The new sentence is fine in isolation, but this doesn't feel like > a great spot to put it. The preceding several lines

Re: Usage instructions for pg_hba.conf file

2023-10-28 Thread Bruce Momjian
up... > Note: The preceding statement... > The system view pg_hba_file_rules can be helpful... This is a good point. I moved the reload sections for pg_hba.conf and pg_ident.conf up near the top of their sections in the attached patch. -- Bruce Momjian https://momjian.us EDB

Re: 'value' has special behaviour in alter system

2023-10-31 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:36:14PM -0400, Bruce Momjian wrote: > On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I have developed the attached patch to document this. > > > > This seems a little imprecise: > > >

Re: Typo in "43.9.1. Reporting Errors and Messages"?

2023-10-31 Thread Bruce Momjian
13:53:41 2019 +0900 Fix inconsistencies and typos in the tree, take 10 This addresses some issues with unnecessary code comments, fixes various typos in docs and comments, and removes some orphaned structures and definitions

Re: doc-fix-for-POSIX-Time-Zone-Specifications

2023-10-31 Thread Bruce Momjian
ent, please be kind to share your thought with me. I think "the" was missing, so I added it: As an example, CET-1CEST,M3.5.0,M10.5.0/3 describes the current (as of 2020) timekeeping practice in Paris. This specification --- -- Bruc

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-01 Thread Bruce Momjian
d objects > > for a parent role will not change the default privileges of > > objects created by inherited roles. > > +1. I cannot count the number of times I have seen people confused by that. > > Suggested patch attached. I see how people can be confused. I wrot

Re: Documentation of return values of range functions lower and upper

2023-11-01 Thread Bruce Momjian
- f SELECT upper_inf('[-infinity,-infinity]'::tstzrange); upper_inf --- f For upper/lower(), it is clear that the documentation is better saying "unspecified" rather than infinite. The fact that upper/lower_inf() returns

Re: Documentation of return values of range functions lower and upper

2023-11-01 Thread Bruce Momjian
used for unknown or undefined values. > > I think it would be better to say "returns NULL if the range is empty or > unbounded" > and "is the range unbounded on the upper end?". I had to go with "Is the multirange's lower bound unbounded?" because the

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
years old, but I am now looking at this email can can't see the problem: SET default_tablespace = 'pg_global'; CREATE TABLE test (x int); ERROR: only shared relations can be placed in pg_global tablespace Did you want an error from the SET command? -- Bru

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > "David G. Johnston" writes: > > On Wednesday, November 1, 2023, Bruce Momjian wrote: > >> Did you want an error from the SET command? > > > That would probably be a decent addition but the req

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-01 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > >> But it *is* permissible, unless we add code to reject it during > >> SET as Bruce mentioned. Which seems fairly

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 07:34:59PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 07:12:48PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Wed, Nov 1, 2023 at 06:32:37PM -0400, Tom Lane wrote: > > >> But it *is* permissible, unless we add code to

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 08:56:13AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 18:03 -0400, Bruce Momjian wrote: > > On Wed, Nov 1, 2023 at 09:40:43PM +0100, Laurenz Albe wrote: > > > > Yes, I agree this documentation needs help. > > > > > > >

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I found a cleaner improvement, attached. > > OK by me. Maybe that doesn't make the point strongly enough, > but we can hope it's enough. Agreed. I thought last night about the s

Re: Documentation of return values of range functions lower and upper

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > Better, though "Is the range's upper bound unbounded?" makes me cringe. > > > > Oh, yeah, totally cringe, me too.  :-) > > > &

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-02 Thread Bruce Momjian
On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > On Wed, 2023-11-01 at 13:09 -0400, Bruce Momjian wrote: > > On Thu, Feb 18, 2021 at 08:16:13AM +0100, Laurenz Albe wrote: > > > On Wed, 2021-02-17 at 15:08 -0500, Jordi Gutiérrez Hermoso wrote: > > > >

Re: Document target_role param of ALTER DEFAULT PRIVILEGES

2023-11-03 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 09:51:58PM -0400, Bruce Momjian wrote: > On Wed, Nov 1, 2023 at 09:31:52PM +0100, Laurenz Albe wrote: > > There is another patch in the current commitfest that addresses a similar > > problem, triggered by another complaint: > > https://commitfest.p

Re: Incorrect mention of number of columns?

2023-11-03 Thread Bruce Momjian
ugh to be useful. > > I am not speaking about a warning at creation time, but rather a warning in > the > docs. Something like: Although a table with e.g. 1600 bigint columns can be > created, creating a tuple of more than 8160 bytes will fail. It is in the "limits" docs:

Re: "22.3. Template Databases" documentation is incomplete

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 03:14:32PM -0400, Bruce Momjian wrote: > On Sat, Oct 28, 2023 at 02:42:06PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Sorry, I attached a _colorized_ diff; here is a normal one. > > > > The new sentence is fine in isolation, bu

Re: Usage instructions for pg_hba.conf file

2023-11-03 Thread Bruce Momjian
On Sat, Oct 28, 2023 at 04:04:47PM -0400, Bruce Momjian wrote: > On Tue, Aug 2, 2022 at 08:08:07PM +, PG Doc comments form wrote: > > 21.1.1 Loading or Reloading the Configuration > > The pg_hba.conf file is read on start-up... > > Note: The preceding statement...

Re: Required locks for ANALYZE

2023-11-08 Thread Bruce Momjian
t; > parallel with non-DDL activity on the table. I know this report is four years old, but attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: readability changes to postgres.sgml

2023-11-08 Thread Bruce Momjian
his patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: User mapping security

2023-11-09 Thread Bruce Momjian
know this is four years old, but the attached patch documents it. I don't think postgresql-fdw needs it since it relies on user mapping and discourages passwords in the connection string. -- Bruce Momjian https://momjian.us EDB https://e

Re: User mapping security

2023-11-09 Thread Bruce Momjian
On Thu, Nov 9, 2023 at 05:03:33PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 16, 2019 at 02:01:00AM +, PG Doc comments form wrote: > >> I suppose it should be warned on the pages that foreign credentials with be > >> stored as simple text and wi

Re: WAL Configuration Grammar Fix

2023-11-09 Thread Bruce Momjian
This patch is 4.5 years old, but still valid. Fixed with the attached patch applied to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/wal.sgml

Re: Typo in documentation - runtime-config-wal

2023-11-09 Thread Bruce Momjian
is this correction accurate? It seems so to me. After flushing WAL the writer sleeps for the length of time given by wal_writer_delay, unless woken up sooner --> by an asynchronously committing transaction. -- Bruce Momjian https://momjian.us EDB

Re: 'pg_global' cannot be used as default_tablespace.

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 11:08:53AM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 09:58:54AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I found a cleaner improvement, attached. > > > > OK by me. Maybe that doesn't make the point strong

Re: Documentation of return values of range functions lower and upper

2023-11-13 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 06:22:59PM -0400, Bruce Momjian wrote: > On Thu, Nov 2, 2023 at 03:42:53PM +0100, Laurenz Albe wrote: > > On Thu, 2023-11-02 at 10:14 -0400, Bruce Momjian wrote: > > > Better, though "Is the range's upper bound unbounded?" makes me cring

Re: Missing documentation for FETCH FIRST in chapter 7.6

2023-11-17 Thread Bruce Momjian
link to the LIMIT > section in the SELECT reference page. I also renamed the "number" > variables to the same names used in the SELECT reference page and put > OFFSET in a new line (it looks visually better). I applied the attached patch based on your p

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-17 Thread Bruce Momjian
x | x ---+--- SELECT * FROM test AS t1 JOIN test AS t2 ON (TRUE) FOR UPDATE OF t2; x | x ---+--- The attached patch documents this. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.co

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
(i.e., an unaliased table name or an alias in the sibling FROM > clause attached to this level of the query).  I like this better anyway on the > grounds that the thing being referenced can be a subquery or a view as well as > a table. Okay, how is the attached patch?

Re: SELECT ... FOR UPDATE OF clause documentation implies use of table_names rather than aliases

2023-11-20 Thread Bruce Momjian
;FOR UPDATE" so I missed that section; updated patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/selec

Re: Documentation of FOR ROLE clause of ALTER DEFAULT PRIVILEGES missing

2023-11-21 Thread Bruce Momjian
/sql-alterdefaultprivileges.html We felt the doc rewrite was too extensive to backpatch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
Support Enabled Value Vendor > write cacheyes yes > > I appreciate the Postgresql docs are not meant to be FreeBSD tutorials. I know this email is six years old, but I have applied this fix to all supported Postgres versions. A huge apology

Re: [DOCS] Confusing Trigger Docs.

2023-11-21 Thread Bruce Momjian
On Thu, Aug 31, 2017 at 09:22:22AM -0700, Peter Geoghegan wrote: > On Thu, Aug 31, 2017 at 6:25 AM, Bruce Momjian wrote: > > On Mon, Jul 3, 2017 at 08:07:10PM +, n...@fairwindsoft.com wrote: > >> The following documentation comment has been logged on the website: >

Re: [DOCS] The reference to 'atacontrol' on FreeBSD is outdated.

2023-11-21 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 03:25:07PM +1300, Thomas Munro wrote: > On Wed, Nov 22, 2023 at 2:12 PM Bruce Momjian wrote: > > On Sat, Aug 12, 2017 at 10:47:00PM +0100, John Ekins wrote: > > > Sure. Camcontrol does indeed cover IDE, SCSI and SAS drives. > > > > > >

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-11-21 Thread Bruce Momjian
t;> reserved words. > > Ouch. Shows you how old this module is :-( > > Indeed. > > >> I propose the attached patch to fix that. > > Um, the attached file seems empty from here. > > Ooops, sorry. It is attached. I like this six year old patch so would l

Re: [DOCS] Add example about date ISO format

2023-11-21 Thread Bruce Momjian
developed the attached patch I would like to apply to master. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml inde

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
gml around line 2552. > > +1 for moving it to section 8.5.2. Okay, I moved it into the "Note" section that talked about ISO 8601 output with "T", in the attached patch. I will apply this only to master since it is not a correction. -- Bruce Momjian

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
r Examples". I originally thought it belonged in section 9.8 too, but I think the value of this example is ISO 8601 and I don't see how we can cleanly mention that in table 9.31. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Bruce Momjian
ce those effects may have contributed to the row being excluded from insertion. I modified the attached patch to explain this since it is not really the same as modifying the actual row. Does that add any value? If not, let's remove it. -- Bruce Momjian https://mo

Re: [DOCS] Double negation in parameter description

2023-11-22 Thread Bruce Momjian
: > > "This option may only be used on a populated materialized view."? > > Your clarification is much appreciated. I know this is six years old, but fixed in master with the attached patch. -- Bruce Momjian https://momjian.us EDB

Re: [DOCS] Add example about date ISO format

2023-11-24 Thread Bruce Momjian
On Thu, Nov 23, 2023 at 09:29:39AM +0100, Laurenz Albe wrote: > On Wed, 2023-11-22 at 11:58 -0500, Bruce Momjian wrote: > > Okay, I moved it into the "Note" section that talked about ISO 8601 > > output with "T", in the attached patch. > > Fine by me, exc

Re: [DOCS] Confusing Trigger Docs.

2023-11-24 Thread Bruce Momjian
tgreSQL knowledge, like me. I moved the parition pagagraph to a more logical location and tried to clarify the new paragraph to be more targeted on the goal, patch attached. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only

  1   2   3   4   5   6   7   8   >