Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-17 Thread Fujii Masao
Hi, Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on indexes are not copied either. However, the CREATE FOREIGN TABLE docs incorrectly states that index comments are copied when using INCLUDING COMME

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-17 Thread Michael Paquier
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: > Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. > In this feature, since indexes are not created for foreign tables, > comments on indexes are not copied either. Good point. This doc fix sounds fine to me. -- Michae

Re: Clarify VACUUM FULL exclusion in total_vacuum_time docs

2025-06-17 Thread Fujii Masao
On 2025/06/13 21:09, Robert Treat wrote: Well, I admit I mostly mentioned it because when I noticed this one wasn't documented the same way the other ones were, I second-guessed myself about if I knew how it really behaved and did a quick test to confirm :-) I suspect others might have similar

Reorder min/max_protocol_version descriptions in libpq documentation

2025-06-17 Thread Fujii Masao
Hi, Commit 285613c60a7 added the min_protocol_version and max_protocol_version connection options to libpq. However, their descriptions currently appear in the middle of the unrelated ssl_min_protocol_version and ssl_max_protocol_version entries in libpq.sgml. Is there a reason for this placement

Re: Reorder min/max_protocol_version descriptions in libpq documentation

2025-06-17 Thread Jelte Fennema-Nio
On Tue, 17 Jun 2025 at 18:32, Fujii Masao wrote: > > Hi, > > Commit 285613c60a7 added the min_protocol_version and max_protocol_version > connection options to libpq. However, their descriptions currently appear > in the middle of the unrelated ssl_min_protocol_version and > ssl_max_protocol_versi

Re: Reorder min/max_protocol_version descriptions in libpq documentation

2025-06-17 Thread Fujii Masao
On 2025/06/18 1:34, Jelte Fennema-Nio wrote: On Tue, 17 Jun 2025 at 18:32, Fujii Masao wrote: Hi, Commit 285613c60a7 added the min_protocol_version and max_protocol_version connection options to libpq. However, their descriptions currently appear in the middle of the unrelated ssl_min_prot

Re: Clarify VACUUM FULL exclusion in total_vacuum_time docs

2025-06-17 Thread Robert Treat
On Tue, Jun 17, 2025 at 10:54 AM Fujii Masao wrote: > On 2025/06/13 21:09, Robert Treat wrote: > > Well, I admit I mostly mentioned it because when I noticed this one > > wasn't documented the same way the other ones were, I second-guessed > > myself about if I knew how it really behaved and did a