Potential vuln in example for "F.25.1.1. digest()"

2021-08-17 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/pgcrypto.html Description: Hi, in "F.25.1.1. digest()" you suggest: CREATE OR REPLACE FUNCTION sha1(bytea) returns text AS $$ SELECT encode(digest($1, 'sha1'), 'hex') $$ LANGUAGE SQL

Re: Potential vuln in example for "F.25.1.1. digest()"

2021-08-17 Thread David G. Johnston
On Tuesday, August 17, 2021, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/pgcrypto.html > Description: > > Hi, > in "F.25.1.1. digest()" you suggest: > > CREATE OR REPLACE FUNCTION sha1(bytea) return

Re: Potential vuln in example for "F.25.1.1. digest()"

2021-08-17 Thread Tom Lane
"David G. Johnston" writes: > On Tuesday, August 17, 2021, PG Doc comments form > wrote: >> in "F.25.1.1. digest()" you suggest: >> >> CREATE OR REPLACE FUNCTION sha1(bytea) returns text AS $$ >> SELECT encode(digest($1, 'sha1'), 'hex') >> $$ LANGUAGE SQL STRICT IMMUTABLE; >> >> While this is a

Unclear\mistakable description of UPDATE behaviour in "13.2.1. Read Committed Isolation Level"

2021-08-17 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/transaction-iso.html Description: hello! documentation for "read committed" says that: "UPDATE, DELETE, SELECT FOR UPDATE, and SELECT FOR SHARE commands ... ...If the first updater commi

Re: Unclear\mistakable description of UPDATE behaviour in "13.2.1. Read Committed Isolation Level"

2021-08-17 Thread David G. Johnston
On Tue, Aug 17, 2021 at 3:56 PM PG Doc comments form wrote: > > "UPDATE, DELETE, SELECT FOR UPDATE, and SELECT FOR SHARE commands ... > ...If the first updater commits, the second updater will ignore the row if > the first updater deleted it, otherwise it will attempt to apply its > operation to

Re: Unclear\mistakable description of UPDATE behaviour in "13.2.1. Read Committed Isolation Level"

2021-08-17 Thread David G. Johnston
On Tue, Aug 17, 2021 at 4:17 PM radiodiversion wrote: > I still think it would be great if this doc point was worded a little > differently in new editions. > > Suggestions are welcome. Without some idea of why you seemed to miss the two seemingly obvious references that I pointed out (including