Re: some grammar fixes for docs

2019-05-19 Thread Michael Paquier
On Fri, May 17, 2019 at 09:22:09AM +0900, Michael Paquier wrote: > Thanks for the inputs, Tom and Jonathan. I see the difference now. And committed down to 9.4 where relevant parts apply. -- Michael signature.asc Description: PGP signature

Re: some grammar fixes for docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 07:55:57PM -0400, Tom Lane wrote: > This distinction is widely ignored in casual speech or writing, but > it's still recognized in formal writing. I think our manual is > formal enough that we should try to get it right. Thanks for the inputs, Tom and Jonathan. I see the

Re: some grammar fixes for docs

2019-05-16 Thread Tom Lane
Michael Paquier writes: > On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: >> -Transaction which last more than limit >> milliseconds >> +Transactions that last more than limit >> milliseconds > I don't see much of a difference between "which" or "that" in this

Re: some grammar fixes for docs

2019-05-16 Thread Jonathan S. Katz
On 5/16/19 7:32 PM, Michael Paquier wrote: > On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: >> I have noticed imperfect grammar in a couple of sgml files, please consider >> a small patch (attached). > > Thanks, Liudmila for caring about such matters. > >> >> -

Re: some grammar fixes for docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: > I have noticed imperfect grammar in a couple of sgml files, please consider > a small patch (attached). Thanks, Liudmila for caring about such matters. > > -Transaction which last more than limit > milliseconds

some grammar fixes for docs

2019-05-16 Thread Liudmila Mantrova
Hi, I have noticed imperfect grammar in a couple of sgml files, please consider a small patch (attached). -- Liudmila Mantrova Technical writer at Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgben