Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-27 Thread Peter Smith
It seems this was pushed already [1]. Sorry for the false alarm. -- [1] https://github.com/postgres/postgres/commit/f5c446e3367527f9db1506d7c38d2f56e20950b6 Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-26 Thread Laurenz Albe
On Thu, 2023-07-27 at 12:16 +1000, Peter Smith wrote: > I created patches for this over a month ago, but then the thread went > quiet. Is there something more needed, or was it just accidentally > overlooked? > > Should this be added to the commitfest? Yes, please add it to the commitfest. That

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-07-26 Thread Peter Smith
I created patches for this over a month ago, but then the thread went quiet. Is there something more needed, or was it just accidentally overlooked? Should this be added to the commitfest? -- Kind Regards, Peter Smith. Fujitsu Australia.

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-20 Thread Peter Smith
Hi. I have made a patch v2. This addresses the following: - [1] Vignesh's review comment about unclosed SGML literal tag. - [2] Euler's review comment about the word "replica" But I did not address Euler's other review suggestion [2] about giving direct links, because actually this patch text (w

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-08 Thread Euler Taveira
On Thu, Jun 8, 2023, at 3:36 AM, Amit Kapila wrote: > I agree that it is a good idea to be explicit about this behavior. As > mentioned by you, it would be better to backpatch this. Also, I > thought about moving this to some other section like [1] but I think > we need to explain a bit about apply

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-07 Thread Amit Kapila
On Wed, Jun 7, 2023 at 4:09 PM vignesh C wrote: > > On Wed, 7 Jun 2023 at 10:17, Jonathan S. Katz wrote: > > > > Hi, > > > > While answering a question on "do triggers fire on a logical replication > > subscriber by default?" I tried to look up a reference to this behavior > > in the docs. There

Re: clarifying trigger/rule behavior on logical replication subscribers

2023-06-07 Thread vignesh C
On Wed, 7 Jun 2023 at 10:17, Jonathan S. Katz wrote: > > Hi, > > While answering a question on "do triggers fire on a logical replication > subscriber by default?" I tried to look up a reference to this behavior > in the docs. There wasn't a clear reference point, but on the > architecture page[1]

clarifying trigger/rule behavior on logical replication subscribers

2023-06-06 Thread Jonathan S. Katz
Hi, While answering a question on "do triggers fire on a logical replication subscriber by default?" I tried to look up a reference to this behavior in the docs. There wasn't a clear reference point, but on the architecture page[1], I found this line that was closest to the answer: "The appl