Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-31 Thread Laurenz Albe
On Wed, 2024-01-31 at 12:11 +0100, Peter Eisentraut wrote: > Sprinkled in some of David's suggestions, and pushed. Thanks; your text is great. Yours, Laurenz Albe

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-31 Thread Peter Eisentraut
On 18.01.24 22:21, David G. Johnston wrote: I started looking at this specific item and immediately got the idea to actually document in user-facing (i.e., not system catalogs) what these object categories are in which object types share the schema namespace. The "Other Object Types" section al

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-31 Thread Peter Eisentraut
On 26.01.24 16:52, Laurenz Albe wrote: On Fri, 2024-01-26 at 19:01 +0530, vignesh C wrote: CFBot shows that the patch does not apply anymore as in [1]: There was a conflict with 46a0cd4cefb. Updated version attached. Sprinkled in some of David's suggestions, and pushed. I was hesitant to bu

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-26 Thread Laurenz Albe
On Fri, 2024-01-26 at 19:01 +0530, vignesh C wrote: > CFBot shows that the patch does not apply anymore as in [1]: There was a conflict with 46a0cd4cefb. Updated version attached. Yours, Laurenz Albe From 193d6d6c20f0c2976e0b63f1896978545def3fe8 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date:

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-26 Thread David G. Johnston
On Fri, Jan 19, 2024 at 3:46 AM Laurenz Albe wrote: > In the attached patch, I have copied the enumeration of relations from > the CREATE INDEX page. I think this small redundance is alright, but I > wouldn't mind if this gets removed from CREATE INDEX. > > Tweaking the main paragraph a little.

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-26 Thread vignesh C
On Fri, 19 Jan 2024 at 16:16, Laurenz Albe wrote: > > On Thu, 2024-01-18 at 15:54 +0100, Peter Eisentraut wrote: > > On 27.11.23 03:30, Laurenz Albe wrote: > > > True; I don't find it documented that all objects in pg_class share a > > > namespace and that constraints are implemented by indexes of

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-19 Thread Laurenz Albe
On Thu, 2024-01-18 at 15:54 +0100, Peter Eisentraut wrote: > On 27.11.23 03:30, Laurenz Albe wrote: > > True; I don't find it documented that all objects in pg_class share a > > namespace and that constraints are implemented by indexes of the same > > name. But I think that the first part is a pro

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-18 Thread David G. Johnston
On Thu, Jan 18, 2024 at 7:54 AM Peter Eisentraut wrote: > > I find the specific change > proposal for ddl.sgml a bit weird, though, because this is a very > introductory section, and you are referring people to pg_class (what is > that?!?) for details. If we want to put something there, it shoul

Re: create table explicitly mention that unique|primary key constraint will create an

2024-01-18 Thread Peter Eisentraut
On 27.11.23 03:30, Laurenz Albe wrote: True; I don't find it documented that all objects in pg_class share a namespace and that constraints are implemented by indexes of the same name. But I think that the first part is a property of schemas and had better be documented there. It is documented

Re: create table explicitly mention that unique|primary key constraint will create an

2023-11-26 Thread jian he
On Mon, Nov 27, 2023 at 10:30 AM Laurenz Albe wrote: > > What do you think of the attached patch? > > Yours, > Laurenz Albe looks good to me.

Re: create table explicitly mention that unique|primary key constraint will create an

2023-11-26 Thread Laurenz Albe
On Mon, 2023-11-27 at 08:00 +0800, jian he wrote: > Hi. minor doc issue. > create table s1(a int, constraint s2 PRIMARY key (a)); > create table s2(a int); > ERROR: relation "s2" already exists > > https://www.postgresql.org/docs/current/sql-createtable.html#SQL-CREATETABLE-PARMS-UNIQUE > maybe f