Re: SET ROLE documentation not entirely correct

2019-08-01 Thread Joe Conway
On 4/27/19 4:02 PM, Joe Conway wrote: > On 4/25/19 11:25 AM, Steven Winfield wrote: >> Again, that's much clearer than what is currently there. It might help >> if some of the language/definitions from pg_has_role() is used, though. >> >> For example: >> A role X is a "MEMBER" of another role Y if

RE: SET ROLE documentation not entirely correct

2019-05-01 Thread Steven Winfield
> I've been whacking this around for the better part of the afternoon and > came up with the attached. I think it is correct, and better than my > previous proposal, but possibly need more polish. Comments welcome. FWIW it looks good to me! Steve. This email is confidential. If you are not the

Re: SET ROLE documentation not entirely correct

2019-04-27 Thread Joe Conway
On 4/25/19 11:25 AM, Steven Winfield wrote: > Again, that's much clearer than what is currently there. It might help > if some of the language/definitions from pg_has_role() is used, though. > > For example: > A role X is a "MEMBER" of another role Y if there is a chain of GRANTs > from X to Y via

Re: SET ROLE documentation not entirely correct

2019-04-27 Thread Joe Conway
On 4/25/19 5:58 PM, Jonathan S. Katz wrote: > Good news - I did test against an older snapshot. With a newer snapshot, > the SVG on the GIN implementation page[1] is responsive but not the one > on the storage page layout[2], which is what the proposed fix in the > other thread handles. > [2] http

Re: SET ROLE documentation not entirely correct

2019-04-27 Thread Joe Conway
On 4/26/19 3:14 PM, Jonathan S. Katz wrote: > On 4/26/19 3:04 PM, Jonathan S. Katz wrote: >> On 4/25/19 6:54 PM, Joe Conway wrote: >>> On 4/25/19 5:59 PM, Jonathan S. Katz wrote: On 4/25/19 5:26 PM, Joe Conway wrote: > > Is there any written instruction anywhere with guidance on how th

Re: SET ROLE documentation not entirely correct

2019-04-26 Thread Jonathan S. Katz
On 4/26/19 3:04 PM, Jonathan S. Katz wrote: > On 4/25/19 6:54 PM, Joe Conway wrote: >> On 4/25/19 5:59 PM, Jonathan S. Katz wrote: >>> On 4/25/19 5:26 PM, Joe Conway wrote: Is there any written instruction anywhere with guidance on how the SVGs should be made? >>> >>> https://git.pos

Re: SET ROLE documentation not entirely correct

2019-04-26 Thread Jonathan S. Katz
On 4/25/19 6:54 PM, Joe Conway wrote: > On 4/25/19 5:59 PM, Jonathan S. Katz wrote: >> On 4/25/19 5:26 PM, Joe Conway wrote: >>> >>> Is there any written instruction anywhere with guidance on how the SVGs >>> should be made? >> >> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 5:59 PM, Jonathan S. Katz wrote: > On 4/25/19 5:26 PM, Joe Conway wrote: >> >> Is there any written instruction anywhere with guidance on how the SVGs >> should be made? > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/images/README; Awesome -- that is what

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Jonathan S. Katz
On 4/25/19 5:26 PM, Joe Conway wrote: > > Is there any written instruction anywhere with guidance on how the SVGs > should be made? https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/images/README; but I would suggest we had some guidance on how to ensure the image stays sc

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Jonathan S. Katz
On 4/25/19 5:22 PM, Jonathan S. Katz wrote: > On 4/25/19 4:52 PM, Jonathan S. Katz wrote: >> On 4/25/19 3:20 PM, Joe Conway wrote: >>> On 4/25/19 3:06 PM, Stephen Frost wrote: Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Joe Conway writes: >> On 4/25/19 1:08 PM, Joe C

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 5:22 PM, Jonathan S. Katz wrote: > On 4/25/19 4:52 PM, Jonathan S. Katz wrote: >> On 4/25/19 3:20 PM, Joe Conway wrote: >>> On 4/25/19 3:06 PM, Stephen Frost wrote: Yeah, I'm seeing it cut off in Chrome too, initially, and then it seems to fix itself if I resize the window down

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Jonathan S. Katz
On 4/25/19 4:52 PM, Jonathan S. Katz wrote: > On 4/25/19 3:20 PM, Joe Conway wrote: >> On 4/25/19 3:06 PM, Stephen Frost wrote: >>> Greetings, >>> >>> * Tom Lane (t...@sss.pgh.pa.us) wrote: Joe Conway writes: > On 4/25/19 1:08 PM, Joe Conway wrote: >> There is one image which can be u

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Jonathan S. Katz
On 4/25/19 3:20 PM, Joe Conway wrote: > On 4/25/19 3:06 PM, Stephen Frost wrote: >> Greetings, >> >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>> Joe Conway writes: On 4/25/19 1:08 PM, Joe Conway wrote: > There is one image which can be used as an example though: > https://git.postgresq

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 3:06 PM, Stephen Frost wrote: > Greetings, > > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Joe Conway writes: >> > On 4/25/19 1:08 PM, Joe Conway wrote: >> >> There is one image which can be used as an example though: >> >> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Joe Conway writes: > > On 4/25/19 1:08 PM, Joe Conway wrote: > >> There is one image which can be used as an example though: > >> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD > > > Here is a mor

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Tom Lane
Joe Conway writes: > On 4/25/19 1:08 PM, Joe Conway wrote: >> There is one image which can be used as an example though: >> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD > Here is a more precise URL: > https://git.postgresql.org/gitweb/?p=postgresq

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 1:08 PM, Joe Conway wrote: > There is one image which can be used as an example though: > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD Here is a more precise URL: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/s

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 12:39 PM, Steven Winfield wrote: >> We *just* very recently added the ability to add images. Not sure I want >> to attempt creating one for this, but perhaps after I write the patch >> you could give it a go with an image to match your thoughts? > > That's great. Is there a page somewhe

RE: SET ROLE documentation not entirely correct

2019-04-25 Thread Steven Winfield
> All good stuff. I will try to take this into account and submit an > actual proposed patch -- hopefully over this weekend. Thanks. > We *just* very recently added the ability to add images. Not sure I want > to attempt creating one for this, but perhaps after I write the patch > you could give

Re: SET ROLE documentation not entirely correct

2019-04-25 Thread Joe Conway
On 4/25/19 11:25 AM, Steven Winfield wrote: >> Additionally s/INHERITS/INHERIT/ > > Good spot. > >> The wording should be something like >> >> 8<--- >> The specified role_name must be a role that the current session user is >> a member of directly or indirectly. >> 8<--- > > That

RE: SET ROLE documentation not entirely correct

2019-04-25 Thread Steven Winfield
> Additionally s/INHERITS/INHERIT/ Good spot. > The wording should be something like > > 8<--- > The specified role_name must be a role that the current session user is > a member of directly or indirectly. > 8<--- That’s certainly much better (perhaps with a comma after “of”, i

Re: SET ROLE documentation not entirely correct

2019-04-24 Thread Joe Conway
On 4/23/19 11:52 AM, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/sql-set-role.html > Description: > > In the course of trying to sanitise our roles and permissions I found the > notes in the SET ROL