Re: ALTER INDEX documentation is incomplete

2024-10-19 Thread Tom Lane
=?utf-8?Q?=C3=81lvaro?= Herrera writes: > How about the attached patch? Instead of + Causes the possibly schema-qualified named index to become attached I think something like + Causes the named index (possibly schema-qualified) to become attached would be more readable and closer t

Re: ALTER INDEX documentation is incomplete

2024-10-19 Thread Álvaro Herrera
Hello Alvaro, On 2024-Oct-18, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/17/sql-alterindex.html > Description: > > I am trying to find out whether the syntax `ALTER INDEX name ATTACH > PARTITION ind

Re: ALTER TABLE atomicity with sub-commands

2024-04-02 Thread Erik Wienhold
On 2024-04-02 16:40 +0200, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-altertable.html > Description: > > It is not entirely clear (to me) that ALTER TABLE statements with > comma-separated sub-

Re: ALTER TABLE "table" ALTER COLUMN "id" SET RESTART WITH nnn raises error

2023-08-20 Thread David G. Johnston
On Sun, Aug 20, 2023 at 8:56 AM PG Doc comments form wrote: > When the folloing SQL is executed: > ALTER TABLE "table" ALTER COLUMN "id" SET RESTART WITH nnn raises error > then an error is returned: > Yes, because if you take the RESTART branch in the syntax there is no word SET preceding RESTA

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-11-26 Thread Alvaro Herrera
On 2021-Oct-26, nikolai.berkoff wrote: > Thank you, this reads better. > Is there a reason in the docs there is sometimes > > ANALYZE > > and sometimes only > > ANALYZE > ? I prefer the link if there is no hard rule. I pushed this on November 5th; it is commit df80f9da5c6541e744eeb20eac

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-26 Thread nikolai.berkoff
‐‐‐ Original Message ‐‐‐ On Tuesday, October 19th, 2021 at 16:16, Alvaro Herrera wrote: > I would put it in a separate one instead, as in the attached. Thank you, this reads better. Is there a reason in the docs there is sometimes ANALYZE and sometimes only ANALYZE ? I prefer

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-22 Thread Euler Taveira
On Tue, Oct 19, 2021, at 12:16 PM, Alvaro Herrera wrote: > On 2021-Oct-19, Michael Paquier wrote: > > > On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote: > > > I agree that it might surprise an user and it would be good to document > > > it. > > > However, it does not belong to the d

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-19 Thread Michael Paquier
On Tue, Oct 19, 2021 at 12:16:44PM -0300, Alvaro Herrera wrote: > Dunno, putting it in the middle of the existing paragraph looks odd to > me. I would put it in a separate one instead, as in the attached. Fine by me. Thanks! -- Michael signature.asc Description: PGP signature

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-19 Thread Alvaro Herrera
On 2021-Oct-19, Michael Paquier wrote: > On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote: > > I agree that it might surprise an user and it would be good to document it. > > However, it does not belong to the description. I would add it to the Notes > > section at the end of the ALTE

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-18 Thread Michael Paquier
On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote: > I agree that it might surprise an user and it would be good to document it. > However, it does not belong to the description. I would add it to the Notes > section at the end of the ALTER TABLE page. No objections to the suggested ad

Re: ALTER TABLE ... SET DATA TYPE removes statistics

2021-10-18 Thread Euler Taveira
On Fri, Oct 8, 2021, at 6:03 AM, nikolai.berkoff wrote: > The current documentation does not mention that the column statistics are > removed which I can see they are in src/backend/commands/tablecmds.c > > ATExecAlterColumnType > /* > * Drop any pg_statistic entry for the column, since it's now

Re: Alter sequence restart parameter type

2021-04-26 Thread David G. Johnston
On Sunday, April 25, 2021, PG Doc comments form wrote: > > I use postgresql 12.6. I want to restart my sequence something like that: > alter sequence quiz_seq restart with ((select max(id) from quiz)+1); > but I can't do it. Please, clarify. Can I use only plain numbers like > that? alter seque

Re: ALTER SYSTEM between upgrades

2020-08-31 Thread Bruce Momjian
On Wed, Aug 26, 2020 at 12:22:25AM +0200, Daniel Gustafsson wrote: > >> One can argue whether those bulletpoints are sufficient for stressing the > >> importance, but it's at least mentioned. There is however no mention of > >> postgresql.auto.conf which clearly isn't helping anyone, so we should

Re: ALTER SYSTEM between upgrades

2020-08-25 Thread Daniel Gustafsson
> On 25 Aug 2020, at 21:30, Bruce Momjian wrote: > > On Tue, Jul 14, 2020 at 12:52:23PM +0200, Daniel Gustafsson wrote: On 14 Jul 2020, at 01:58, Bruce Momjian wrote: >>> >>> I am creating a new thread to discuss the question raised by Alvaro of >>> how many ALTER SYSTEM settings are lost

Re: ALTER SYSTEM between upgrades

2020-08-25 Thread Bruce Momjian
On Tue, Jul 14, 2020 at 12:52:23PM +0200, Daniel Gustafsson wrote: > > On 14 Jul 2020, at 01:58, Bruce Momjian wrote: > > > I am creating a new thread to discuss the question raised by Alvaro of > > how many ALTER SYSTEM settings are lost during major upgrades. Do we > > properly document that u

Re: ALTER SYSTEM between upgrades

2020-07-14 Thread Daniel Gustafsson
> On 14 Jul 2020, at 01:58, Bruce Momjian wrote: > I am creating a new thread to discuss the question raised by Alvaro of > how many ALTER SYSTEM settings are lost during major upgrades. Do we > properly document that users should migrate their postgresql.conf _and_ > postgresql.auto.conf files

Re: ALTER TABLE syntax incomplete

2020-03-04 Thread Michael Paquier
On Fri, Feb 28, 2020 at 04:26:57PM +, PG Doc comments form wrote: > I believe the documentation page > https://www.postgresql.org/docs/11/sql-altertable.html is missing the action > ADD CONSTRAINT, as it is mentioned in the descriptions of other keywords. The documentation includes this descri

Re: ALTER SERVER SYNTAX ISSUE

2018-10-31 Thread Tom Lane
=?utf-8?q?PG_Doc_comments_form?= writes: > I found that the alter server statement below does not work: > ALTER SERVER foo OPTIONS (host 'foo', dbname 'foodb'); > but this does: > ALTER SERVER foo OPTIONS (set host 'foo', set dbname 'foodb'); Hm, define "does not work". Those aren't equivalent:

Re: ALTER

2018-05-02 Thread David G. Johnston
On Wednesday, May 2, 2018, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/tutorial-sql.html > Description: > > where is ALTER? > Command reference. Part VI, Chapter I https://www.postgresql.