Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Pavlo Golub
Greetings, Michael. You wrote 23.01.2019, 8:14: > On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote: >> Michael Paquier writes: >>> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we >>> could put a description close to default_transaction_read_only in >>> config.sgml,

Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Michael Paquier
On Wed, Jan 23, 2019 at 01:07:31AM -0500, Tom Lane wrote: > Michael Paquier writes: >> transaction_read_only is listed in src/backend/utils/misc/guc.c, so we >> could put a description close to default_transaction_read_only in >> config.sgml, except that transaction_read_only sets the current >> t

Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Tom Lane
Michael Paquier writes: > transaction_read_only is listed in src/backend/utils/misc/guc.c, so we > could put a description close to default_transaction_read_only in > config.sgml, except that transaction_read_only sets the current > transaction's read-only status. Do we really want to document th

Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Michael Paquier
On Wed, Jan 23, 2019 at 06:18:58AM +0200, Pavlo Golub wrote: > Yeah, why not. Could you please give me a hint where can I find > details about it? Sources or commits? (You may want to avoid HTML..) transaction_read_only is listed in src/backend/utils/misc/guc.c, so we could put a description clos

Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Pavlo Golub
On Jan 23, 2019 02:25, Michael Paquier wrote:On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote: > I found that `transaction_read_only`GUC is undocumented. The only > place where it referenced is Hot Standby section > (https://www.postgresql.org/docs/current/hot-standby.html) > > C

Re: `transaction_read_only` GUC undocumented

2019-01-22 Thread Michael Paquier
On Tue, Jan 22, 2019 at 01:26:40PM +0100, Pavlo Golub wrote: > I found that `transaction_read_only`GUC is undocumented. The only > place where it referenced is Hot Standby section > (https://www.postgresql.org/docs/current/hot-standby.html) > > Can we add description for this GUC, please? That m