Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Michael Paquier
On Wed, Jun 18, 2025 at 04:55:56PM +0900, Fujii Masao wrote: > Thanks for the review! I will commit the patch barring any other objections. Thanks. -- Michael signature.asc Description: PGP signature

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Fujii Masao
On 2025/06/18 16:55, Fujii Masao wrote: On 2025/06/18 15:50, Michael Paquier wrote: On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Fujii Masao
On 2025/06/18 15:50, Michael Paquier wrote: On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on indexes are not copied either. Good poin

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-17 Thread Michael Paquier
On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: > Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. > In this feature, since indexes are not created for foreign tables, > comments on indexes are not copied either. Good point. This doc fix sounds fine to me. -- Michae

Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-17 Thread Fujii Masao
Hi, Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on indexes are not copied either. However, the CREATE FOREIGN TABLE docs incorrectly states that index comments are copied when using INCLUDING COMME