Re: Clarify how triggers relate to transactions

2021-09-01 Thread Tom Lane
Laurenz Albe writes: > On Fri, 2021-07-30 at 16:20 -0400, Tom Lane wrote: >> I think it'd work out best to make this a separate para after the >> one that defines before/after/instead-of triggers. How do you >> like the attached? > That is better, and I like your patch. Thanks! > Keeping paragr

Re: Clarify how triggers relate to transactions

2021-08-18 Thread Laurenz Albe
On Fri, 2021-07-30 at 16:20 -0400, Tom Lane wrote: > Laurenz Albe writes: > > On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: > > > On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > > > > If I understand correctly, it would be helpful to add this sentence or a > > > > correct

Re: Clarify how triggers relate to transactions

2021-07-30 Thread Tom Lane
Laurenz Albe writes: > On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: >> On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: >>> If I understand correctly, it would be helpful to add this sentence or a >>> corrected version of it: "Triggers always execute in the same transaction

Re: Clarify how triggers relate to transactions

2021-05-05 Thread Laurenz Albe
On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: > On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > > https://www.postgresql.org/docs/current/sql-createtrigger.html mentions the > > word "transaction" only once, in reference specifically to constraint > > triggers: "They can b

Re: Clarify how triggers relate to transactions

2021-05-02 Thread Euler Taveira
On Wed, Apr 28, 2021, at 2:18 PM, Nathan Long wrote: > Gotcha. Where would I go to make the PR? > There is no such PR feature; we don't use GitHub despite of having a mirror there. As Laurenz said you should create a patch (using your preferred git command) and attach to this thread. If you prefer

Re: Clarify how triggers relate to transactions

2021-04-28 Thread Nathan Long
Gotcha. Where would I go to make the PR? On Wed, Apr 28, 2021, 7:24 AM Laurenz Albe wrote: > On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/13/sql-createtrigger.h

Re: Clarify how triggers relate to transactions

2021-04-28 Thread Laurenz Albe
On Wed, 2021-04-28 at 13:18 -0400, Nathan Long wrote: > Gotcha. Where would I go to make the PR? You'd create a patch against Git master and send it to this mailing list or pgsql-hackers. If you don't want it to fall between the cracks, register in the next commitfest where it can undergo peer re

Re: Clarify how triggers relate to transactions

2021-04-28 Thread Laurenz Albe
On Tue, 2021-04-27 at 14:26 +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/13/sql-createtrigger.html > Description: > > https://www.postgresql.org/docs/current/sql-createtrigger.html mentions the >

Clarify how triggers relate to transactions

2021-04-28 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/sql-createtrigger.html Description: https://www.postgresql.org/docs/current/sql-createtrigger.html mentions the word "transaction" only once, in reference specifically to constraint trigge