Re: CREATE/ALTER ROLE with NULL password

2018-11-22 Thread Michael Paquier
On Thu, Nov 22, 2018 at 09:54:07AM -0700, David G. Johnston wrote: > On Thursday, November 22, 2018, Michael Paquier wrote: >> The docs list the following with the patch as supported grammar: >> [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL >> And it seems to me that '|' has priority over '[]'

Re: CREATE/ALTER ROLE with NULL password

2018-11-22 Thread David G. Johnston
On Thursday, November 22, 2018, Michael Paquier wrote: > On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote: > > Should tweak the paragraph to point out this exception as well. > > > > The ENCRYPTED keyword has no effect, but is accepted for backwards > > compatibility[, except in

Re: CREATE/ALTER ROLE with NULL password

2018-11-21 Thread Michael Paquier
On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote: > Should tweak the paragraph to point out this exception as well. > > The ENCRYPTED keyword has no effect, but is accepted for backwards > compatibility[, except in the PASSWORD NULL form.] The docs list the following with the pa

Re: CREATE/ALTER ROLE with NULL password

2018-11-21 Thread David G. Johnston
On Wednesday, November 21, 2018, Michael Paquier wrote: > Yes, that the set of grammar combination supported, as ENCRYPTED > PASSWORD NULL is not possible. > > Any objections with > the attached set of fixes from anybody? > Should tweak the paragraph to point out this exception as well. The EN

Re: CREATE/ALTER ROLE with NULL password

2018-11-21 Thread Michael Paquier
On Wed, Nov 21, 2018 at 07:36:59PM +, PG Doc comments form wrote: > The current synopsis for CREATE / ALTER ROLE give one of the allowed options > as: > [ ENCRYPTED ] PASSWORD 'password' > and the current documentation for CREATE ROLE says: > "The ENCRYPTED keyword has no effect, but is accepte

CREATE/ALTER ROLE with NULL password

2018-11-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/sql-alterrole.html Description: When creating a role with no password, or altering a role to remove its password, the ENCRYPTED clause must not be present. The current synopsis for CREATE