Re: Missing comma?

2020-05-20 Thread Marina Polyakova
On 2020-05-20 08:26, Michael Paquier wrote: On Tue, May 19, 2020 at 11:14:56AM +0300, Marina Polyakova wrote: Here is a patch with a fixed commit message (primary index => primary key). Thanks, applied. Thank you! -- Marina Polyakova Postgres Professional: http://www.postgrespro.com

Re: Missing comma?

2020-05-19 Thread Marina Polyakova
On 2020-05-19 05:49, Michael Paquier wrote: On Mon, May 18, 2020 at 10:31:35PM +0300, Marina Polyakova wrote: On 2020-05-18 09:16, Michael Paquier wrote: Would you like to send an updated patch? Note that as the release of beta1 is planned for this week, we have a grace period until the

Re: Missing comma?

2020-05-18 Thread Marina Polyakova
On 2020-05-18 09:16, Michael Paquier wrote: On Sat, May 16, 2020 at 09:38:46PM +0300, Marina Polyakova wrote: I like if we can explain the situation in more detail. But IMO the phrase "same as default" sounds as if we will try to find the primary index and use it if the required i

Re: Missing comma?

2020-05-16 Thread Marina Polyakova
On 2020-05-15 05:16, Michael Paquier wrote: On Thu, May 14, 2020 at 06:30:38PM +0300, Marina Polyakova wrote: Perhaps it will be useful for some users to know that relreplident = i does not mean that the required index exists (as in default case)?.. Yeah, that feels incomplete and I think

Re: Missing comma?

2020-05-14 Thread Marina Polyakova
On 2020-05-14 03:07, Michael Paquier wrote: On Wed, May 13, 2020 at 05:17:43PM +0300, Marina Polyakova wrote: in my opinion it's a little unclear what "or default" means at the end, because the comma is used to separate enumeration elements ("d = default <...>, n = n

Re: Missing comma?

2020-05-13 Thread Marina Polyakova
patch from me to clarify this place, thanks to Alexander Lakhin for help. On 2020-05-13 16:23, Daniel Gustafsson wrote: On 13 May 2020, at 12:20, Marina Polyakova wrote: https://www.postgresql.org/docs/current/catalog-pg-class.html says "Columns used to form “replica identity” for rows: d =

Missing comma?

2020-05-13 Thread Marina Polyakova
(or other punctuation mark) before "i = index"?.. -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company