Re: Document if width_bucket's low and high are inclusive/exclusive

2025-06-18 Thread Robert Treat
On Wed, Jun 18, 2025 at 4:12 PM Tom Lane wrote: > Robert Treat writes: > > On Fri, Feb 28, 2025 at 7:15 AM Ben Peachey Higdon > > wrote: > >> The current documentation for width_bucket > >> (https://www.postgresql.org/docs/current/functions-math.html) does not > >> mention if the range’s low a

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Michael Paquier
On Wed, Jun 18, 2025 at 04:55:56PM +0900, Fujii Masao wrote: > Thanks for the review! I will commit the patch barring any other objections. Thanks. -- Michael signature.asc Description: PGP signature

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Fujii Masao
On 2025/06/18 16:55, Fujii Masao wrote: On 2025/06/18 15:50, Michael Paquier wrote: On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on

Re: Mention GIN indexes support parallel builds.

2025-06-18 Thread Fujii Masao
On 2025/06/19 4:50, Robert Treat wrote: On Wed, Jun 18, 2025 at 3:55 AM Fujii Masao wrote: Hi, Commit 8492feb98f6 added support for parallel CREATE INDEX on GIN indexes. However, there are still two places in the docs and two in the source code comments that mention only B-tree and BRIN as

Re: Document if width_bucket's low and high are inclusive/exclusive

2025-06-18 Thread Tom Lane
Robert Treat writes: > On Fri, Feb 28, 2025 at 7:15 AM Ben Peachey Higdon > wrote: >> The current documentation for width_bucket >> (https://www.postgresql.org/docs/current/functions-math.html) does not >> mention if the range’s low and high are inclusive or exclusive. > I'm not sure it's the

Re: Mention GIN indexes support parallel builds.

2025-06-18 Thread Robert Treat
On Wed, Jun 18, 2025 at 3:55 AM Fujii Masao wrote: > > Hi, > > Commit 8492feb98f6 added support for parallel CREATE INDEX on GIN indexes. > However, there are still two places in the docs and two in the source code > comments that mention only B-tree and BRIN as supporting parallel builds. > > The

Re: Document if width_bucket's low and high are inclusive/exclusive

2025-06-18 Thread Robert Treat
On Fri, Feb 28, 2025 at 7:15 AM Ben Peachey Higdon wrote: > The current documentation for width_bucket > (https://www.postgresql.org/docs/current/functions-math.html) does not > mention if the range’s low and high are inclusive or exclusive. > > Returns the number of the bucket in which operand

Re: Deprecated openssl command option in documentation

2025-06-18 Thread Daniel Gustafsson
> On 18 Jun 2025, at 13:24, PG Doc comments form wrote: > -noencDon't encrypt private keys > -nodesDon't encrypt private keys; deprecated > ``` > Therefore, I suggest you replace the "-nodes" switch in the command example > to "-noenc". Thanks for your report! Th

Deprecated openssl command option in documentation

2025-06-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/17/ssl-tcp.html Description: Hi In the documentation at https://www.postgresql.org/docs/17/ssl-tcp.html, it says, in 18.9.5. Creating Certificates: ``` To create a simple self-signed certific

Re: Fix inaccurate mention of index comments in CREATE FOREIGN TABLE docs

2025-06-18 Thread Fujii Masao
On 2025/06/18 15:50, Michael Paquier wrote: On Wed, Jun 18, 2025 at 02:34:55PM +0900, Fujii Masao wrote: Commit 302cf157592 added support for LIKE in CREATE FOREIGN TABLE. In this feature, since indexes are not created for foreign tables, comments on indexes are not copied either. Good poin

Mention GIN indexes support parallel builds.

2025-06-18 Thread Fujii Masao
Hi, Commit 8492feb98f6 added support for parallel CREATE INDEX on GIN indexes. However, there are still two places in the docs and two in the source code comments that mention only B-tree and BRIN as supporting parallel builds. These references should be updated to include GIN indexes as well. P