Re: Correction in doc of failover ready steps

2024-07-22 Thread shveta malik
On Tue, Jul 23, 2024 at 8:14 AM Zhijie Hou (Fujitsu) wrote: > > I also agree that separating the 2 queries makes sense. Please find the patch with the suggested change. thanks Shveta v2-0001-Correction-in-doc-of-failover-ready-steps.patch Description: Binary data

RE: Correction in doc of failover ready steps

2024-07-22 Thread Zhijie Hou (Fujitsu)
On Monday, July 22, 2024 7:13 PM Amit Kapila wrote: > > On Mon, Jul 22, 2024 at 10:59 AM shveta malik > wrote: > > > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik > wrote: > > > > > > Hi, > > > > > > We have a query in failover-ready doc referring to > > > pg_subscription_rel. Unlike pg_subsc

Re: Undocumented optionality of handler_statements

2024-07-22 Thread Michael Paquier
On Mon, Jul 22, 2024 at 01:55:52PM +, PG Doc comments form wrote: > In > https://www.postgresql.org/docs/16/plpgsql-control-structures.html#PLPGSQL-ERROR-TRAPPING > handler_statements are documented as optional. > > However, the following example shows that handler_statements can be omitted.

Re: Undocumented count in FORWARD/BACKWARD direction of MOVE statement

2024-07-22 Thread Philipp Salvisberg
> On 22 Jul 2024, at 18:24, Tom Lane wrote: > > PG Doc comments form writes: >> The following documentation comment has been logged on the website: >> Page: https://www.postgresql.org/docs/16/plpgsql-cursors.html >> Description: > >> The documentation shows this example for the MOVE statement

Re: Undocumented count in FORWARD/BACKWARD direction of MOVE statement

2024-07-22 Thread Tom Lane
PG Doc comments form writes: > The following documentation comment has been logged on the website: > Page: https://www.postgresql.org/docs/16/plpgsql-cursors.html > Description: > The documentation shows this example for the MOVE statement: > MOVE FORWARD 2 FROM curs4; > According to the docs,

Re: Undocumented := alternative in using option of raise statement

2024-07-22 Thread Philipp Salvisberg
> On 22 Jul 2024, at 15:18, jian he wrote: > > On Mon, Jul 22, 2024 at 8:38 PM PG Doc comments form > wrote: >> >> The following documentation comment has been logged on the website: >> >> Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html >> Description: >> >> The us

Undocumented optionality of handler_statements

2024-07-22 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/plpgsql-control-structures.html Description: In https://www.postgresql.org/docs/16/plpgsql-control-structures.html#PLPGSQL-ERROR-TRAPPING handler_statements are documented as optional. Ho

Re: Undocumented := alternative in using option of raise statement

2024-07-22 Thread jian he
On Mon, Jul 22, 2024 at 8:38 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html > Description: > > The using option is documented as follows for all variants of the rai

Undocumented := alternative in using option of raise statement

2024-07-22 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html Description: The using option is documented as follows for all variants of the raise statement: USING option = expression [, ... ] However, since "do $$

Undocumented count in FORWARD/BACKWARD direction of MOVE statement

2024-07-22 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/plpgsql-cursors.html Description: The documentation shows this example for the MOVE statement: MOVE FORWARD 2 FROM curs4; According to the docs, this should not work. The count is docume

Re: Correction in doc of failover ready steps

2024-07-22 Thread Amit Kapila
On Mon, Jul 22, 2024 at 10:59 AM shveta malik wrote: > > On Mon, Jul 22, 2024 at 10:46 AM shveta malik wrote: > > > > Hi, > > > > We have a query in failover-ready doc referring to > > pg_subscription_rel. Unlike pg_subscription, pg_subscription_rel gives > > results only when connected to the da

Re: Fix an incorrect statement for failover option in alter_subscription.sgml

2024-07-22 Thread Amit Kapila
On Mon, Jul 22, 2024 at 10:45 AM shveta malik wrote: > > On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu) > wrote: > > > > Hi, > > > > The documentation incorrectly stated that users cannot alter subscription's > > failover option when two-phase commit is enabled. > > > > When writing this d