RE: Fix an incorrect statement for failover option in alter_subscription.sgml

2024-07-18 Thread Zhijie Hou (Fujitsu)
On Friday, July 19, 2024 1:13 PM Zhijie Hou (Fujitsu) wrote: > > Hi, > > The documentation incorrectly stated that users cannot alter subscription's > failover option when two-phase commit is enabled. > > When writing this doc, I only wanted to mention we cannot execute ALTER SUB > SET > (fail

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread David G. Johnston
On Thu, Jul 18, 2024 at 9:05 PM Tom Lane wrote: > "David G. Johnston" writes: > > On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier > wrote: > >> Not sure that this is worth changing. The examples work OK when taken > >> in isolation or are able to demonstrate the point they want to show. > >> I

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread Tom Lane
"David G. Johnston" writes: > On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier wrote: >> Not sure that this is worth changing. The examples work OK when taken >> in isolation or are able to demonstrate the point they want to show. >> In short, not all these queries are here to be compatible with

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread David G. Johnston
On Thu, Jul 18, 2024 at 7:10 PM Michael Paquier wrote: > On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote: > > I have found executable examples that do not work correctly > > in the doc of "SQL Functions Returning Sets" in xfunc.sgml. > > So I fixed the examples as follows. > > The attached pa

Re: A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread Michael Paquier
On Fri, Jul 19, 2024 at 10:46:04AM +0900, 日向充 wrote: > I have found executable examples that do not work correctly > in the doc of "SQL Functions Returning Sets" in xfunc.sgml. > So I fixed the examples as follows. > - Changed CREATE TABLE tab > '(y int, z int)' to '(x int, y int, z int)' > - Cha

A minor bug in the doc of "SQL Functions Returning Sets" in xfunc.sgml.

2024-07-18 Thread 日向充
Hi! I have found executable examples that do not work correctly in the doc of "SQL Functions Returning Sets" in xfunc.sgml. So I fixed the examples as follows. - Changed CREATE TABLE tab '(y int, z int)' to '(x int, y int, z int)' - Changed INSERT INTO tab '(1, 2), (3, 4), (5, 6), (7, 8)' to

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Jonathan S. Katz
On 7/18/24 1:59 PM, Daniel Gustafsson wrote: On 18 Jul 2024, at 15:49, Tom Lane wrote: Daniel Gustafsson writes: While not a standard the pilcrow [0] is, AFAICT from a bit of looking at other docs, commonly used for this. There is a lot of variability though so whichever we choose it will be

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Tom Lane
Daniel Gustafsson writes: > Looking a bit closer, the Python documentation does just this, a pilcrow with > a > tool-tip ("Link to this heading") when hovering over it Oh nice --- a precedent! And one that a fair number of people will have seen before. +1 for copying Python.

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Daniel Gustafsson
> On 18 Jul 2024, at 15:49, Tom Lane wrote: > > Daniel Gustafsson writes: >> While not a standard the pilcrow [0] is, AFAICT from a bit of looking at >> other >> docs, commonly used for this. There is a lot of variability though so >> whichever we choose it will be wrong one for someone. > >

Re: Add small detail to RAISE statement descripton

2024-07-18 Thread Tom Lane
Laurenz Albe writes: > On Mon, 2024-07-15 at 21:30 +0300, Igor Gnatyuk wrote: >> Attached you will find new patch version fix_doc_raise_v4.patch, >> please check it out. > Thanks. I have marked the patch as "ready for committer". I fooled with the wording a bit more and pushed it. Thanks for th

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Tom Lane
Daniel Gustafsson writes: > While not a standard the pilcrow [0] is, AFAICT from a bit of looking at other > docs, commonly used for this. There is a lot of variability though so > whichever we choose it will be wrong one for someone. I like this suggestion better because that's U+00B6, ie part

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread David Rowley
On Thu, 18 Jul 2024 at 19:46, Daniel Gustafsson wrote: > There is a lot of variability though so > whichever we choose it will be wrong one for someone. I think the tooltip would help reduce the chances of someone being confused. For an example, see [1]. David [1] https://devblogs.microsoft.c

Privileges to execute ALTER TABLE

2024-07-18 Thread Erki Eessaar
Hello ALTER TABLE documentation writes: "You must own the table to use ALTER TABLE. To change the schema or tablespace of a table, you must also have CREATE privilege on the new schema or tablespace. To add the table as a new child of a parent table, you must own the parent table as well. Also,

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Daniel Gustafsson
> On 18 Jul 2024, at 07:18, Tom Lane wrote: > Yeah. I've found this new feature useful multiple times already, > but the '#' icon is as non-mnemonic and unobvious as could possibly > be. OTOH, I don't know of a standard icon for this feature. While not a standard the pilcrow [0] is, AFAICT fro

Re: A minor bug in doc. Hovering over heading shows # besides it.

2024-07-18 Thread Dean Rasheed
On Thu, 18 Jul 2024 at 07:40, David Rowley wrote: > > On Thu, 18 Jul 2024 at 17:18, Tom Lane wrote: > > Yeah. I've found this new feature useful multiple times already, > > but the '#' icon is as non-mnemonic and unobvious as could possibly > > be. OTOH, I don't know of a standard icon for this