RE: pg_type_d.h location incorrect

2021-05-25 Thread tanghy.f...@fujitsu.com
On Wednesday, May 26, 2021 12:20 PM, Tom Lane wrote >In the first place, it's somewhere between unhelpful and flat out wrong for >people on Windows, where the backtick notation doesn't work (AFAIK). >In the second, it will distract almost every user, who will need >to stop for a second or two to t

Re: pg_type_d.h location incorrect

2021-05-25 Thread Tom Lane
"tanghy.f...@fujitsu.com" writes: > Attached a patch to fix the incorrect location description of pg_type_d.h > posted by myself at [1]. I don't particularly find that to be an improvement. In the first place, it's somewhere between unhelpful and flat out wrong for people on Windows, where the

RE: pg_type_d.h location incorrect

2021-05-25 Thread tanghy.f...@fujitsu.com
Hi Attached a patch to fix the incorrect location description of pg_type_d.h posted by myself at [1]. [1] https://www.postgresql.org/message-id/162149020918.26174.7150424047314144...@wrigleys.postgresql.org Regards, Tang 0001-dir-fix-for-pg_type_d.h.patch Description: 0001-dir-fix-for-pg_typ

Re: Duplicate paragraph

2021-05-25 Thread David G. Johnston
On Tuesday, May 25, 2021, Tom Lane wrote: > Bruce Momjian writes: > > On Mon, May 24, 2021 at 09:35:49PM -0700, David G. Johnston wrote: > >> They are two different things, as evidenced by there being two different > >> sections with different section headings, that use the same fundamental > wr

Re: Duplicate paragraph

2021-05-25 Thread Tom Lane
Bruce Momjian writes: > On Mon, May 24, 2021 at 09:35:49PM -0700, David G. Johnston wrote: >> They are two different things, as evidenced by there being two different >> sections with different section headings, that use the same fundamental >> writing >> rules. > We have gotten reports about th

Re: Duplicate paragraph

2021-05-25 Thread David G. Johnston
On Tuesday, May 25, 2021, Bruce Momjian wrote: > On Mon, May 24, 2021 at 09:35:49PM -0700, David G. Johnston wrote: > > On Monday, May 24, 2021, PG Doc comments form > wrote: > > > > Right up to the end of section 4.1.1, is > > almost copied word-by-word in section 4.1.2.3 - String Const

Re: Duplicate paragraph

2021-05-25 Thread Bruce Momjian
On Mon, May 24, 2021 at 09:35:49PM -0700, David G. Johnston wrote: > On Monday, May 24, 2021, PG Doc comments form wrote: > > Right up to the end of section 4.1.1, is > almost copied word-by-word in section 4.1.2.3 - String Constants With > Unicode Escapes. > > > > They are two dif