Re: pg_wal_lsn_diff

2021-02-06 Thread Tatsuo Ishii
>> I'd just fix HEAD and v13. The earlier branches are not friendly >> at all to long function descriptions. > > +1 from me. Pushed to HEAD and v13. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp

Re: pg_wal_lsn_diff

2021-02-06 Thread Tatsuo Ishii
> I'd just fix HEAD and v13. The earlier branches are not friendly > at all to long function descriptions. +1 from me. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp

Re: pg_wal_lsn_diff

2021-02-06 Thread Tom Lane
Tatsuo Ishii writes: > So do you think we should back-patch to existing stable branches? I'd just fix HEAD and v13. The earlier branches are not friendly at all to long function descriptions. regards, tom lane

Re: pg_wal_lsn_diff

2021-02-06 Thread Tatsuo Ishii
> +1 for fixing that. Two notes though: first, your text doesn't agree > with the prototype ("ls1" should be "lsn1"), and second, I think it > would read better if you didn't split the phrase "difference in bytes". > That is, > > -Calculates the difference in bytes between two write-ahead

Re: The synopsis of "ALTER DEFAULT PRIVILEGES" statement is too difficult to understand

2021-02-06 Thread Tom Lane
PG Doc comments form writes: > The syntax/synopsis of the "ALTER DEFAULT PRIVILEGES" statement on the > https://www.postgresql.org/docs/13/sql-alterdefaultprivileges.html page can > be simplified to the below form: > [ factor out privileges and object type ] Hmm. I can't get too excited about do

Re: pg_wal_lsn_diff

2021-02-06 Thread Tom Lane
Tatsuo Ishii writes: > According to the pg_wal_lsn_diff manual: > pg_wal_lsn_diff ( lsn pg_lsn, lsn pg_lsn ) → numeric > Calculates the difference in bytes between two write-ahead log > locations. This can be used with pg_stat_replication or some of > the functions shown in Tab

The synopsis of "ALTER DEFAULT PRIVILEGES" statement is too difficult to understand

2021-02-06 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/13/sql-alterdefaultprivileges.html Description: The syntax/synopsis of the "ALTER DEFAULT PRIVILEGES" statement on the https://www.postgresql.org/docs/13/sql-alterdefaultprivileges.html page