Re: Make default values bold in Synopsis / bnf diagram

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 1:56 PM Bruce Momjian wrote: > On Mon, Dec 2, 2019 at 09:19:32PM +, PG Doc comments form wrote: > > > In this example the words to words "READ COMMITTED", "READ WRITE" should > be > > bold since they are default values if I execute the statement "BEGIN;" > see > > the

Re: Make default values bold in Synopsis / bnf diagram

2019-12-20 Thread Bruce Momjian
On Mon, Dec 2, 2019 at 09:19:32PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-set-transaction.html > Description: > > As an example let's take take "BEGIN" > in the Synopsis : > ---

Re: COPY manual is ambiguous about column list

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 9:21 AM Tom Lane wrote: > Bruce Momjian writes: > > OK, this wording is obviously harder than I thought. Updated patch > > attached. > > That one works for me. > Me too. David J.

Re: COPY manual is ambiguous about column list

2019-12-20 Thread Tom Lane
Bruce Momjian writes: > OK, this wording is obviously harder than I thought. Updated patch > attached. That one works for me. regards, tom lane

Re: COPY manual is ambiguous about column list

2019-12-20 Thread Bruce Momjian
On Fri, Dec 20, 2019 at 07:29:33AM -0700, David G. Johnston wrote: > This has the same "match by name" possibility when I read it... > > I don't see the benefit of repeating "If a column list is specified" a second > time in the three sentence paragraph.  To a lesser extent the same goes for > th

Re: COPY manual is ambiguous about column list

2019-12-20 Thread David G. Johnston
On Fri, Dec 20, 2019 at 7:13 AM Tom Lane wrote: > Bruce Momjian writes: > > OK, how is this? > > I do not like the phrasing of > > If a column list is > specified in COPY FROM, the number and position of > the columns must match those fields in the file. > > I'm not quite sure why, b

Re: COPY manual is ambiguous about column list

2019-12-20 Thread Tom Lane
Bruce Momjian writes: > OK, how is this? I do not like the phrasing of If a column list is specified in COPY FROM, the number and position of the columns must match those fields in the file. I'm not quite sure why, but that reads to me as implying that the COPY will identify columns

Re: COPY manual is ambiguous about column list

2019-12-20 Thread Bruce Momjian
On Thu, Dec 19, 2019 at 10:33:48PM -0700, David G. Johnston wrote: > On Thursday, December 19, 2019, Tom Lane wrote: > > "David G. Johnston" writes: > > Seems better to simply talk about each form independently: > > > If a list of columns is specified, COPY TO will only > > copy