Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Thu, Sep 26, 2019 at 11:03:54PM +0200, Tomas Vondra wrote: > On Thu, Sep 26, 2019 at 04:20:59PM -0400, Bruce Momjian wrote: > > Uh, people normally list things in defined order, so you would usually > > not list them in non-defined order unless there is a purpose. Doing > > that just to illustr

Re: Most-common value docs in PG 12

2019-09-26 Thread Tomas Vondra
On Thu, Sep 26, 2019 at 04:20:59PM -0400, Bruce Momjian wrote: On Thu, Sep 26, 2019 at 05:17:55PM -0300, Alvaro Herrera wrote: On 2019-Sep-26, Bruce Momjian wrote: > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > OK, how is thi

Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Thu, Sep 26, 2019 at 05:17:55PM -0300, Alvaro Herrera wrote: > On 2019-Sep-26, Bruce Momjian wrote: > > > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > > > OK, how is this patch? I didn't mention psql since I think everyon

Re: Most-common value docs in PG 12

2019-09-26 Thread Alvaro Herrera
On 2019-Sep-26, Bruce Momjian wrote: > On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > > On 2019-Aug-30, Bruce Momjian wrote: > > > > > OK, how is this patch? I didn't mention psql since I think everyone > > > expects psql to show all information about tables and indexes. > >

Re: Logical replication restriction documentation

2019-09-26 Thread Peter Eisentraut
On 2019-09-25 16:43, PG Doc comments form wrote: > I believe the doc note above should be revised to clarify what works and > doesn't work in relation to partitioning and logical replication, and > perhaps these two terms should be defined on this page. It looked pretty clear to me. What in parti

Re: Most-common value docs in PG 12

2019-09-26 Thread Bruce Momjian
On Wed, Sep 11, 2019 at 06:15:22PM -0300, Alvaro Herrera wrote: > On 2019-Aug-30, Bruce Momjian wrote: > > > OK, how is this patch? I didn't mention psql since I think everyone > > expects psql to show all information about tables and indexes. > > Why would you change perform.sgml? It seems unn

default_tablespace and parallel queries

2019-09-26 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/manage-ag-tablespaces.html Description: Hi, "default_tablespace" parameter in "postgresql.conf" does something to GATHER (in parallel query). Because when default_tablespace is set to wh

Re: BUG #16022: to_json on arrays with unusual lower bound is not intuitive

2019-09-26 Thread Andreas Bergmaier
Hi! On 25.09.19 16:34, Tom Lane wrote: > PG Bug reporting form writes: >> I would expect the array indices of a JSON array to match with the >> subscripts of a postgres array when converting them back and forth. >> However, Postgres lets the JSON array begin at the `lower_bound` of the >> array,

Logical replication restriction documentation

2019-09-26 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/logical-replication-restrictions.html Description: Re this note in the "logical replication restrictions" documentation page: Replication is only possible from base tables to base tables.

Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.

2019-09-26 Thread Peter Eisentraut
On 2019-09-25 00:13, Tom Lane wrote: > Peter Eisentraut writes: >> PostgreSQL 12 requires C99, so those guidelines should probably be >> rephrased from "because old compilers don't accept it" to "because we >> like it that way". > > Yeah, or more formally "to encourage consistent coding style".