Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Michael Paquier
On Tue, Jul 09, 2019 at 03:34:48PM +0900, Michael Paquier wrote: > Looking closely at the code in DefineIndex() (and as Rajkumar has > mentioned upthread for unique constraints) this can happen for primary > keys, unique constraints and exclusion constraints. So we had better > mention all three o

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Michael Paquier
On Mon, Jul 08, 2019 at 11:10:51PM -0400, Tom Lane wrote: > Isn't it the other way around, that the partition key column(s) must > be > included in the primary key? Maybe I'm confused, but it seems like > we couldn't enforce PK uniqueness otherwise. Yes you are right. The full column list of the

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Michael Paquier
On Mon, Jul 08, 2019 at 08:12:18PM -0700, David G. Johnston wrote: > Reads a bit backward. How about: > > "As uniqueness can only be enforced within an individual partition when > defining a primary key on a partitioned table all columns present in the > partition key must also exist in the prima

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Rajkumar Raghuwanshi
On Tue, Jul 9, 2019 at 8:29 AM Michael Paquier wrote: > On Mon, Jul 08, 2019 at 10:37:37PM -0400, Bruce Momjian wrote: > > On Fri, Jul 5, 2019 at 09:20:07PM +, PG Doc comments form wrote: > >> In the documentation for Postgres 11 table partitioning, there is no > mention > >> of the requirem

Re: Ambiguous language in Table 8.13. Special Date/Time Inputs

2019-07-08 Thread Bruce Momjian
On Mon, Jul 8, 2019 at 10:07:59AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/datatype-datetime.html > Description: > > In Table 8.13. Special Date/Time Inputs, the description for the speci

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread David G. Johnston
On Mon, Jul 8, 2019 at 7:59 PM Michael Paquier wrote: > Attached is an idea of patch for the documentation, using this > wording: > + > + > + When defining a primary key on a partitioned table, the primary > + key column must be included in the partition key. > + > +

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Tom Lane
Michael Paquier writes: > Attached is an idea of patch for the documentation, using this > wording: > + > + > + When defining a primary key on a partitioned table, the primary > + key column must be included in the partition key. > + > + Isn't it the other way ar

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Michael Paquier
On Mon, Jul 08, 2019 at 10:37:37PM -0400, Bruce Momjian wrote: > On Fri, Jul 5, 2019 at 09:20:07PM +, PG Doc comments form wrote: >> In the documentation for Postgres 11 table partitioning, there is no mention >> of the requirement that the Primary Key of a partitioned table must contain >> th

Re: Postgres 11: Table Partitioning and Primary Keys

2019-07-08 Thread Bruce Momjian
On Fri, Jul 5, 2019 at 09:20:07PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/ddl-partitioning.html > Description: > > In the documentation for Postgres 11 table partitioning, there is no me

Re: TOC: List of Figures

2019-07-08 Thread Jonathan S. Katz
On 7/8/19 4:21 PM, Daniel Gustafsson wrote: >> On 8 Jul 2019, at 22:10, Tom Lane wrote: > >> let's wait till there's a >> meaningful number of figures and then reconsider whether there's use in >> a list of them. It's not like it will be any harder to make that change >> in a year or two than it

Re: TOC: List of Figures

2019-07-08 Thread Daniel Gustafsson
> On 8 Jul 2019, at 22:10, Tom Lane wrote: > let's wait till there's a > meaningful number of figures and then reconsider whether there's use in > a list of them. It's not like it will be any harder to make that change > in a year or two than it is today. In that case, let’s record this in the

Re: TOC: List of Figures

2019-07-08 Thread Tom Lane
Daniel Gustafsson writes: >> On 8 Jul 2019, at 21:43, Peter Eisentraut >> wrote: >> This would make sense if we had fifty images spread evenly throughout >> the documentation, or moreover, we had an image for every topic. Then >> learning by just flipping through the images would be interesting

Re: TOC: List of Figures

2019-07-08 Thread Daniel Gustafsson
> On 8 Jul 2019, at 21:43, Peter Eisentraut > wrote: > > On 2019-07-08 07:20, Jürgen Purtz wrote: >> To support the didactic method of media changes we >> should promote graphics with a summarizing list at a prominent place in >> front of the manual. > > This would make sense if we had fifty

Re: TOC: List of Figures

2019-07-08 Thread Peter Eisentraut
On 2019-07-08 07:20, Jürgen Purtz wrote: > To support the didactic method of media changes we > should promote graphics with a summarizing list at a prominent place in > front of the manual. This would make sense if we had fifty images spread evenly throughout the documentation, or moreover, we

Ambiguous language in Table 8.13. Special Date/Time Inputs

2019-07-08 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/datatype-datetime.html Description: In Table 8.13. Special Date/Time Inputs, the description for the special values 'today', 'tomorrow' and 'yesterday' uses the word 'midnight' e.g. the sp

Make 'Genetic Algorithm' a real figure

2019-07-08 Thread Jürgen Purtz
Currently the 'figure' of a genetic algorithm is created with some kind of 'ascii art'. The patch makes it a real figure. Kind regards Jürgen Purtz diff --git a/doc/src/sgml/geqo.sgml b/doc/src/sgml/geqo.sgml index 5120dfbb42..5a52fb46db 100644 --- a/doc/src/sgml/geqo.sgml +++ b/doc/src/sg