Re: some grammar fixes for docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 07:55:57PM -0400, Tom Lane wrote: > This distinction is widely ignored in casual speech or writing, but > it's still recognized in formal writing. I think our manual is > formal enough that we should try to get it right. Thanks for the inputs, Tom and Jonathan. I see the

Re: some grammar fixes for docs

2019-05-16 Thread Tom Lane
Michael Paquier writes: > On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: >> -Transaction which last more than limit >> milliseconds >> +Transactions that last more than limit >> milliseconds > I don't see much of a difference between "which" or "that" in this

Re: some grammar fixes for docs

2019-05-16 Thread Jonathan S. Katz
On 5/16/19 7:32 PM, Michael Paquier wrote: > On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: >> I have noticed imperfect grammar in a couple of sgml files, please consider >> a small patch (attached). > > Thanks, Liudmila for caring about such matters. > >> >> -

Re: some grammar fixes for docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: > I have noticed imperfect grammar in a couple of sgml files, please consider > a small patch (attached). Thanks, Liudmila for caring about such matters. > > -Transaction which last more than limit > milliseconds

Re: Typo in GSSAPI docs

2019-05-16 Thread Michael Paquier
On Thu, May 16, 2019 at 11:26:39AM +0200, Daniel Gustafsson wrote: > Reading a bit closer there was one more, updated diff attached. Thanks Daniel, committed. -- Michael signature.asc Description: PGP signature

Re: Documentation for partitioned indexes?

2019-05-16 Thread Alvaro Herrera
On 2019-Apr-26, Tom Lane wrote: > Alvaro Herrera writes: > > I suppose I better add something in Chapter 5 (DDL), possibly inside the > > 5.10 section (Table Partitioning) -- a new 5.10.6 "Indexes for > > Partitioned Tables" perhaps? > > I was expecting to find it in "5.11.2.2. Partition Mainten

Documentation bug

2019-05-16 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/9.6/sql-createfunction.html Description: In the documentation https://www.postgresql.org/account/comments/new/9.6/sql-createfunction.html/ (and in the same document for earlier versions) the

Re: a small fix for Release notes 11.3

2019-05-16 Thread Liudmila Mantrova
On 5/16/19 7:03 PM, Jonathan S. Katz wrote: On 5/16/19 10:17 AM, Liudmila Mantrova wrote: Hello, Please consider a mini-patch for 11.3 release notes that fixes pg_dump-related wording and also makes Jonathan's name consistent with how it's listed in contributors list. I am flattered by your

Re: a small fix for Release notes 11.3

2019-05-16 Thread Jonathan S. Katz
On 5/16/19 10:17 AM, Liudmila Mantrova wrote: > Hello, > > Please consider a mini-patch for 11.3 release notes that fixes > pg_dump-related wording and also makes Jonathan's name consistent with > how it's listed in contributors list. I am flattered by your attention to detail around my name, but

a small fix for Release notes 11.3

2019-05-16 Thread Liudmila Mantrova
Hello, Please consider a mini-patch for 11.3 release notes that fixes pg_dump-related wording and also makes Jonathan's name consistent with how it's listed in contributors list. -- Liudmila Mantrova Technical writer at Postgres Professional: http://www.postgrespro.com The Russian Postgres Co

some grammar fixes for docs

2019-05-16 Thread Liudmila Mantrova
Hi, I have noticed imperfect grammar in a couple of sgml files, please consider a small patch (attached). -- Liudmila Mantrova Technical writer at Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgben

Re: Typo in GSSAPI docs

2019-05-16 Thread Daniel Gustafsson
> On 16 May 2019, at 10:40, Daniel Gustafsson wrote: > > Commit b0b39f72b99 introduced a small typo in the GSSAPI documentation, see > attached diff. Reading a bit closer there was one more, updated diff attached. cheers ./daniel gssapi_typo-v2.diff Description: Binary data

Typo in GSSAPI docs

2019-05-16 Thread Daniel Gustafsson
Commit b0b39f72b99 introduced a small typo in the GSSAPI documentation, see attached diff. cheers ./daniel gssapi_typo.diff Description: Binary data