Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-26 Thread David G. Johnston
On Friday, January 26, 2018, Jim Ryan wrote: > Hey Bruce, > > Thanks for working on this, but wouldn't pg_upgrade be needed from 10.1 to > 10.2? Aren't those considered major versions, or am I misunderstanding? > > The source of my (and potentially others) confusion is if from 9.1 to 9.2 > is co

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-26 Thread Jim Ryan
Hey Bruce, Thanks for working on this, but wouldn't pg_upgrade be needed from 10.1 to 10.2? Aren't those considered major versions, or am I misunderstanding? The source of my (and potentially others) confusion is if from 9.1 to 9.2 is considered a major version change or not. I think most users

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-26 Thread Jim Ryan
Ah! Thank you. That makes more sense. I think this could still be confusing for users who did not know about this change and are on 9.x, because the docs now seemingly imply that they would not need to use pg_upgrade when moving from 9.x to 9.y, when they actually do. Is explaining the recent ve

Re: pg_upgrade docs are confusing if PostgreSQL's versioning system/language isn't known to reader

2018-01-26 Thread Bruce Momjian
On Fri, Jan 26, 2018 at 12:04:17PM -0500, Jim Ryan wrote: > Hey Bruce, > > Thanks for working on this, but wouldn't pg_upgrade be needed from 10.1 to > 10.2?  Aren't those considered major versions, or am I misunderstanding? Uh, it is confusing. We switched in PG 10 from changing the _third_ num

Trailing semicolons on partitioning example commands

2018-01-26 Thread Daniel Gustafsson
Is there a reason for not ending all partitioning commands with semicolons in the declarative partitioning example? https://www.postgresql.org/docs/devel/static/ddl-partitioning.html The two last commands with TABLESPACE clauses are ended with semicolons, the first three arent. Attached

Re: clarify Regular Expression Match Operators

2018-01-26 Thread Bruce Momjian
On Sat, Jan 13, 2018 at 02:59:06PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/functions-matching.html > Description: > > Table 9.14 Regular Expression Match Operators > It is not clea

Re: Correction of intermediate certificate handling

2018-01-26 Thread Michael Paquier
On Fri, Jan 26, 2018 at 08:09:30AM -0500, Bruce Momjian wrote: > On Thu, Jan 25, 2018 at 10:59:23PM -0500, Peter Eisentraut wrote: > > If you change the Makefile rule for generating the client CA to omit the > > -extensions v3_ca option, then the first test will fail. > > Oh, very good! Good poin

Re: Addition to / Clarification in 9.7.1. LIKE

2018-01-26 Thread Bruce Momjian
On Fri, Jan 26, 2018 at 09:52:07AM +0100, GPT wrote: > Between 1st (The LIKE expression...) and 2nd (If pattern does not...) > paragraphs, it could be added something like: > > >Caution > Contrary to some other databases, in Postgresql only two char

Re: Correction of intermediate certificate handling

2018-01-26 Thread Bruce Momjian
On Thu, Jan 25, 2018 at 10:59:23PM -0500, Peter Eisentraut wrote: > On 1/16/18 00:33, Michael Paquier wrote: > > On top of that, src/test/ssl does not provide any kind of coverage for > > that. It would be an area of improvement for those tests. > > The tests already cover this: > > # intermediat

Re: [PATCH] Updating documentation about bulding documentation in Windows.

2018-01-26 Thread Michail Nikolaev
Hello. It is not so easy to fix the script because it is based on old toolset (probably on 9.6). I'll try one more attempt. Regardning WSL: I think it is better to keep some instructions because there are a lot of common errors - line ending, correct usage of linux\windows file system mappings. M

Re: Addition to / Clarification in 9.7.1. LIKE

2018-01-26 Thread GPT
Between 1st (The LIKE expression...) and 2nd (If pattern does not...) paragraphs, it could be added something like: Caution Contrary to some other databases, in Postgresql only two characters are used in LIKE patterns: underscore (_) and percent sign