Re: clang-tidy complaints

2025-04-27 Thread Bertrand Drouvot
cle" in your annual check (see [1])? I'll also put a note on my side to do it at a regular basis. [1]: https://www.postgresql.org/message-id/2238517.1745644856%40sss.pgh.pa.us Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
Hi, On Tue, Aug 19, 2025 at 10:28:29AM -0400, Andres Freund wrote: > Hi, > > On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote: > > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > > > After these two changes, a lot of > > > files can stop in

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
pi_database, false); It looks like pg_database.h include is missing in worker_spi.c. That said, autoconf does not report the issue, and that's because test/modules is missing in src/Makefile. Is there any reasons for that? If not, the attached fix it. Regards, -- B

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
ea at that time was to follow the same build logic as contrib (which, I think, made sense). [1]: https://www.postgresql.org/message-id/20141127192420.GU1639%40alvin.alvh.no-ip.org Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
-world: $(call recurse,installcheck-world,src/test src/pl src/interfaces contrib src/bin,installcheck) build src/test/modules. I just found surprising that a "default" make (no target specified) does not build src/test/modules while a "default" meson/ninja does. Re