pgsql: Fix comment in slot.c.

Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Fix comment in slot.c.

Fix comment in slot.c. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 9.5 Discussion: https://postgr.es/m/ca+fd4k4ws7m7yq8pqsym5wb1y75dzebtd1szjuqdfe0kjq-...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org

pgsql: Doc: Update the documentation for spilled transaction statistics

Doc: Update the documentation for spilled transaction statistics. Reported-by: Sawada Masahiko Author: Sawada Masahiko, Amit Kapila Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CA+fd4k4vNg7dRO5ECHdtQXXf1=q4m98pflw0du7bkd8h79p...@mail.gmail.com Branch -- master Details

pgsql: Fix ReorderBuffer memory overflow check.

change. We fix it by allowing to evict the transactions until we reach under the memory limit. Reported-by: Fujii Masao Author: Amit Kapila Reviewed-by: Fujii Masao Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/2b7ba291-22e0-a187-d167-9e5309a34...@oss.nttdata.com

pgsql: Fix ReorderBuffer memory overflow check.

change. We fix it by allowing to evict the transactions until we reach under the memory limit. Reported-by: Fujii Masao Author: Amit Kapila Reviewed-by: Fujii Masao Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/2b7ba291-22e0-a187-d167-9e5309a34...@oss.nttdata.com

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/12415fb0561b4abae8163ea556917b9c

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b7ed1d9944005ec443c94d3536be4247

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fb024f46369b614eb7f12bc9e097b608

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/277f154e4f1ccc45b39715d777d8ff6e

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ad9291f5e6f81ebca978c4438a1c7a448ca5b9a

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c419f5f5881fd378f40e93ee1ef0fc5

pgsql: Fix typos.

Fix typos. Reported-by: John Naylor Author: John Naylor Backpatch-through: 9.5 Discussion: https://postgr.es/m/cacpnzctruvs6g+eyqejhvjgbq2akezdxrvjsbx4syho9gn5...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c4d5706db298f5a02ffd321c4605a7f8

pgsql: Removal unused function parameter in CopyReadBinaryAttribute.

Removal unused function parameter in CopyReadBinaryAttribute. The function parameter column_no is not used in CopyReadBinaryAttribute, this can be removed. Commit 0e319c7ad7 removed the usage of column_no parameter in function CopyReadBinaryAttribute but forgot to remove the parameter. Reported-

Re: git.postgresql.org ok?

On Sat, Jun 20, 2020 at 6:02 PM Erik Rijkers wrote: > > > I don't know exactly where things are going wrong - could even be local > here but I don't think so.. do others see the same thing? > Yes, I am also facing the same problem. -- With Regards, Amit K

Re: pgsql: Enable Unix-domain sockets support on Windows

to-windows/ [2] - https://gist.github.com/NZSmartie/079d8f894ee94f3035306cb23d49addc -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

pgsql: Remove duplicate check added by commit b2a5545bd6.

Remove duplicate check added by commit b2a5545bd6. As this doesn't cause any harm so we decided to this clean up in HEAD only. Author: Ádám Balogh Discussion: https://postgr.es/m/vi1pr0702mb36631bd67559461afde1feee81...@vi1pr0702mb3663.eurprd07.prod.outlook.com Branch -- master Details ---

pgsql: Improve vacuum error context handling.

Improve vacuum error context handling. Use separate functions to save and restore error context information as that made code easier to understand.  Also, make it clear that the index information required for error context is sane. Author: Andres Freund, Justin Pryzby, Amit Kapila Backpatch

pgsql: Improve vacuum error context handling.

Improve vacuum error context handling. Use separate functions to save and restore error context information as that made code easier to understand.  Also, make it clear that the index information required for error context is sane. Author: Andres Freund, Justin Pryzby, Amit Kapila Backpatch

pgsql: Remove unused function parameter in end_parallel_vacuum.

Remove unused function parameter in end_parallel_vacuum. Author: Vignesh C Reviewed-by: Sawada Masahiko Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/caldanm3ppt71nafgy5mk3v2i3q+mm93pvibdq-0npw7wu67...@mail.gmail.com Branch -- master Details --- https://

pgsql: Remove unused function parameter in end_parallel_vacuum.

Remove unused function parameter in end_parallel_vacuum. Author: Vignesh C Reviewed-by: Sawada Masahiko Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/caldanm3ppt71nafgy5mk3v2i3q+mm93pvibdq-0npw7wu67...@mail.gmail.com Branch -- REL_13_STABLE Details --- h

pgsql: Remove extra whitespace in comments atop ReorderBufferCheckMemor

Remove extra whitespace in comments atop ReorderBufferCheckMemoryLimit. Backpatch-through: 13, where it was introduced Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e163f3a2b1d987f83e291e86969ed4a91ded6abb Modified Files -- src/backend/replicat

pgsql: Remove extra whitespace in comments atop ReorderBufferCheckMemor

Remove extra whitespace in comments atop ReorderBufferCheckMemoryLimit. Backpatch-through: 13, where it was introduced Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/04c7f4144fec3bcddc82b6abdbfebd88989f7953 Modified Files -- src/backend/replication/log

pgsql: Revert "Track statistics for spilling of changes from ReorderBuf

Revert "Track statistics for spilling of changes from ReorderBuffer". The stats with this commit was available only for WALSenders, however, users might want to see for backends doing logical decoding via SQL API. Then, users might want to reset and access these stats across server restart which w

pgsql: Revert "Track statistics for spilling of changes from ReorderBuf

Revert "Track statistics for spilling of changes from ReorderBuffer". The stats with this commit was available only for WALSenders, however, users might want to see for backends doing logical decoding via SQL API. Then, users might want to reset and access these stats across server restart which w

pgsql: Fix signal handler setup for SIGHUP in the apply launcher proces

Fix signal handler setup for SIGHUP in the apply launcher process. Commit 1e53fe0e70 has unified the usage of the config-file reload flag by using the same signal handler function for the SIGHUP signal at many places in the code. By mistake, it used the wrong SIGNAL in apply launcher process for

pgsql: Fix signal handler setup for SIGHUP in the apply launcher proces

Fix signal handler setup for SIGHUP in the apply launcher process. Commit 1e53fe0e70 has unified the usage of the config-file reload flag by using the same signal handler function for the SIGHUP signal at many places in the code. By mistake, it used the wrong SIGNAL in apply launcher process for

pgsql: Fix comments in reorderbuffer.c.

Fix comments in reorderbuffer.c. Author: Dave Cramer Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/cadk3hhl8do4fp1bsymgnasx375njv3ar7zy3ugywzbl_dx-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/df7c5cb16e8fcf960e3302355fa6547fba

pgsql: Adjust minor comment in reorderbuffer.c.

Adjust minor comment in reorderbuffer.c. Author: Dave Cramer Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/cadk3hhl8do4fp1bsymgnasx375njv3ar7zy3ugywzbl_dx-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f41fbee7e704947fd1d2241f35

Re: pgsql: Fix comments in reorderbuffer.c.

On Sat, Jul 18, 2020 at 10:02 AM David G. Johnston wrote: > > On Friday, July 17, 2020, Amit Kapila wrote: >> >> Fix comments in reorderbuffer.c. >> >> Author: Dave Cramer >> Reviewed-by: David G. Johnston >> Discussion: >> https://postgr.es/m

pgsql: Fix minor typo in nodeIncrementalSort.c.

Fix minor typo in nodeIncrementalSort.c. Author: Vignesh C Reviewed-by: James Coleman Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/caldanm0wjzqrvdel59zfyh0o4mlbkq23jm-bnjxcfzgpanx...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgre

pgsql: Fix minor typo in nodeIncrementalSort.c.

Fix minor typo in nodeIncrementalSort.c. Author: Vignesh C Reviewed-by: James Coleman Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/caldanm0wjzqrvdel59zfyh0o4mlbkq23jm-bnjxcfzgpanx...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org

pgsql: Immediately WAL-log subtransaction and top-level XID association

hot standby snapshot. Bump XLOG_PAGE_MAGIC, since this introduces XLR_BLOCK_ID_TOPLEVEL_XID. Author: Tomas Vondra, Dilip Kumar, Amit Kapila Reviewed-by: Amit Kapila Tested-by: Neha Sharma and Mahendra Singh Thalor Discussion: https://postgr.es/m/688b0b7f-2f6c-d827-c27b-216a8e3ea

pgsql: WAL Log invalidations at command end with wal_level=logical.

this introduces XLOG_XACT_INVALIDATIONS. Author: Dilip Kumar, Tomas Vondra, Amit Kapila Reviewed-by: Amit Kapila Tested-by: Neha Sharma and Mahendra Singh Thalor Discussion: https://postgr.es/m/688b0b7f-2f6c-d827-c27b-216a8e3ea...@2ndquadrant.com Branch -- master Details --- https

pgsql: Fix buffer usage stats for nodes above Gather Merge.

are no more tuples. We can do a similar thing for Gather Merge as well but it seems better to account for stats during nodes shutdown after completing the execution. Reported-by: Stéphane Lorek, Jehan-Guillaume de Rorthais Author: Jehan-Guillaume de Rorthais Reviewed-by: Amit Kapila Backpatch

pgsql: Fix buffer usage stats for nodes above Gather Merge.

are no more tuples. We can do a similar thing for Gather Merge as well but it seems better to account for stats during nodes shutdown after completing the execution. Reported-by: Stéphane Lorek, Jehan-Guillaume de Rorthais Author: Jehan-Guillaume de Rorthais Reviewed-by: Amit Kapila Backpatch

pgsql: Fix buffer usage stats for nodes above Gather Merge.

are no more tuples. We can do a similar thing for Gather Merge as well but it seems better to account for stats during nodes shutdown after completing the execution. Reported-by: Stéphane Lorek, Jehan-Guillaume de Rorthais Author: Jehan-Guillaume de Rorthais Reviewed-by: Amit Kapila Backpatch

pgsql: Fix buffer usage stats for nodes above Gather Merge.

are no more tuples. We can do a similar thing for Gather Merge as well but it seems better to account for stats during nodes shutdown after completing the execution. Reported-by: Stéphane Lorek, Jehan-Guillaume de Rorthais Author: Jehan-Guillaume de Rorthais Reviewed-by: Amit Kapila Backpatch

pgsql: Fix buffer usage stats for nodes above Gather Merge.

are no more tuples. We can do a similar thing for Gather Merge as well but it seems better to account for stats during nodes shutdown after completing the execution. Reported-by: Stéphane Lorek, Jehan-Guillaume de Rorthais Author: Jehan-Guillaume de Rorthais Reviewed-by: Amit Kapila Backpatch

pgsql: Extend the logical decoding output plugin API with stream method

APIs. Author: Tomas Vondra, Dilip Kumar, Amit Kapila Reviewed-by: Amit Kapila Tested-by: Neha Sharma and Mahendra Singh Thalor Discussion: https://postgr.es/m/688b0b7f-2f6c-d827-c27b-216a8e3ea...@2ndquadrant.com Branch -- master Details --- https://git.postgres

pgsql: Implement streaming mode in ReorderBuffer.

gets discarded). We also provide a new option via SQL APIs to fetch the changes being streamed. Author: Dilip Kumar, Tomas Vondra, Amit Kapila, Nikhil Sontakke Reviewed-by: Amit Kapila, Kuntal Ghosh, Ajin Cherian Tested-by: Neha Sharma, Mahendra Singh Thalor and Ajin Cherian Discussion:

Re: pgsql: Implement streaming mode in ReorderBuffer.

On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > Implement streaming mode in ReorderBuffer. > There is one failure [1] due to this commit. Looking into same. [1] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2020-08-08%2004%3A26%3A04 -- With Regards, Amit Kapila.

Re: pgsql: Implement streaming mode in ReorderBuffer.

On Sat, Aug 8, 2020 at 11:03 AM Amit Kapila wrote: > > On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > > > Implement streaming mode in ReorderBuffer. > > > > There is one failure [1] due to this commit. Looking into same. > The problem seems to be due to

pgsql: Fix the logical streaming test.

Fix the logical streaming test. Commit 7259736a6e added the capability to stream changes in ReorderBuffer which has some tests to test the streaming mode. It is quite possible that while this test is running a parallel transaction could be logged by autovacuum. Such a transaction won't perform any

pgsql: Mark a few logical decoding related variables with PGDLLIMPORT.

Mark a few logical decoding related variables with PGDLLIMPORT. Commit 7259736a6e added two variables CheckXidAlive and bsysscan to detect concurrent aborts and used these in inline functions that are part of the API that can be used by extensions. So it is better to mark them with PGDLLIMPORT. R

pgsql: Improve the vacuum error context phase information.

number is valid which is fine for error cases but for messages at 'info' or lower error level it appears to be inconsistent with index phase information. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 13, where it was introduced Discussion

pgsql: Improve the vacuum error context phase information.

number is valid which is fine for error cases but for messages at 'info' or lower error level it appears to be inconsistent with index phase information. Reported-by: Sawada Masahiko Author: Sawada Masahiko Reviewed-by: Amit Kapila Backpatch-through: 13, where it was introduced Discussion

pgsql: Extend the BufFile interface.

-only mode. These enhancements in BufFile interface are required for the upcoming patch to allow the replication apply worker, to handle streamed in-progress transactions. Author: Dilip Kumar, Amit Kapila Reviewed-by: Amit Kapila Tested-by: Neha Sharma Discussion: https://postgr.es/m/688b0b7f-2f6c

pgsql: Add additional information in the vacuum error context.

Add additional information in the vacuum error context. The additional information added will be an offset number for heap operations. This information will help us in finding the exact tuple due to which the error has occurred. Author: Mahendra Singh Thalor and Amit Kapila Reviewed-by: Sawada

pgsql: Fix the SharedFileSetUnregister API.

redictable. Author: Amit Kapila Reviewed-by: Dilip Kumar Tested-by: Dilip Kumar and Neha Sharma Discussion: https://postgr.es/m/caa4ek1jhlatvcq2ovwa_3s0ih6hx9+kzbq107cxvsswwukh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/

pgsql: Add support for streaming to built-in logical replication.

o we don't have where to send the data anyway. Author: Tomas Vondra, Dilip Kumar and Amit Kapila Reviewed-by: Amit Kapila, Kuntal Ghosh and Ajin Cherian Tested-by: Neha Sharma, Mahendra Singh Thalor and Ajin Cherian Discussion: https://postgr.es/m/688b0b7f-2f6c-d827-c27b-216a8e3ea...@2ndquadr

pgsql: Fix inline marking introduced in commit 464824323e.

Fix inline marking introduced in commit 464824323e. Forgot to add inline marking in changes_filename() declaration. In the passing, add inline marking for a similar function subxact_filename(). Reported-By: Nathan Bossart Discussion: https://postgr.es/m/e98fbe8f-b878-480d-a728-a60c6eed3...@amazo

pgsql: Add additional tests to test streaming of in-progress transactio

Add additional tests to test streaming of in-progress transactions. This covers the functionality tests for streaming in-progress subtransactions, streaming transactions containing rollback to savepoints, and streaming transactions having DDLs. Author: Tomas Vondra, Amit Kapila and Dilip Kumar

Re: pgsql: Implement streaming mode in ReorderBuffer.

On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > Amit Kapila writes: > > Implement streaming mode in ReorderBuffer. > > Looks like this test is somewhat unstable still: > > Thanks for pointing out. I'll analyze and share my findings. -- With Regards, Amit Kapila.

Re: pgsql: Implement streaming mode in ReorderBuffer.

On Thu, Sep 10, 2020 at 9:18 AM Amit Kapila wrote: > > On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > Implement streaming mode in ReorderBuffer. > > > > Looks like this test is somewhat unstable still: > > >

pgsql: Skip empty transaction stream in test_decoding.

uses the option 'skip-empty-xacts'. Diagnosed-By: Amit Kapila Author: Dilip Kumar Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAA4eK1+OqgFNZkf7=ete_y5ntjgdk3t0wcdkd4sot_u1hys...@mail.gmail.com Branch -- master Details --- https://git.pos

pgsql: Remove unused function declaration in logicalproto.h.

Remove unused function declaration in logicalproto.h. In the passing, fix a typo in pgoutput.c. Reported-by: Tomas Vondra Author: Tomas Vondra Reviewed-by: Dilip Kumar Discussion: https://postgr.es/m/20200909084353.pncuclpbwlr7vylh@development Branch -- master Details --- https://git.po

pgsql: Fix inconsistency in determining the timestamp of the db statfil

re is no user reported issue and it is not clear if there is any impact of this on actual application so decided not to backpatch. Reported-by: Amit Kapila Author: Amit Kapila Reviewed-by: Sawada Masahiko, Magnus Hagander and Alvaro Herrera Discussion: https://postgr.es/m/caa4ek1j3otjkyvq6v7k

pgsql: Fix initialization of RelationSyncEntry for streaming transactio

MemoryContext switch for creating a RelationSyncEntry in dynahash. Diagnosed-by: Amit Kapila and Tom Lane Author: Amit Kapila Reviewed-by: Tom Lane and Dilip Kumar Discussion: https://postgr.es/m/904373.1600033...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Update parallel BTree scan state when the scan keys can't be sat

ize blocks at the same time for different scan keys. We missed to update this state when we discovered that the scan keys can't be satisfied. Author: James Hunter Reviewed-by: Amit Kapila Tested-by: Justin Pryzby Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/424

pgsql: Update parallel BTree scan state when the scan keys can't be sat

ize blocks at the same time for different scan keys. We missed to update this state when we discovered that the scan keys can't be satisfied. Author: James Hunter Reviewed-by: Amit Kapila Tested-by: Justin Pryzby Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/424

pgsql: Update parallel BTree scan state when the scan keys can't be sat

ize blocks at the same time for different scan keys. We missed to update this state when we discovered that the scan keys can't be satisfied. Author: James Hunter Reviewed-by: Amit Kapila Tested-by: Justin Pryzby Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/424

pgsql: Update parallel BTree scan state when the scan keys can't be sat

ize blocks at the same time for different scan keys. We missed to update this state when we discovered that the scan keys can't be satisfied. Author: James Hunter Reviewed-by: Amit Kapila Tested-by: Justin Pryzby Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/424

pgsql: Update parallel BTree scan state when the scan keys can't be sat

ize blocks at the same time for different scan keys. We missed to update this state when we discovered that the scan keys can't be satisfied. Author: James Hunter Reviewed-by: Amit Kapila Tested-by: Justin Pryzby Backpatch-through: 10, where it was introduced Discussion: https://postgr.es/m/424

pgsql: Fix comments in heapam.c.

Fix comments in heapam.c. After commits 85f6b49c2c and 3ba59ccc89, we can allow parallel inserts which was earlier not possible as parallel group members won't conflict for relation extension and page lock. In those commits, we forgot to update comments at few places. Author: Amit K

pgsql: Fix comments in heapam.c.

Fix comments in heapam.c. After commits 85f6b49c2c and 3ba59ccc89, we can allow parallel inserts which was earlier not possible as parallel group members won't conflict for relation extension and page lock. In those commits, we forgot to update comments at few places. Author: Amit K

pgsql: Update file header comments for logical/relation.c.

Update file header comments for logical/relation.c. Author: Amit Langote Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/ca+hiwqe20ozoix13jycealptf_smjarzwtbfe5snd6zz+iu...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix the logical replication from HEAD to lower versions.

server version. Reported-by: Ashutosh Sharma Author: Dilip Kumar Reviewed-by: Ashutosh Sharma and Amit Kapila Discussion: https://postgr.es/m/CAE9k0P=9OpXcNrcU5Gsvd5MZ8GFpiN833vNHzX6Uc=8+h1f...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Display the names of missing columns in error during logical rep

display missing column names which makes an error to be more informative to the user. We have decided not to backpatch this commit as this is a minor usability improvement and no user has reported this. Reported-by: Bharath Rupireddy Author: Bharath Rupireddy Reviewed-by: Kyotaro Horiguchi and Amit Ka

pgsql: Track statistics for spilling of changes from ReorderBuffer.

. Users can pass NULL in pg_stat_reset_replication_slot to reset stats of all the slots. This commit extends the statistics collector to track this information about slots. Author: Sawada Masahiko and Amit Kapila Reviewed-by: Amit Kapila and Dilip Kumar Discussion: https://postgr.es/m/ca

pgsql: Fix typos in logical.c and reorderbuffer.c.

Fix typos in logical.c and reorderbuffer.c. Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/CAA4eK1K6zTpuqf_d7wXCBjo_EF0_B6Fz3Ecp71Vq18t=wg-...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f13f2e484172a1c865cd067796cee3568467dd51 Mo

pgsql: Add tests for logical replication spilled stats.

Add tests for logical replication spilled stats. Commit 9868167500 added a mechanism to track statistics corresponding to the spilling of changes from ReorderBuffer but didn't add any tests. Author: Amit Kapila and Sawada Masahiko Discussion: https://postgr.es

Re: pgsql: Add tests for logical replication spilled stats.

On Tue, Oct 13, 2020 at 8:32 AM Amit Kapila wrote: > > Add tests for logical replication spilled stats. > It seems these tests are not stable. I see failure in one of the BF [1]. I am analyzing it and started a discussion on the pgsql-hackers thread. [1] - https://buildfarm.postgresq

pgsql: Fix the unstable output of tests added by commit 8fccf75834.

transaction. So let's not try to verify the exact count. Author: Amit Kapila Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/ca+fd4k5_ppayrtdro2pbttoe0ehqpbvuqmcr8ic39utnmr4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Execute invalidation messages for each XLOG_XACT_INVALIDATIONS m

transaction containing truncation of a table with 1000 partitions would be finished in 1s whereas before this patch it used to take 4-5 minutes. Author: Dilip Kumar Reviewed-by: Amit Kapila and Keisuke Kuroda Discussion: https://postgr.es/m/candwggkyveetxjxjqha6rl3akshmsqyfry6bk+nqhawjyw8

pgsql: Change the docs for PARALLEL option of Vacuum.

Change the docs for PARALLEL option of Vacuum. The rules to choose the number of parallel workers to perform parallel vacuum operation were not clearly specified. Reported-by: Peter Eisentraut Author: Amit Kapila Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m

pgsql: Change the docs for PARALLEL option of Vacuum.

Change the docs for PARALLEL option of Vacuum. The rules to choose the number of parallel workers to perform parallel vacuum operation were not clearly specified. Reported-by: Peter Eisentraut Author: Amit Kapila Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m

Re: pgsql: Change the docs for PARALLEL option of Vacuum.

On Mon, Oct 19, 2020 at 8:13 PM Tom Lane wrote: > > Amit Kapila writes: > > Change the docs for PARALLEL option of Vacuum. > > The buildfarm says you broke the docs build in v13. > oops, I'll look into it. -- With Regards, Amit Kapila.

pgsql: Fix typo in commit 99ae342fc4.

Fix typo in commit 99ae342fc4. In v13, the id for max_parallel_maintenance_workers is defined differently as compared to HEAD in docs, so adjust the docs accordingly. Reported-by: Magnus Hagander and Tom Lane Discussion: https://postgr.es/m/CABUevEyAFQZ_jvjY_KtRUWbci4YMyQC1QAMzDQAbLs=xco3...@mai

pgsql: Change the attribute name in pg_stat_replication_slots view.

ute. In the passing, fix the typo in one of the macros in the related code. Bump the catversion as we have modified the name in the catalog as well. Reported-by: Noriyoshi Shinoda Author: Noriyoshi Shinoda Reviewed-by: Sawada Masahiko and Amit Kapila Discussion: ht

Re: pgsql: Change the docs for PARALLEL option of Vacuum.

On Tue, Oct 20, 2020 at 7:47 AM Amit Kapila wrote: > > On Mon, Oct 19, 2020 at 8:13 PM Tom Lane wrote: > > > > Amit Kapila writes: > > > Change the docs for PARALLEL option of Vacuum. > > > > The buildfarm says you broke the docs build in v13. > &g

pgsql: Update description of spilled counters in pg_stat_replication_sl

Update description of spilled counters in pg_stat_replication_slots view. This is to make the description of spilled counters clear. Author: Amit Kapila Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/ca+fd4k5_ppayrtdro2pbttoe0ehqpbvuqmcr8ic39utnmr4...@mail.gmail.com Branch

pgsql: Minor improvements in description of spilled counters in pg_stat

Minor improvements in description of spilled counters in pg_stat_replication_slots view. Per a suggestion by Justin Pryzby. Discussion: https://postgr.es/m/ca+fd4k5_ppayrtdro2pbttoe0ehqpbvuqmcr8ic39utnmr4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/com

pgsql: Track statistics for streaming of changes from ReorderBuffer.

catversion as we have added new columns in the catalog entry. Author: Ajin Cherian and Amit Kapila Reviewed-by: Sawada Masahiko and Dilip Kumar Discussion: https://postgr.es/m/caa4ek1+chpeomlzgsoky-d31qev19amecnieaietpqugefh...@mail.gmail.com Branch -- master Details --- https

pgsql: Use Enum for top level logical replication message types.

ndres Freund, Peter Smith and Amit Kapila Discussion: https://postgr.es/m/caexhw5upzq7l0oad_enyvaiymopgkraojpe+zy5-obdcvt6...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/644f0d7cc9c2cb270746f2024c706554e0fbec82 Modified Files -- src/ba

pgsql: Fix typos.

Fix typos. Author: Hou Zhijie Discussion: https://postgr.es/m/855a9421839d402b8b351d273c89a8f8@G08CNEXMBPEKD05.g08.fujitsu.local Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8c2d8f6cc4848cf9276dff445bb0f2f664083eca Modified Files -- src/backend/stor

pgsql: Use strlcpy instead of memcpy for copying the slot name in pgsta

Masahiko and Amit Kapila Discussion: https://postgr.es/m/20201104.175523.1704166915688949637.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4f841ce3f7f4d429a3a275f82745d63c78cde4b2 Modified Files -- src/backend/postmaster/pgstat.c

Re: pgsql: Skip empty transaction stream in test_decoding.

On Mon, Nov 9, 2020 at 7:11 AM Michael Paquier wrote: > > Hi Amit, > > On Fri, Sep 11, 2020 at 04:43:59AM +, Amit Kapila wrote: > > Skip empty transaction stream in test_decoding. > > > > We were decoding empty transactions via streaming APIs added in commit >

Re: pgsql: Skip empty transaction stream in test_decoding.

On Mon, Nov 9, 2020 at 8:40 AM Amit Kapila wrote: > > On Mon, Nov 9, 2020 at 7:11 AM Michael Paquier wrote: > > > > /home/pgbfarm/buildroot/HEAD/pgsql.build/contrib/test_decoding/output_iso/results/concurrent_stream.out > > 2020-11-08 12:31:10 -0700 > > @@ -13,7 +1

pgsql: Fix 'skip-empty-xacts' option in test_decoding for streaming mod

cal decoding context because that might get changed due to some other transactions and lead to wrong answers for 'skip-empty-xacts' option. We decided to keep each transaction's write status in the ReorderBufferTxn to avoid interleaved streams changing the status of some unrelated trans

pgsql: Remove obsolete comment atop ri_PlanCheck.

Remove obsolete comment atop ri_PlanCheck. Commit 5b7ba75f7f removed the unused parameter but forgot to update the nearby comments. Author: Li Japin Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/0e2f62a2-b2f1-4052-83ae-f0bec8a75...@hotmail.com Branch -- REL_1

pgsql: Remove obsolete comment atop ri_PlanCheck.

Remove obsolete comment atop ri_PlanCheck. Commit 5b7ba75f7f removed the unused parameter but forgot to update the nearby comments. Author: Li Japin Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/0e2f62a2-b2f1-4052-83ae-f0bec8a75...@hotmail.com Branch -- maste

pgsql: Use Enums for logical replication message types at more places.

Use Enums for logical replication message types at more places. Commit 644f0d7cc9 added logical replication message type enums to use instead of character literals but some char substitutions were overlooked. Author: Peter Smith Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAHut

pgsql: Fix replication of in-progress transactions in tablesync worker.

-by: Amit Kapila and Peter Smith Tested-by: Peter Smith Discussion: https://postgr.es/m/CAHut+Pt4PyKQCwqzQ=EFF=bpkkjd7xkt_s23f6l20ayqnxg...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0926e96c493443644ba8e96b5d96d013a9ffaf64 Modified Files

pgsql: Remove incorrect assertion in reorderbuffer.c.

atop ReorderBufferResetTXN to mention the case when we need to continue streaming after getting an error. Author: Amit Kapila Reviewed-by: Dilip Kumar Discussion: https://postgr.es/m/caa4ek1kooh0byboyyy40nbcc7fe812trwta+wy3jqf7wqwz...@mail.gmail.com Branch -- master Details ---

pgsql: Update comment atop of ReorderBufferQueueMessage().

message as well. Ashutosh Bapat, rephrased by Amit Kapila Discussion: https://postgr.es/m/cageowwttznzhoi8bj0wfao1sigi-yeh6wqh1oaz4drktj6h...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20659fd8e5ecb3bcb3e337581c4bd7123d490ddc Modified Files

pgsql: Extend the output plugin API to allow decoding of prepared xacts

oding' plugin, implementing these new methods. This commit simply adds these new APIs and the upcoming patch to "allow the decoding at prepare time in ReorderBuffer" will use these APIs. Author: Ajin Cherian and Amit Kapila based on previous work by Nikhil Sontakke and Stas Kelvi

pgsql: Allow decoding at prepare time in ReorderBuffer.

we rollback the changes when rollback prepared is encountered. Author: Ajin Cherian and Amit Kapila based on previous work by Nikhil Sontakke and Stas Kelvich Reviewed-by: Amit Kapila, Peter Smith, Sawada Masahiko, Arseny Sher, and Dilip Kumar Tested-by: Takamichi Osumi Discussion: https

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

on return row and query-specified return row do not match > | DETAIL: Returned row contains 19 attributes, but query expects 18. > ` > > The attached patch fixes it for me. > Your patch looks correct to me. I can reproduce the problem and verified that patch fixes the problem

Re: pgsql: Extend pg_publication_tables to display column list and row filt

On Sun, May 29, 2022 at 2:00 AM Andres Freund wrote: > > Hi, > > On 2022-05-19 08:59:13 +0530, Amit Kapila wrote: > > On Thu, May 19, 2022 at 8:40 AM Tom Lane wrote: > > > > > > Amit Kapila writes: > > > > Extend pg_publication_tables to display

pgsql: Fix typo in hash README.

Fix typo in hash README. Author: Peter Smith Discussion: https://postgr.es/m/CAHut+Pu-V22PiJF2ym9_NVZe-+qnycfyEX24dZm=7urwhdh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0a050ee000b6783ac4b78e9eadb47a4e72912672 Modified Files -- s

<    2   3   4   5   6   7   8   9   10   11   >