Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Álvaro Herrera
On 2025-Aug-19, Andres Freund wrote: > On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote: > > That said, autoconf does not report the issue, and that's because > > test/modules > > is missing in src/Makefile. Is there any reasons for that? If not, the > > attached > > fix it. > > That can't

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Tom Lane
=?utf-8?Q?=C3=81lvaro?= Herrera writes: > Yeah, I'm not on board with making changes to the makefiles, because > AFAIR the current arrangement is purposefully what is is. I did > discover that my build script does "make install ; make -C contrib > install", which means src/test/modules is not bui

pgsql: Fix misspelling of "tranche" in dsa.h.

2025-08-19 Thread Nathan Bossart
Fix misspelling of "tranche" in dsa.h. Oversight in commit bb952c8c8b. Discussion: https://postgr.es/m/aKOWzsCPgrsoEG1Q%40nathan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c6abf24ebfecf0ef4f7d21750e198959b8b61586 Modified Files -- src/include/util

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Andres Freund
Hi, On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote: > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > > After these two changes, a lot of > > files can stop including dbcommands.h. This seems a nice cleanup to me, > > and passes headerscheck. > > meson does report: > > .

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
Hi, On Tue, Aug 19, 2025 at 10:28:29AM -0400, Andres Freund wrote: > Hi, > > On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote: > > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > > > After these two changes, a lot of > > > files can stop including dbcommands.h. This seems a

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Andres Freund
Hi, On 2025-08-19 15:08:08 +, Bertrand Drouvot wrote: > Hi, > > On Tue, Aug 19, 2025 at 10:28:29AM -0400, Andres Freund wrote: > > Hi, > > > > On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote: > > > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > > > > After these two c

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
Hi, On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote: > On 2025-Aug-18, Tom Lane wrote: > > > Michael Paquier writes: > > > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote: > > >> Couldn't this have removed some #include-s from multixact.c? > > > > > Right. funcapi.h and

pgsql: doc: Improve documentation discoverability for pgoutput.

2025-08-19 Thread Fujii Masao
doc: Improve documentation discoverability for pgoutput. Previously, the documentation for pgoutput was located in the section on the logical streaming replication protocol, and there was no index entry for it. As a result, users had difficulty finding information about pgoutput. This commit move

pgsql: doc: Improve pgoutput documentation.

2025-08-19 Thread Fujii Masao
doc: Improve pgoutput documentation. This commit updates the pgoutput documentation with the following changes: - Specify the data type for each pgoutput option. - Clarify the relationship between proto_version and options such as streaming and two_phase. - Add a note on the use of pg_logical_

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Álvaro Herrera
On 2025-Aug-18, Tom Lane wrote: > Michael Paquier writes: > > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote: > >> Couldn't this have removed some #include-s from multixact.c? > > > Right. funcapi.h and fmgrprotos.h are direct dependencies, but > > looking closer it is also possible t

pgsql: Fix comment for MAX_SIMUL_LWLOCKS.

2025-08-19 Thread Nathan Bossart
Fix comment for MAX_SIMUL_LWLOCKS. This comment mentions that pg_buffercache locks all buffer partitions simultaneously, but it hasn't done so since v10. Oversight in commit 6e654546fb. Reviewed-by: Andres Freund Discussion: https://postgr.es/m/aKTuAHVEuYCUmmIy%40nathan Branch -- master D

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

pgsql: Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions.

2025-08-19 Thread Masahiko Sawada
Add CHECK_FOR_INTERRUPTS in contrib/pg_buffercache functions. This commit adds CHECK_FOR_INTERRUPTS to loops iterating over shared buffers in several pg_buffercache functions, allowing them to be interrupted during long-running operations. Backpatch to all supported versions. Add CHECK_FOR_INTERR

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
Hi, On Tue, Aug 19, 2025 at 05:17:52PM +0200, Álvaro Herrera wrote: > > Yeah, I'm not on board with making changes to the makefiles, because > AFAIR the current arrangement is purposefully what is is. It's coming from 22dfd116a127 and looking at [1] it looks like that the idea at that time was t

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-19 Thread Bertrand Drouvot
Hi, On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote: > =?utf-8?Q?=C3=81lvaro?= Herrera writes: > > Yeah, I'm not on board with making changes to the makefiles, because > > AFAIR the current arrangement is purposefully what is is. I did > > discover that my build script does "make instal

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: Fix assertion failure with replication slot release in single-us

2025-08-19 Thread Michael Paquier
Fix assertion failure with replication slot release in single-user mode Some replication slot manipulations (logical decoding via SQL, advancing) were failing an assertion when releasing a slot in single-user mode, because active_pid was not set in a ReplicationSlot when its slot is acquired. Rep

pgsql: vacuumdb: Make vacuumdb --analyze-only process partitioned table

2025-08-19 Thread Fujii Masao
vacuumdb: Make vacuumdb --analyze-only process partitioned tables. vacuumdb should follow the behavior of the underlying VACUUM and ANALYZE commands. When --analyze-only is used, it ought to analyze regular tables, materialized views, and partitioned tables, just as ANALYZE (with no explicit targe