Bertrand Drouvot writes:
> On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote:
>> I think "make world-bin"
>> or "make install-world" are the accepted targets for building everything.
> From what I can see, only:
> check-world:
> checkprep:
> installcheck-world:
> build src/test/modules.
I
On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote:
> Hmm, don't you find strange that dbcommands.h is still included there?
> I wondered about that and found out that we have get_database_name()
> declared there. It sort-of makes sense, because it was originally done
> by scanning pg_
Hi,
On Tue, Aug 19, 2025 at 05:17:52PM +0200, Álvaro Herrera wrote:
>
> Yeah, I'm not on board with making changes to the makefiles, because
> AFAIR the current arrangement is purposefully what is is.
It's coming from 22dfd116a127 and looking at [1] it looks like that the idea
at that time was t
Hi,
On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera writes:
> > Yeah, I'm not on board with making changes to the makefiles, because
> > AFAIR the current arrangement is purposefully what is is. I did
> > discover that my build script does "make instal
=?utf-8?Q?=C3=81lvaro?= Herrera writes:
> Yeah, I'm not on board with making changes to the makefiles, because
> AFAIR the current arrangement is purposefully what is is. I did
> discover that my build script does "make install ; make -C contrib
> install", which means src/test/modules is not bui
On 2025-Aug-19, Andres Freund wrote:
> On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote:
> > That said, autoconf does not report the issue, and that's because
> > test/modules
> > is missing in src/Makefile. Is there any reasons for that? If not, the
> > attached
> > fix it.
>
> That can't
Hi,
On 2025-08-19 15:08:08 +, Bertrand Drouvot wrote:
> Hi,
>
> On Tue, Aug 19, 2025 at 10:28:29AM -0400, Andres Freund wrote:
> > Hi,
> >
> > On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote:
> > > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote:
> > > > After these two c
Hi,
On Tue, Aug 19, 2025 at 10:28:29AM -0400, Andres Freund wrote:
> Hi,
>
> On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote:
> > On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote:
> > > After these two changes, a lot of
> > > files can stop including dbcommands.h. This seems a
Hi,
On 2025-08-19 14:01:52 +, Bertrand Drouvot wrote:
> On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote:
> > After these two changes, a lot of
> > files can stop including dbcommands.h. This seems a nice cleanup to me,
> > and passes headerscheck.
>
> meson does report:
>
> .
Hi,
On Tue, Aug 19, 2025 at 12:31:14PM +0200, Álvaro Herrera wrote:
> On 2025-Aug-18, Tom Lane wrote:
>
> > Michael Paquier writes:
> > > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> > >> Couldn't this have removed some #include-s from multixact.c?
> >
> > > Right. funcapi.h and
On 2025-Aug-18, Tom Lane wrote:
> Michael Paquier writes:
> > On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> >> Couldn't this have removed some #include-s from multixact.c?
>
> > Right. funcapi.h and fmgrprotos.h are direct dependencies, but
> > looking closer it is also possible t
Michael Paquier writes:
> On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
>> Couldn't this have removed some #include-s from multixact.c?
> Right. funcapi.h and fmgrprotos.h are direct dependencies, but
> looking closer it is also possible to remove four more of them.
Sounds good!
On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> Michael Paquier writes:
> > Move SQL-callable code related to multixacts into its own file
>
> Couldn't this have removed some #include-s from multixact.c?
Right. funcapi.h and fmgrprotos.h are direct dependencies, but
looking closer i
Michael Paquier writes:
> Move SQL-callable code related to multixacts into its own file
Couldn't this have removed some #include-s from multixact.c?
regards, tom lane
Move SQL-callable code related to multixacts into its own file
A patch is under discussion to add more SQL capabilities related to
multixacts, and this move avoids bloating the file more than necessary.
This affects pg_get_multixact_members(). A side effect of this move is
the requirement to add
15 matches
Mail list logo
