Re: pgsql: Make WAL segment size configurable at initdb time.

2018-11-09 Thread David Steele
On 11/9/18 10:30 PM, Andres Freund wrote: > On 2018-11-09 21:45:18 -0500, David Steele wrote: >> On 10/5/18 1:03 PM, David Steele wrote: >>> >>> So, while the WAL segment size used to be expressed in terms of 8K pages >>> it is now expressed in terms of absolute bytes.  This seemed to me to be >>>

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-11-09 Thread Andres Freund
On 2018-11-09 21:45:18 -0500, David Steele wrote: > On 10/5/18 1:03 PM, David Steele wrote: > > Hi Andres, > > > > On 10/5/18 5:54 PM, Andres Freund wrote: > >> On 2018-09-20 11:48:08 -0400, David Steele wrote: > >> > >>> diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml > >>> index

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-11-09 Thread David Steele
On 10/5/18 1:03 PM, David Steele wrote: > Hi Andres, > > On 10/5/18 5:54 PM, Andres Freund wrote: >> On 2018-09-20 11:48:08 -0400, David Steele wrote: >> >>> diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml >>> index e1073ac6d3..3bfd172441 100644 >>> --- a/doc/src/sgml/config.sgml

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-10-05 Thread David Steele
Hi Andres, On 10/5/18 5:54 PM, Andres Freund wrote: On 2018-09-20 11:48:08 -0400, David Steele wrote: diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index e1073ac6d3..3bfd172441 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -8440,10 +8440,8 @@ dynami

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-10-05 Thread Andres Freund
On 2018-09-20 11:48:08 -0400, David Steele wrote: > Hi Andres, > > On 9/20/17 1:04 AM, Andres Freund wrote: > > > > Make WAL segment size configurable at initdb time. > > <...> > > > https://git.postgresql.org/pg/commitdiff/fc49e24fa69a15efacd5b8958115ed9c43c48f9a > It appears that fc49e24f miss

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-10-05 Thread David Steele
On 9/21/18 12:44 PM, David Steele wrote: On 9/21/18 12:53 AM, Michael Paquier wrote: On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote: 16*M*B, right? If so, that's normal - pg_settings just reports the values in the underlying unit - which is XLOG_BLCKSZ, compile-time defaulting t

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-21 Thread David Steele
On 9/21/18 12:53 AM, Michael Paquier wrote: > On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote: >> 16*M*B, right? If so, that's normal - pg_settings just reports the >> values in the underlying unit - which is XLOG_BLCKSZ, compile-time >> defaulting to 8KB. 8192 * 2048 = 16MB. That's

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-20 Thread Michael Paquier
On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote: > 16*M*B, right? If so, that's normal - pg_settings just reports the > values in the underlying unit - which is XLOG_BLCKSZ, compile-time > defaulting to 8KB. 8192 * 2048 = 16MB. That's the same in various other > settings. Would it

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-20 Thread Andres Freund
On 2018-09-20 21:14:51 -0400, David Steele wrote: > On 9/20/18 7:59 PM, Michael Paquier wrote: > > On Thu, Sep 20, 2018 at 11:48:08AM -0400, David Steele wrote: > >> > >> > >> > >> -Reports the number of blocks (pages) in a WAL segment file. > >> -The total

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-20 Thread David Steele
On 9/20/18 7:59 PM, Michael Paquier wrote: > On Thu, Sep 20, 2018 at 11:48:08AM -0400, David Steele wrote: >> >> >> >> -Reports the number of blocks (pages) in a WAL segment file. >> -The total size of a WAL segment file in bytes is equal to >> -wal_

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-20 Thread Michael Paquier
On Thu, Sep 20, 2018 at 11:48:08AM -0400, David Steele wrote: > > > > -Reports the number of blocks (pages) in a WAL segment file. > -The total size of a WAL segment file in bytes is equal to > -wal_segment_size multiplied by > wal_block_size; > -

Re: pgsql: Make WAL segment size configurable at initdb time.

2018-09-20 Thread David Steele
Hi Andres, On 9/20/17 1:04 AM, Andres Freund wrote: > > Make WAL segment size configurable at initdb time. <...> > https://git.postgresql.org/pg/commitdiff/fc49e24fa69a15efacd5b8958115ed9c43c48f9a It appears that fc49e24f missed updating the runtime config presets documentation. Patch attached.