Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-13 Thread Tom Lane
Thomas Munro writes: > On Tue, Nov 13, 2018 at 6:54 PM Tom Lane wrote: >> Hm, what warnings? > Apple ships OpenLDAP headers that tell you to ditch it and use Apple > OpenDirectory Framework: Oh, that. I just use -Wno-deprecated-declarations. A bigger issue to my mind is that configure bleats

Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Thomas Munro
On Tue, Nov 13, 2018 at 6:54 PM Tom Lane wrote: > Thomas Munro writes: > > Thanks, fixing. Embarassingly, I had turned off -Werror for this > > because my Mac spews strange warnings when you use OpenLDAP, a problem > > to which there must be a better solution. > > Hm, what warnings? Apple ships

Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Tom Lane
Thomas Munro writes: > Thanks, fixing. Embarassingly, I had turned off -Werror for this > because my Mac spews strange warnings when you use OpenLDAP, a problem > to which there must be a better solution. Hm, what warnings? regards, tom lane

Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Thomas Munro
On Tue, Nov 13, 2018 at 6:37 PM Tom Lane wrote: > Thomas Munro writes: > > Fix handling of HBA ldapserver with multiple hostnames. > > longfin thinks this has a problem with const-ness: > > auth.c:2380:10: error: passing 'const char *' to parameter of type 'void *' > discards qualifiers [-Werror

Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Tom Lane
Thomas Munro writes: > Fix handling of HBA ldapserver with multiple hostnames. longfin thinks this has a problem with const-ness: auth.c:2380:10: error: passing 'const char *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]

pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Thomas Munro
Fix handling of HBA ldapserver with multiple hostnames. Commit 35c0754f failed to handle space-separated lists of alternative hostnames in ldapserver, when building a URI for ldap_initialize() (OpenLDAP). Such lists need to be expanded to space-separated URIs. Repair. Back-patch to 11, to fix b

pgsql: Fix handling of HBA ldapserver with multiple hostnames.

2018-11-12 Thread Thomas Munro
Fix handling of HBA ldapserver with multiple hostnames. Commit 35c0754f failed to handle space-separated lists of alternative hostnames in ldapserver, when building a URI for ldap_initialize() (OpenLDAP). Such lists need to be expanded to space-separated URIs. Repair. Back-patch to 11, to fix b