Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2018-02-07 Thread Robert Haas
On Tue, Feb 6, 2018 at 4:42 PM, Thomas Munro wrote: > On Wed, Nov 8, 2017 at 6:57 AM, Simon Riggs wrote: >> Remove secondary checkpoint > > I think this comment in xlog.c was missed: > > - /* > -* Get the last valid checkpoint record. If the > latest one according >

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2018-02-06 Thread Thomas Munro
On Wed, Nov 8, 2017 at 6:57 AM, Simon Riggs wrote: > Remove secondary checkpoint I think this comment in xlog.c was missed: - /* -* Get the last valid checkpoint record. If the latest one according -* to pg_control is broken, try the next-to-last on

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Simon Riggs
On 20 November 2017 at 15:55, Andres Freund wrote: > On 2017-11-20 15:50:40 -0500, Simon Riggs wrote: >> On 20 November 2017 at 08:38, Amit Kapila wrote: >> > Your patch looks correct to me. I can reproduce the problem and >> > verified that patch fixes the problem. It is better to track this i

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Andres Freund
On 2017-11-20 15:50:40 -0500, Simon Riggs wrote: > On 20 November 2017 at 08:38, Amit Kapila wrote: > > Your patch looks correct to me. I can reproduce the problem and > > verified that patch fixes the problem. It is better to track this in > > CF if not already tracked. > > What email and patc

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Simon Riggs
On 20 November 2017 at 08:38, Amit Kapila wrote: > On Sat, Nov 11, 2017 at 10:58 PM, Andreas Seltenreich > wrote: >> Hi, >> >> sqlsmith doesn't like commit 4b0d28de06: >> >> , >> | regression=> select * from pg_control_checkpoint(); >> | server closed the connection unexpectedly >> | TRAP: Fa

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2017-11-20 Thread Amit Kapila
On Sat, Nov 11, 2017 at 10:58 PM, Andreas Seltenreich wrote: > Hi, > > sqlsmith doesn't like commit 4b0d28de06: > > , > | regression=> select * from pg_control_checkpoint(); > | server closed the connection unexpectedly > | TRAP: FailedAssertion("!((atti->attalign) == 's')", File: "heaptuple.c