pgsql: Translation updates

2025-09-22 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 9e968777f6022b6347cd08ae6bdc324e49e622ec Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9bbcec6030a2744d83311370ec92213fbd76e514 Modified Files --

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-20 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: Add list of acknowledgments to release notes

2025-09-19 Thread Peter Eisentraut
Add list of acknowledgments to release notes Author: Corey Huinker Discussion: https://www.postgresql.org/message-id/CADkLM%3DfGrtKiQMv6GSoxyghtTxB_6b1FQUB7fhQG00%3DLhuizPg%40mail.gmail.com Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/142885d380533b5ad4e

pgsql: jit: fix build with LLVM-21

2025-09-19 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: Change fmgr.h typedefs to use original names

2025-09-17 Thread Peter Eisentraut
Change fmgr.h typedefs to use original names fmgr.h defined some types such as fmNodePtr which is just Node *, but it made its own types to avoid having to include various header files. With C11, we can now instead typedef the original names without fear of conflicts. Reviewed-by: Tom Lane Revie

pgsql: Fix CREATE TABLE LIKE with not-valid check constraint

2025-09-17 Thread Peter Eisentraut
Fix CREATE TABLE LIKE with not-valid check constraint In CREATE TABLE ... LIKE, any check constraints copied from the source table should be set to valid if they are ENFORCED (the default). Bug introduced in commit ca87c415e2f. Author: jian he Discussion: https://www.postgresql.org/message-id/

pgsql: Move pg_int64 back to postgres_ext.h

2025-09-16 Thread Peter Eisentraut
Move pg_int64 back to postgres_ext.h Fix for commit 3c86223c998. That commit moved the typedef of pg_int64 from postgres_ext.h to libpq-fe.h, because the only remaining place where it might be used is libpq users, and since the type is obsolete, the intent was to limit its scope. The problem is

pgsql: Move pg_int64 back to postgres_ext.h

2025-09-16 Thread Peter Eisentraut
Move pg_int64 back to postgres_ext.h Fix for commit 3c86223c998. That commit moved the typedef of pg_int64 from postgres_ext.h to libpq-fe.h, because the only remaining place where it might be used is libpq users, and since the type is obsolete, the intent was to limit its scope. The problem is

pgsql: Fix incorrect const qualifier

2025-09-15 Thread Peter Eisentraut
Fix incorrect const qualifier Commit 7202d72787d added in passing some const qualifiers, but the one on the postmaster_child_launch() startup_data argument was incorrect, because the function itself modifies the pointed-to data. This is hidden from the compiler because of casts. The qualifiers o

pgsql: Fix incorrect const qualifier

2025-09-15 Thread Peter Eisentraut
Fix incorrect const qualifier Commit 7202d72787d added in passing some const qualifiers, but the one on the postmaster_child_launch() startup_data argument was incorrect, because the function itself modifies the pointed-to data. This is hidden from the compiler because of casts. The qualifiers o

pgsql: Update various forward declarations to use typedef

2025-09-15 Thread Peter Eisentraut
Update various forward declarations to use typedef There are a number of forward declarations that use struct but not the customary typedef, because that could have led to repeat typedefs, which was not allowed. This is now allowed in C11, so we can update these to provide the typedefs as well, s

pgsql: Expand virtual generated columns in constraint expressions

2025-09-15 Thread Peter Eisentraut
Expand virtual generated columns in constraint expressions Virtual generated columns in constraint expressions need to be expanded because the optimizer matches these expressions to qual clauses. Failing to do so can cause us to miss opportunities for constraint exclusion. Author: Richard Guo D

pgsql: Improve ExplainState type handling in header files

2025-09-15 Thread Peter Eisentraut
Improve ExplainState type handling in header files Now that we can have repeat typedefs with C11, we don't need to use "struct ExplainState" anymore but can instead make a typedef where necessary. This doesn't change anything but makes it look nicer. (There are more opportunities for similar cha

pgsql: Expand virtual generated columns in constraint expressions

2025-09-15 Thread Peter Eisentraut
Expand virtual generated columns in constraint expressions Virtual generated columns in constraint expressions need to be expanded because the optimizer matches these expressions to qual clauses. Failing to do so can cause us to miss opportunities for constraint exclusion. Author: Richard Guo D

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-15 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-15 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-15 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-15 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: CREATE STATISTICS: improve misleading error message

2025-09-15 Thread Peter Eisentraut
CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CACJufx

pgsql: Remove hbaPort type

2025-09-15 Thread Peter Eisentraut
Remove hbaPort type This was just a workaround to avoid including the header file that defines the Port type. With C11, we can now just re-define the Port type without the possibility of a conflict. Reviewed-by: Tom Lane Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/f

pgsql: Remove workarounds against repeat typedefs

2025-09-15 Thread Peter Eisentraut
Remove workarounds against repeat typedefs This is allowed in C11, so we don't need the workarounds anymore. Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/10d32190-f31b-40a5-b177-11db55597...@eisentraut.org Branch -- master Details --- https://git.postgre

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- mas

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: jit: fix build with LLVM-21

2025-09-14 Thread Peter Eisentraut
jit: fix build with LLVM-21 LLVM-21 renamed llvm::GlobalValue::getGUID() to getGUIDAssumingExternalLinkage(), so add a version guard. Author: Holger Hoffstätte Discussion: https://www.postgresql.org/message-id/flat/d25e6e4a-d1b4-84d3-2f8a-6c45b975f53d%40applied-asynchrony.com Branch -- REL

pgsql: Some stylistic improvements in toast_save_datum()

2025-09-14 Thread Peter Eisentraut
Some stylistic improvements in toast_save_datum() Move some variables to a smaller scope. Initialize chunk_data before storing a pointer to it; this avoids compiler warnings on clang-21, or respectively us having to work around it by initializing it to zero before the variable is used (as was don

pgsql: Hide duplicate names from extension views

2025-09-14 Thread Peter Eisentraut
Hide duplicate names from extension views If extensions of equal names were installed in different directories in the path, the views pg_available_extensions and pg_available_extension_versions would show all of them, even though only the first one was actually reachable by CREATE EXTENSION. To f

pgsql: Hide duplicate names from extension views

2025-09-14 Thread Peter Eisentraut
Hide duplicate names from extension views If extensions of equal names were installed in different directories in the path, the views pg_available_extensions and pg_available_extension_versions would show all of them, even though only the first one was actually reachable by CREATE EXTENSION. To f

pgsql: Remove stray semicolon at global scope

2025-09-13 Thread Peter Eisentraut
Remove stray semicolon at global scope The Sun Studio compiler complains about an empty declaration here. Note for future historians: This does not mean that this compiler is still of current interest for anyone using PostgreSQL. But we can let this small fix be its parting gift. Reviewed-by:

pgsql: Silence compiler warnings on clang 21

2025-09-11 Thread Peter Eisentraut
Silence compiler warnings on clang 21 Clang 21 shows some new compiler warnings, for example: warning: variable 'dstsize' is uninitialized when passed as a const pointer argument here [-Wuninitialized-const-pointer] The fix is to initialize the variables when they are defined. This is similar

pgsql: Allow redeclaration of typedef yyscan_t

2025-09-11 Thread Peter Eisentraut
Allow redeclaration of typedef yyscan_t This is allowed in C11, so we don't need the workaround guards against it anymore. This effectively reverts commit 382092a0cd2 that put these guards in place. Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/10d32190-f31b-40a5-

pgsql: Improve pgbench definition of yyscan_t

2025-09-11 Thread Peter Eisentraut
Improve pgbench definition of yyscan_t It was defining yyscan_t as a macro while the rest of the code uses a typedef with #ifdef guards around it. The latter is also what the flex generated code uses. So it seems best to make it look like those other places for consistency. The old way also had

pgsql: Remove stray semicolon at global scope

2025-09-11 Thread Peter Eisentraut
Remove stray semicolon at global scope The Sun Studio compiler complains about an empty declaration here. Note for future historians: This does not mean that this compiler is still of current interest for anyone using PostgreSQL. But we can let this small fix be its parting gift. Reviewed-by:

pgsql: Silence compiler warnings on clang 21

2025-09-11 Thread Peter Eisentraut
Silence compiler warnings on clang 21 Clang 21 shows some new compiler warnings, for example: warning: variable 'dstsize' is uninitialized when passed as a const pointer argument here [-Wuninitialized-const-pointer] The fix is to initialize the variables when they are defined. This is similar

pgsql: Default to log_lock_waits=on

2025-09-11 Thread Peter Eisentraut
Default to log_lock_waits=on If someone is stuck behind a lock for more than a second, that is almost always a problem that is worth a log entry. Author: Laurenz Albe Reviewed-By: Michael Banck Reviewed-By: Robert Haas Reviewed-By: Christoph Berg Reviewed-By: Stephen Frost Discussion: https

pgsql: Silence compiler warnings on clang 21

2025-09-11 Thread Peter Eisentraut
Silence compiler warnings on clang 21 Clang 21 shows some new compiler warnings, for example: warning: variable 'dstsize' is uninitialized when passed as a const pointer argument here [-Wuninitialized-const-pointer] The fix is to initialize the variables when they are defined. This is similar

pgsql: Remove traces of support for Sun Studio compiler

2025-09-11 Thread Peter Eisentraut
Remove traces of support for Sun Studio compiler Per discussion, this compiler suite is no longer maintained, and it has not been able to compile PostgreSQL since at least PostgreSQL 17. This removes all the remaining support code for this compiler. Note that the Solaris operating system continu

pgsql: Silence compiler warnings on clang 21

2025-09-11 Thread Peter Eisentraut
Silence compiler warnings on clang 21 Clang 21 shows some new compiler warnings, for example: warning: variable 'dstsize' is uninitialized when passed as a const pointer argument here [-Wuninitialized-const-pointer] The fix is to initialize the variables when they are defined. This is similar

pgsql: Remove checks for no longer supported GCC versions

2025-09-11 Thread Peter Eisentraut
Remove checks for no longer supported GCC versions Since commit f5e0186f865 (Raise C requirement to C11), we effectively require at least GCC version 4.7, so checks for older versions can be removed. Reviewed-by: Andres Freund Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/messag

pgsql: Fix typo in comment

2025-09-11 Thread Peter Eisentraut
Fix typo in comment Author: Alexandra Wang Discussion: https://www.postgresql.org/message-id/CAK98qZ0whQ%3Dc%2BJGXbGSEBxCtLgy6sf-YGYqsKTAGsS-wt0wj%2BA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/81a61fde84ffc74f7b3c7854ed4193cc4d31f78b Modifi

pgsql: Remove stray semicolon at global scope

2025-09-11 Thread Peter Eisentraut
Remove stray semicolon at global scope The Sun Studio compiler complains about an empty declaration here. Note for future historians: This does not mean that this compiler is still of current interest for anyone using PostgreSQL. But we can let this small fix be its parting gift. Reviewed-by:

pgsql: Fix CREATE TABLE LIKE with not-valid check constraint

2025-09-10 Thread Peter Eisentraut
Fix CREATE TABLE LIKE with not-valid check constraint In CREATE TABLE ... LIKE, any check constraints copied from the source table should be set to valid if they are ENFORCED (the default). Bug introduced in commit ca87c415e2f. Author: jian he Discussion: https://www.postgresql.org/message-id/

pgsql: Clean up newly added guc_tables.inc.c

2025-09-04 Thread Peter Eisentraut
Clean up newly added guc_tables.inc.c There was a missing makefile rule to clean up the guc_tables.inc.c symlink in src/include/. Oversight in commit 63599896545. Author: Nathan Bossart Discussion: https://www.postgresql.org/message-id/flat/dae6fe89-1e0c-4c3f-8d92-19d23374fb10%40eisentraut.org

pgsql: Fix mistake in new GUC tables source

2025-09-03 Thread Peter Eisentraut
Fix mistake in new GUC tables source Commit 63599896545 had it so that the parameter "debug_discard_caches" did not exist unless DISCARD_CACHES_ENABLED was defined (typically via enabling asserts). This was a mistake, it did not correspond to the prior setup. Several tests use this parameter, so

pgsql: Generate GUC tables from .dat file

2025-09-03 Thread Peter Eisentraut
Generate GUC tables from .dat file Store the information in guc_tables.c in a .dat file similar to the catalog data in src/include/catalog/, and generate a part of guc_tables.c from that. The goal is to make it easier to edit that information, and to be able to make changes to the downstream data

pgsql: Translation updates

2025-09-01 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 0a0b90588b76075d4deb646a8c75cb6e9fd062f2 Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/83fa88945929df3931413503bbf3c9ae98457f1a Modified Files --

pgsql: doc PG 18 relnotes: Add migration note about tsearch

2025-08-29 Thread Peter Eisentraut
doc PG 18 relnotes: Add migration note about tsearch Document the small migration hazard introduced in commit fb1a18810f0, as suggested there. Reviewed-by: Daniel Verite Reviewed-by: Heikki Linnakangas Discussion: https://www.postgresql.org/message-id/flat/653f3b84-fc87-45a7-9a0c-bfb4fcab3e7d%

pgsql: headerscheck: Document that --with-llvm is required

2025-08-29 Thread Peter Eisentraut
headerscheck: Document that --with-llvm is required We already documented that other --with-* options are required for a successful run. It turns out --with-llvm is also required. Suggested-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/1127775.1754417387%40sss.pgh.pa.us

pgsql: headerscheck: Use ICU_CFLAGS

2025-08-29 Thread Peter Eisentraut
headerscheck: Use ICU_CFLAGS Otherwise, headerscheck will fail if the ICU headers are in a location not reached by the normal CFLAGS/CPPFLAGS: ../src/include/utils/pg_locale.h:21:10: fatal error: unicode/ucol.h: No such file or directory Reviewed-by: Tom Lane Discussion: https://www.postgresq

pgsql: headerscheck: Ignore Windows-specific header

2025-08-29 Thread Peter Eisentraut
headerscheck: Ignore Windows-specific header Ignore src/include/port/win32/sys/resource.h. At least on macOS, including this results in warnings and errors because of duplication with system headers: ../src/include/port/win32/sys/resource.h:10:9: warning: 'RUSAGE_CHILDREN' redefined ../src/incl

pgsql: Mark ItemPointer arguments as const in tuple/table lock function

2025-08-28 Thread Peter Eisentraut
Mark ItemPointer arguments as const in tuple/table lock functions The functions LockTuple, ConditionalLockTuple, UnlockTuple, and XactLockTableWait take an ItemPointer argument that they do not modify, so the argument can be const-qualified to better convey intent and allow the compiler to enforce

pgsql: Remove unneeded casts of BufferGetPage() result

2025-08-28 Thread Peter Eisentraut
idn't exist in the pre-1995 code), and it was then apparently just copied around. Author: Kirill Reshke Reviewed-by: Chao Li Reviewed-by: Richard Guo Reviewed-by: Álvaro Herrera Reviewed-by: Peter Eisentraut Discussion: https://www.postgresql.org/message-id/flat/CALdSSPgF

pgsql: Message style improvements

2025-08-28 Thread Peter Eisentraut
Message style improvements An improvement pass over the new stats import functionality. Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/663eecb5b6166b1a41276819affa38ba27951b5e Modified Files -- src/backend/statistics/attribute_stats.c | 25 +++

pgsql: Message style improvements

2025-08-28 Thread Peter Eisentraut
Message style improvements An improvement pass over the new stats import functionality. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/80f11061323499ef2d07af32ae993473115ca176 Modified Files -- src/backend/statistics/attribute_stats.c | 25 +++---

pgsql: Put back intra-grant-inplace.spec test coverage

2025-08-27 Thread Peter Eisentraut
Put back intra-grant-inplace.spec test coverage Commit d31bbfb6590 lost some test coverage, because the situation being tested, a concurrent DROP, cannot happen anymore. Put the test coverage back with a bit of a trick, by deleting directly from the catalog table. Co-authored-by: Noah Misch Rev

pgsql: Improve objectNamesToOids() comment

2025-08-27 Thread Peter Eisentraut
Improve objectNamesToOids() comment Commit d31bbfb6590 removed the comment at objectNamesToOids() that there is no locking, because that commit added locking. But to fix all the problems, we'd still need a stronger lock. So put the comment back with more a detailed explanation. Co-authored-by:

pgsql: Put back intra-grant-inplace.spec test coverage

2025-08-27 Thread Peter Eisentraut
Put back intra-grant-inplace.spec test coverage Commit d31bbfb6590 lost some test coverage, because the situation being tested, a concurrent DROP, cannot happen anymore. Put the test coverage back with a bit of a trick, by deleting directly from the catalog table. Co-authored-by: Noah Misch Rev

pgsql: Improve objectNamesToOids() comment

2025-08-27 Thread Peter Eisentraut
Improve objectNamesToOids() comment Commit d31bbfb6590 removed the comment at objectNamesToOids() that there is no locking, because that commit added locking. But to fix all the problems, we'd still need a stronger lock. So put the comment back with more a detailed explanation. Co-authored-by:

pgsql: Fix: Don't strip $libdir from nested module_pathnames

2025-08-27 Thread Peter Eisentraut
Fix: Don't strip $libdir from nested module_pathnames This patch fixes a bug in how 'load_external_function' handles '$libdir/ prefixes in module paths. Previously, 'load_external_function' would unconditionally strip '$libdir/' from the beginning of the 'filename' string. This caused an issue w

pgsql: Fix: Don't strip $libdir from nested module_pathnames

2025-08-27 Thread Peter Eisentraut
Fix: Don't strip $libdir from nested module_pathnames This patch fixes a bug in how 'load_external_function' handles '$libdir/ prefixes in module paths. Previously, 'load_external_function' would unconditionally strip '$libdir/' from the beginning of the 'filename' string. This caused an issue w

pgsql: Message style improvements

2025-08-26 Thread Peter Eisentraut
Message style improvements Mostly adding some quoting. Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/952b5a4a9574d7489c51d509edf1cbfb06e96985 Modified Files -- src/backend/catalog/storage.c | 2 +- src/backend/storage/aio/method_io_

pgsql: Message style improvements

2025-08-26 Thread Peter Eisentraut
Message style improvements Mostly adding some quoting. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e567e22290544c57293f8e5a913292dacd3bcd1a Modified Files -- src/backend/catalog/storage.c | 2 +- src/backend/storage/aio/method_io_uring.c

pgsql: Raise C requirement to C11

2025-08-26 Thread Peter Eisentraut
Raise C requirement to C11 This changes configure and meson.build to require at least C11, instead of the previous C99. The installation documentation is updated accordingly. configure.ac previously used AC_PROG_CC_C99 to activate C99. But there is no AC_PROG_CC_C11 in Autoconf 2.69, because it

pgsql: Message wording improvements

2025-08-25 Thread Peter Eisentraut
Message wording improvements Use "row" instead of "tuple" for user-facing information for logical replication conflicts. Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9d115b9e11f553991badc0148bfa52580d1b3c8f Modified Files -- doc/src/sgml/logic

pgsql: Message wording improvements

2025-08-25 Thread Peter Eisentraut
Message wording improvements Use "row" instead of "tuple" for user-facing information for logical replication conflicts. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/99234e9ddc02f45eb122f83d49031e2c517d0af8 Modified Files -- doc/src/sgml/logical-repl

pgsql: Formatting cleanup of guc_tables.c

2025-08-25 Thread Peter Eisentraut
Formatting cleanup of guc_tables.c This cleans up a few minor formatting inconsistencies. Reviewed-by: John Naylor Discussion: https://www.postgresql.org/message-id/flat/dae6fe89-1e0c-4c3f-8d92-19d23374fb10%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/co

pgsql: Reduce lock level for ALTER DOMAIN ... VALIDATE CONSTRAINT

2025-08-22 Thread Peter Eisentraut
Reduce lock level for ALTER DOMAIN ... VALIDATE CONSTRAINT Reduce from ShareLock to ShareUpdateExclusivelock. Validation during ALTER DOMAIN ... ADD CONSTRAINT keeps using ShareLock. Example: create domain d1 as int; create table t (a d1); alter domain d1 add constraint cc10 check (

pgsql: Use consistent type for pgaio_io_get_id() result

2025-08-21 Thread Peter Eisentraut
Use consistent type for pgaio_io_get_id() result The result of pgaio_io_get_id() was being assigned to a mix of int and uint32 variables. This fixes it to use int consistently, which seems the most correct. Also change the queue empty special value in method_worker.c to -1 from UINT32_MAX. Revi

pgsql: Use consistent type for pgaio_io_get_id() result

2025-08-21 Thread Peter Eisentraut
Use consistent type for pgaio_io_get_id() result The result of pgaio_io_get_id() was being assigned to a mix of int and uint32 variables. This fixes it to use int consistently, which seems the most correct. Also change the queue empty special value in method_worker.c to -1 from UINT32_MAX. Revi

pgsql: PL/Python: Add event trigger support

2025-08-21 Thread Peter Eisentraut
PL/Python: Add event trigger support Allow event triggers to be written in PL/Python. It provides a TD dictionary with some information about the event trigger. Author: Euler Taveira Co-authored-by: Dimitri Fontaine Reviewed-by: Pavel Stehule Discussion: https://www.postgresql.org/message-id

pgsql: PL/Python: Refactor for event trigger support

2025-08-21 Thread Peter Eisentraut
PL/Python: Refactor for event trigger support Change is_trigger type from boolean to enum. That's a preparation for adding event trigger support. Author: Euler Taveira Co-authored-by: Dimitri Fontaine Reviewed-by: Pavel Stehule Discussion: https://www.postgresql.org/message-id/flat/03f03515-

pgsql: Minor error message enhancement

2025-08-20 Thread Peter Eisentraut
so we can easily understand which index is already attached for partition \"%s\". Author: Jian He Reviewed-by: Daniel Gustafsson Reviewed-by: Peter Eisentraut Discussion: https://www.postgresql.org/message-id/flat/CACJufxGBfykJ_1ztk9T%2BL_gLmkOSOF%2BmL9Mn4ZPydz-rh%3DLccQ%4

pgsql: Add src/include/catalog/README

2025-08-18 Thread Peter Eisentraut
Add src/include/catalog/README This just includes a link to the bki documentation, to help people get started. Before commit 372728b0d49, there was a README at src/backend/catalog/README, but then this was moved to the SGML documentation. So this effectively puts back a link to what was moved.

pgsql: Detect buffer underflow in get_th()

2025-08-18 Thread Peter Eisentraut
Detect buffer underflow in get_th() Input with zero length can result in a buffer underflow when accessing *(num + (len - 1)), as (len - 1) would produce a negative index. Add an assertion for zero-length input to prevent it. This was found by ALT Linux Team. Reviewing the call sites shows that

pgsql: meson: Move C99 test earlier

2025-08-17 Thread Peter Eisentraut
meson: Move C99 test earlier Move the test for compiler options for C99 earlier in meson.build, before we make use of the compiler for other tests. That way, if any command-line options are needed, subsequent tests will also use them. This is at the moment a theoretical problem, but it seems bett

pgsql: Fix git whitespace warning

2025-08-15 Thread Peter Eisentraut
Fix git whitespace warning Recent changes to src/tools/ci/README triggered warnings like src/tools/ci/README:88: leftover conflict marker Raise conflict-marker-size in .gitattributes to avoid these. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/82f996

pgsql: Fix git whitespace warning

2025-08-15 Thread Peter Eisentraut
Fix git whitespace warning Recent changes to src/tools/ci/README triggered warnings like src/tools/ci/README:88: leftover conflict marker Raise conflict-marker-size in .gitattributes to avoid these. Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ad3990

pgsql: Fix git whitespace warning

2025-08-15 Thread Peter Eisentraut
Fix git whitespace warning Recent changes to src/tools/ci/README triggered warnings like src/tools/ci/README:88: leftover conflict marker Raise conflict-marker-size in .gitattributes to avoid these. Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2b79e1

pgsql: Fix git whitespace warning

2025-08-15 Thread Peter Eisentraut
Fix git whitespace warning Recent changes to src/tools/ci/README triggered warnings like src/tools/ci/README:88: leftover conflict marker Raise conflict-marker-size in .gitattributes to avoid these. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e2e7ff7b891f

pgsql: Fix git whitespace warning

2025-08-15 Thread Peter Eisentraut
Fix git whitespace warning Recent changes to src/tools/ci/README triggered warnings like src/tools/ci/README:88: leftover conflict marker Raise conflict-marker-size in .gitattributes to avoid these. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1d5205

pgsql: Add TAP tests for LDAP connection parameter lookup

2025-08-15 Thread Peter Eisentraut
Add TAP tests for LDAP connection parameter lookup Add TAP tests that tests the LDAP Lookup of Connection Parameters functionality in libpq. Prior to this commit, LDAP test coverage only existed for the server-side authentication functionality and for connection service file with parameters direc

pgsql: Adjust some table column widths in PDF

2025-08-13 Thread Peter Eisentraut
Adjust some table column widths in PDF Make some column widths more pleasing. Note: Some of this relies on the reduced body indents introduced by commit 37e06ba6e82. Author: Noboru Saito Discussion: https://www.postgresql.org/message-id/flat/caam3qnlymud79xf+sqavwwcwurcf3hyufy9ki9csbqs-zmw...@

pgsql: Improve PDF documentation margins

2025-08-13 Thread Peter Eisentraut
Improve PDF documentation margins Set body indent to 0 to make use of the horizontal space better (and some reviewers thought it was also more readable). Add some left and right margin to the warning boxes, otherwise they drift too far off the page in combination with the above change. Author: N

pgsql: Clean up order in stylesheete-fo.xsl

2025-08-13 Thread Peter Eisentraut
Clean up order in stylesheete-fo.xsl Make a separate section for release notes customization. Commits f986882ffd6 and 8a6e85b46e0 put those into the middle of unrelated things. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8081e54bc52a0ea77cbe38a2a439598f361a5089

pgsql: libpq: Set LDAP protocol version 3

2025-08-12 Thread Peter Eisentraut
libpq: Set LDAP protocol version 3 Some LDAP servers reject the default version 2 protocol. So set version 3 before starting the connection. This matches how the backend LDAP code has worked all along. Co-authored-by: Andrew Jackson Reviewed-by: Pavel Seleznev Discussion: https://www.postgre

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 37a7b08d01b7b5af07a56872e16ac91a7f14a9b9 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/14f193beb27766082d4efacff240568c459fd377 Modified Files --

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 747984d18a963a4661f14623afe3627ac969ea7c Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5d3dab91293032be48fa097eb3cd8ffb594d6865 Modified Files --

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 5c10cbbbe3a047d729d23c3d254897f686a10eb9 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/192634292384ea385abd2c320c0810fc7621b325 Modified Files --

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 4f32135f4a43dba7fa02742da9d671e73e3d7714 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a4f513b5a8cade4fbf2115e3250d56dc7f83166e Modified Files --

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 4f9af069289c30fc32337b844fb1db25d7b11e9b Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ac4c0d3451093d339327aeca4e5b8f89622c6265 Modified Files --

pgsql: Translation updates

2025-08-11 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 380d4ff4d883aef5cb4e5ced45a339771197e6ef Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/605fdb989b8c4213907560ae90f2188425bf77ed Modified Files --

pgsql: Remove useless/superfluous Datum conversions

2025-08-08 Thread Peter Eisentraut
Remove useless/superfluous Datum conversions Remove useless DatumGetFoo() and FooGetDatum() calls. These are places where no conversion from or to Datum was actually happening. We think these extra calls covered here were harmless. Some actual bugs that were discovered during this process have

pgsql: Add missing Datum conversions

2025-08-08 Thread Peter Eisentraut
Add missing Datum conversions Add various missing conversions from and to Datum. The previous code mostly relied on implicit conversions or its own explicit casts instead of using the correct DatumGet*() or *GetDatum() functions. We think these omissions are harmless. Some actual bugs that were

pgsql: postgres_fdw and dblink should check if backend has MyProcPort

2025-08-08 Thread Peter Eisentraut
postgres_fdw and dblink should check if backend has MyProcPort before checking ->has_scram_keys. MyProcPort is NULL in background workers. So this could crash for example if a background worker accessed a suitable configured foreign table. Author: Alexander Pyhalov Reviewed-by: Pe

pgsql: postgres_fdw and dblink should check if backend has MyProcPort

2025-08-08 Thread Peter Eisentraut
postgres_fdw and dblink should check if backend has MyProcPort before checking ->has_scram_keys. MyProcPort is NULL in background workers. So this could crash for example if a background worker accessed a suitable configured foreign table. Author: Alexander Pyhalov Reviewed-by: Pe

pgsql: Fix incorrect lack of Datum conversion in _int_matchsel()

2025-08-08 Thread Peter Eisentraut
Fix incorrect lack of Datum conversion in _int_matchsel() The code used return (Selectivity) 0.0; where PG_RETURN_FLOAT8(0.0); would be correct. On 64-bit systems, these are pretty much equivalent, but on 32-bit systems, PG_RETURN_FLOAT8() correctly produces a pointer, but the old wro

pgsql: Fix incorrect lack of Datum conversion in _int_matchsel()

2025-08-08 Thread Peter Eisentraut
Fix incorrect lack of Datum conversion in _int_matchsel() The code used return (Selectivity) 0.0; where PG_RETURN_FLOAT8(0.0); would be correct. On 64-bit systems, these are pretty much equivalent, but on 32-bit systems, PG_RETURN_FLOAT8() correctly produces a pointer, but the old wro

pgsql: Fix incorrect lack of Datum conversion in _int_matchsel()

2025-08-08 Thread Peter Eisentraut
Fix incorrect lack of Datum conversion in _int_matchsel() The code used return (Selectivity) 0.0; where PG_RETURN_FLOAT8(0.0); would be correct. On 64-bit systems, these are pretty much equivalent, but on 32-bit systems, PG_RETURN_FLOAT8() correctly produces a pointer, but the old wro

  1   2   3   4   5   6   7   8   9   10   >