pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Ignore server-side delays when enforcing wal_sender_timeout.

2018-08-31 Thread Noah Misch
Ignore server-side delays when enforcing wal_sender_timeout. Healthy clients of servers having poor I/O performance, such as buildfarm members hamster and tern, saw unexpected timeouts. That disagreed with documentation. This fix adds one gettimeofday() call whenever ProcessRepliesIfAny() finds

pgsql: Fix 8a934d677 for libc++ and make more include order resistant.

2018-08-31 Thread Andres Freund
Fix 8a934d677 for libc++ and make more include order resistant. The previous definition was used in C++ mode, which causes problems when using clang with libc++ (rather than libstdc++), due to bugs therein. So just avoid in C++ mode. A second problem is that depending on include order and implic

pgsql: Fix 8a934d677 for libc++ and make more include order resistant.

2018-08-31 Thread Andres Freund
Fix 8a934d677 for libc++ and make more include order resistant. The previous definition was used in C++ mode, which causes problems when using clang with libc++ (rather than libstdc++), due to bugs therein. So just avoid in C++ mode. A second problem is that depending on include order and implic

pgsql: Fix psql's \dC command to annotate I/O conversion casts as such.

2018-08-31 Thread Tom Lane
Fix psql's \dC command to annotate I/O conversion casts as such. A cast declared WITH INOUT was described as '(binary coercible)', which seems pretty inaccurate; let's print '(with inout)' instead. Per complaint from Jean-Pierre Pelletier. This definitely seems like a bug fix, but given that it's

pgsql: Fix psql's \dC command to annotate I/O conversion casts as such.

2018-08-31 Thread Tom Lane
Fix psql's \dC command to annotate I/O conversion casts as such. A cast declared WITH INOUT was described as '(binary coercible)', which seems pretty inaccurate; let's print '(with inout)' instead. Per complaint from Jean-Pierre Pelletier. This definitely seems like a bug fix, but given that it's

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Ensure correct minimum consistent point on standbys

2018-08-31 Thread Michael Paquier
Ensure correct minimum consistent point on standbys Startup process has improved its calculation of incorrect minimum consistent point in 8d68ee6, which ensures that all WAL available gets replayed when doing crash recovery, and has introduced an incorrect calculation of the minimum recovery point

pgsql: Code review for pg_verify_checksums.c.

2018-08-31 Thread Tom Lane
Code review for pg_verify_checksums.c. Use postgres_fe.h, since this is frontend code. Pretend that we've heard of project style guidelines for, eg, #include order. Use BlockNumber not int arithmetic for block numbers, to avoid misbehavior with relations exceeding 2^31 blocks. Avoid an unnecess

pgsql: Code review for pg_verify_checksums.c.

2018-08-31 Thread Tom Lane
Code review for pg_verify_checksums.c. Use postgres_fe.h, since this is frontend code. Pretend that we've heard of project style guidelines for, eg, #include order. Use BlockNumber not int arithmetic for block numbers, to avoid misbehavior with relations exceeding 2^31 blocks. Avoid an unnecess

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Enforce cube dimension limit in all cube construction functions

2018-08-31 Thread Alexander Korotkov
Enforce cube dimension limit in all cube construction functions contrib/cube has a limit to 100 dimensions for cube datatype. However, it's not enforced everywhere, and one can actually construct cube with more than 100 dimensions having then trouble with dump/restore. This commit add checks for

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Split contrib/cube platform-depended checks into separate test

2018-08-31 Thread Alexander Korotkov
Split contrib/cube platform-depended checks into separate test We're currently maintaining two outputs for cube regression test. But that appears to be unsuitable, because these outputs are different in out few checks involving scientific notation. So, split checks involving scientific notation

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Make checksum_impl.h safe to compile with -fstrict-aliasing.

2018-08-31 Thread Tom Lane
Make checksum_impl.h safe to compile with -fstrict-aliasing. In general, Postgres requires -fno-strict-aliasing with compilers that implement C99 strict aliasing rules. There's little hope of getting rid of that overall. But it seems like it would be a good idea if storage/checksum_impl.h in par

pgsql: Disable support for partitionwise joins in problematic cases.

2018-08-31 Thread Etsuro Fujita
Disable support for partitionwise joins in problematic cases. Commit f49842d, which added support for partitionwise joins, built the child's tlist by applying adjust_appendrel_attrs() to the parent's. So in the case where the parent's included a whole-row Var for the parent, the child's contained

pgsql: Disable support for partitionwise joins in problematic cases.

2018-08-31 Thread Etsuro Fujita
Disable support for partitionwise joins in problematic cases. Commit f49842d, which added support for partitionwise joins, built the child's tlist by applying adjust_appendrel_attrs() to the parent's. So in the case where the parent's included a whole-row Var for the parent, the child's contained

pgsql: Fix pg_verify_checksums on Windows.

2018-08-31 Thread Amit Kapila
Fix pg_verify_checksums on Windows. To verify the checksums, we open the file in text mode which doesn't work on Windows as WIN32 treats Control-Z as EOF in files opened in text mode. This leads to "short read of block .." error in some cases. Fix it by opening the files in the binary mode. Auth

pgsql: Fix pg_verify_checksums on Windows.

2018-08-31 Thread Amit Kapila
Fix pg_verify_checksums on Windows. To verify the checksums, we open the file in text mode which doesn't work on Windows as WIN32 treats Control-Z as EOF in files opened in text mode. This leads to "short read of block .." error in some cases. Fix it by opening the files in the binary mode. Auth

pgsql: Remove extra word from src/backend/optimizer/README

2018-08-31 Thread Etsuro Fujita
Remove extra word from src/backend/optimizer/README Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/40e981391395ae93aadfaf08cd343af65cc6252b Modified Files -- src/backend/optimizer/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove extra word from src/backend/optimizer/README

2018-08-31 Thread Etsuro Fujita
Remove extra word from src/backend/optimizer/README Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e39f69b6621bd3d67f650a5647fd0412819712d Modified Files -- src/backend/optimizer/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)