Re: [BUGS] BUG #4731: compile with -fast fails on ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o

2009-03-25 Thread Marko Kreen
On 3/25/09, Tom Lane wrote: > "Ceriel Jacobs" writes: > > ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o > > I think at bottom that's a compiler/linker bug which you should mention > to Apple. However, I see what is causing it: pgp.h contains > > enum > { > PGP_S2

Re: [PERFORM] [BUGS] BUG #4919: CREATE USER command slows down system performance

2009-07-15 Thread Marko Kreen
On 7/15/09, Tom Lane wrote: > Alvaro Herrera writes: > > > toruvinn wrote: > >> I was always wondering, though, why PostgreSQL uses this approach and not > >> its catalogs. > > > It does use the catalog for most things. THe flatfile is used for the > > situations where the catalogs are not y

Re: [PERFORM] [BUGS] BUG #4919: CREATE USER command slows down system performance

2009-07-15 Thread Marko Kreen
On 7/15/09, David Wilson wrote: > On Wed, Jul 15, 2009 at 11:10 AM, Marko Kreen wrote: > > From security standpoint, wasting more cycles on bad passwords is good, > > as it decreases the rate bruteforce password scanning can happen. > > > > And I cannot imagine a sc

Re: [BUGS] BUG #3571: call to decrypt causes segfault

2007-08-23 Thread Marko Kreen
On 8/23/07, Tom Lane <[EMAIL PROTECTED]> wrote: > "Ken Colson" <[EMAIL PROTECTED]> writes: > > this statement: > > select decrypt(''::bytea,'password','bf') > > causes the postgresql backend to crash: > > This seems to be a 64bit problem. > > Reproduced here in HEAD. The problem is here: > 293

Re: [BUGS] BUG #2260: PGCrypto Memory Problem

2006-02-16 Thread Marko Kreen
On Wed, Feb 15, 2006 at 03:02:45PM -0500, Tom Lane wrote: > Michael Fuhr <[EMAIL PROTECTED]> writes: > > My non-OpenSSL build shows no memory leak, so the leak and OpenSSL > > seem to be correlated. I'd be more inclined to suspect a bug in > > pgcrypto's OpenSSL-specific code than in OpenSSL itsel

Re: [BUGS] pgcrypto decrypt_iv() issue

2012-01-27 Thread Marko Kreen
On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: > Stefan Kaltenbrunner writes: > > from some looking at the code in pgcrypto.c it seems to me that the > > coding pattern in most functions there only checks for errors from the > > corresponding initialization function, in the case of say

Re: [BUGS] pgcrypto decrypt_iv() issue

2012-01-27 Thread Marko Kreen
On Fri, Jan 27, 2012 at 12:13:21PM -0500, Tom Lane wrote: > Marko Kreen writes: > > pgcrypto.c is easily fixable and internal.c has proper checks. > > But openssl.c does not. And I have a bigger openssl.c cleanup > > pending. So I would prefer to add missing checks to cle

Re: [BUGS] pgcrypto decrypt_iv() issue

2012-01-27 Thread Marko Kreen
On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner wrote: > On 01/27/2012 04:20 PM, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: >> Yeah, it should be fixed.  But note that "random data" is part of >> decrypt() spec - the

Re: [BUGS] pgcrypto decrypt_iv() issue

2012-01-27 Thread Marko Kreen
On Fri, Jan 27, 2012 at 8:00 PM, Magnus Hagander wrote: > On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner >> wrote: >>> On 01/27/2012 04:20 PM, Marko Kreen wrote: >>>> On Fri, Jan 27, 2012 at 01:37:1

Re: [BUGS] pgcrypto decrypt_iv() issue

2012-01-27 Thread Marko Kreen
On Fri, Jan 27, 2012 at 8:10 PM, Stefan Kaltenbrunner wrote: > On 01/27/2012 07:06 PM, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 8:00 PM, Magnus Hagander wrote: >>> On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: >>>> On Fri, Jan 27, 2012 at 7:34 PM, St