Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
Peter, Some of the false positives can be suppressed by teaching the analyzer about the codebase. For example, many of them are due to the custom assertion/error handlers, where you stop execution on an error path by calling, for example, 'elog'. You can drastically reduce the number of false posi

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 11:13 AM, Josh Kupershmidt wrote: > On Thu, May 31, 2012 at 10:06 PM, Tom Lane wrote: >> zaks.a...@gmail.com writes: > >>> There are two memory leaks in dumputils (v9.2.0beta1): >> >>> 1) >>> File:   src/bin/scripts/dumputils.c >>> Location:       line 604, column 11 >>> De

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 11:53 AM, Josh Kupershmidt wrote: > On Fri, Jun 1, 2012 at 11:38 AM, Anna Zaks wrote: >> Josh, >> >> What kid of machine are you using? Please, let me know how long it >> took after it's done (It takes about one and a half hours on mine)

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
Josh, I opened an analyzer Bugzilla report for this issue in case you 'd like to follow up there: http://llvm.org/bugs/show_bug.cgi?id=13010 Thanks, Anna. On Fri, Jun 1, 2012 at 3:19 PM, Anna Zaks wrote: > On Fri, Jun 1, 2012 at 11:53 AM, Josh Kupershmidt wrote: >> On Fri, Jun

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 9:26 PM, Josh Kupershmidt wrote: > On Fri, Jun 1, 2012 at 4:23 PM, Anna Zaks wrote: > >> I opened an analyzer Bugzilla report for this issue in case you 'd >> like to follow up there: >> http://llvm.org/bugs/show_bug.cgi?id=13010 > > T