Re: [BUGS] Doc-bug; minor typo in auto_explain documentation

On Thu, Jan 26, 2012 at 23:45, Peter Geoghegan wrote: > I noticed the following in the auto_explain documentation: > > "This can have extremely negative impact on performance." > > Surely it should say: > > "This can have an extremely negative impact on performance." Yeah, that seems better. Fix

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

iirc, using %COMSPEC% /c will cause the scripts to run in a visible command window, which is pretty ugly, and doesn't seem to be necessary anywhere except on your machine! What's the output from the "set" command on that box? On Thu, Jan 26, 2012 at 6:54 PM, Eric Borts wrote: > Also, here is a l

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

Installer works at our end without any issue. I remember we had considered using "%COMSPEC% /c" earlier but dropped it because command windows opens up for every new file execution. On Fri, Jan 27, 2012 at 3:40 PM, Dave Page wrote: > iirc, using %COMSPEC% /c will cause the scripts to run in a v

Re: [BUGS] BUG #6200: standby bad memory allocations on SELECT

On Mon, Jan 23, 2012 at 3:22 PM, Bridget Frey wrote: > Hello, > We upgraded to postgres 9.1.2 two weeks ago, and we are also experiencing an > issue that seems very similar to the one reported as bug 6200.  We see > approximately 2 dozen alloc errors per day across 3 slaves, and we are > getting o

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: > Stefan Kaltenbrunner writes: > > from some looking at the code in pgcrypto.c it seems to me that the > > coding pattern in most functions there only checks for errors from the > > corresponding initialization function, in the case of say

Re: [BUGS] pgcrypto decrypt_iv() issue

Marko Kreen writes: > pgcrypto.c is easily fixable and internal.c has proper checks. > But openssl.c does not. And I have a bigger openssl.c cleanup > pending. So I would prefer to add missing checks to cleaned-up > openssl.c and post them together (soonish). > But I'm bit unclear about fate of

Re: [BUGS] pgcrypto decrypt_iv() issue

On 01/27/2012 04:20 PM, Marko Kreen wrote: > On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: >> Stefan Kaltenbrunner writes: >>> from some looking at the code in pgcrypto.c it seems to me that the >>> coding pattern in most functions there only checks for errors from the >>> correspondin

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 12:13:21PM -0500, Tom Lane wrote: > Marko Kreen writes: > > pgcrypto.c is easily fixable and internal.c has proper checks. > > But openssl.c does not. And I have a bigger openssl.c cleanup > > pending. So I would prefer to add missing checks to cleaned-up > > openssl.c an

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner wrote: > On 01/27/2012 04:20 PM, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: >> Yeah, it should be fixed.  But note that "random data" is part of >> decrypt() spec - the validation it can do is a joke. >> >>

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: > On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner > wrote: >> On 01/27/2012 04:20 PM, Marko Kreen wrote: >>> On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: >>> Yeah, it should be fixed.  But note that "random data" is part of >>>

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 8:00 PM, Magnus Hagander wrote: > On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner >> wrote: >>> On 01/27/2012 04:20 PM, Marko Kreen wrote: On Fri, Jan 27, 2012 at 01:37:11AM -0500, Tom Lane wrote: Yeah,

Re: [BUGS] pgcrypto decrypt_iv() issue

On 01/27/2012 07:06 PM, Marko Kreen wrote: > On Fri, Jan 27, 2012 at 8:00 PM, Magnus Hagander wrote: >> On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: >>> On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner >>> wrote: On 01/27/2012 04:20 PM, Marko Kreen wrote: > On Fri, Jan 27, 201

Re: [BUGS] pgcrypto decrypt_iv() issue

On Fri, Jan 27, 2012 at 8:10 PM, Stefan Kaltenbrunner wrote: > On 01/27/2012 07:06 PM, Marko Kreen wrote: >> On Fri, Jan 27, 2012 at 8:00 PM, Magnus Hagander wrote: >>> On Fri, Jan 27, 2012 at 18:54, Marko Kreen wrote: On Fri, Jan 27, 2012 at 7:34 PM, Stefan Kaltenbrunner wrote: >

Re: [BUGS] BUG #6200: standby bad memory allocations on SELECT

On Fri, Jan 27, 2012 at 1:31 PM, Bridget Frey wrote: > Thanks for the info - that's very helpful.  We had also noted that the alloc > seems to be -3 bytes.  We have run pg_check and it found no instances of > corruption. We've also replayed queries that have failed, and have never > been able to g

Re: [BUGS] BUG #6200: standby bad memory allocations on SELECT

Thanks for the info - that's very helpful. We had also noted that the alloc seems to be -3 bytes. We have run pg_check and it found no instances of corruption. We've also replayed queries that have failed, and have never been able to get the same query to fail twice. In the case you investigated

Re: [BUGS] Segfault in backend CTE code

On Wed, Jan 25, 2012 at 5:13 PM, Tom Lane wrote: > Phil Sorber writes: >> That helped a lot. I now have a simple test case that I can reliably >> re-produce the segfault and now also a patch that fixes it. > > [ pokes at that... ]  Hmm.  I think what this proves is that that > optimization in Eva

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

Regarding my final point: "Similarly, you may prefer to have the default action for a batch file (.bat) changed to Edit instead of Open. Double-clicking the file will not run the commands in the file, and if users want to run the file, they can use the*Open*command on the shortcut menu." http

[BUGS] Example in plpgsql docs can lead to infinite loop

http://www.postgresql.org/docs/devel/static/plpgsql-control-structures.html#PLPGSQL-UPSERT-EXAMPLE This example can lead to an infinite loop if there is another column that has a unique key constraint on it in addition to the primary key and someone tries to execute the function with a unique prim

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

The installation now runs successfully after deleting that registry key. In addition, I tried changing the default action on batch files from "Open" to "Edit" using the registry (Windows 7). Double-clicking a file opens it in Notepad, but the installation runs successfully. So it looks like th

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

I found the problem with my computer here . It turns out this registry entry was causing my problem: HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.bat \UserChoice Progid REG_SZ (

Re: [BUGS] Windows x86-64 One-Click Install (9.1.2-1, 9.0.6-1) hangs on "initialising the database cluster" (with work-around)

On Sat, Jan 28, 2012 at 2:17 AM, Eric Borts wrote: > The installation now runs successfully after deleting that registry key. > > In addition, I tried changing the default action on batch files from > "Open" to "Edit" using the registry (Windows 7). Double-clicking a file > opens it in Notepad,

Re: [BUGS] pgcrypto decrypt_iv() issue

Marko Kreen writes: > On Fri, Jan 27, 2012 at 12:13:21PM -0500, Tom Lane wrote: >> I think we should fix and back-patch these two specific bugs. The >> openssl.c change sounds like it might be something for HEAD only. > Now I looked more in-depth and seems my comments were off - error > detectio