[BUGS] Typo in nbtsort.c

2011-10-01 Thread Peter Geoghegan
I noticed this typo in a comment in the file nbtsort.c: /* * We need to log index creation in WAL iff WAL archiving/streaming is * enabled UNLESS the index isn't WAL-logged anyway. */ I suggest an s/iff/if/ -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Sup

Re: [BUGS] Typo in nbtsort.c

2011-10-01 Thread Tom Lane
Peter Geoghegan writes: > I noticed this typo in a comment in the file nbtsort.c: > /* > * We need to log index creation in WAL iff WAL archiving/streaming is > * enabled UNLESS the index isn't WAL-logged anyway. > */ > I suggest an s/iff/if/ This is not a typo, it's the standard contraction

Re: [BUGS] BUG #6235: Delete fails with ON DELETE rule on inherited table

2011-10-01 Thread Evan Martin
On 1/10/2011 3:35 AM, Tom Lane wrote: If you delete from the base table then the DELETE succeeds (the row is deleted), but the referenced row is not deleted. This might make sense to someone who knows how inheritance is implemented, but it wasn't immediately obvious to me. It would be nice if thi

Re: [BUGS] BUG #6231: weird to_timestamp behaviour with out of range values

2011-10-01 Thread Stephen Frost
* Henk Enting (h.d.ent...@mgrid.net) wrote: > But still, I think the to_timestamp should throw an error if I put in > something like '21-21-2011'. I agree completely, this is a pretty big bug in my opinion. We don't accept invalid or garbage timestamps in the input function, I don't see any reaso