[BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Josh Berkus
Version: 9.0 beta 3 Severity: Contrib feature broken Platform: Ubuntu Netbook Remix, Dell 10 Mini laptop Workaround Possible? No. With 9.0, the obvious thing to do with autoexplain is to log JSON or XML explain plans to a csvlog and then automatically process them. However, when I attempt to do

Re: [BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Tom Lane
Josh Berkus writes: > With 9.0, the obvious thing to do with autoexplain is to log JSON or XML > explain plans to a csvlog and then automatically process them. > However, when I attempt to do this, I get the following warning at > PostgreSQL startup time: > Loaded module "auto_explain" > Not saf

Re: [BUGS] BUG #5564: Odd behavior with aggregate_func(DISTINCT foo ORDER BY foo)

2010-07-18 Thread Tom Lane
"Daniel Grace" writes: > This test case fails with the above error: > CREATE TABLE foo ( > t VARCHAR > ); > INSERT INTO foo (t) VALUES ('a'), ('a'), ('b'), ('b'), ('c'); > SELECT STRING_AGG(DISTINCT t ORDER BY t) FROM foo; I've applied a patch for this. Thanks for the report!

Re: [BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Tom Lane
Josh Berkus writes: > With 9.0, the obvious thing to do with autoexplain is to log JSON or XML > explain plans to a csvlog and then automatically process them. BTW, I tried this and it works fine for me. > However, when I attempt to do this, I get the following warning at > PostgreSQL startup ti

Re: [BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Andrew Dunstan
Tom Lane wrote: Anyway, you'll get the same "not safe" bleat for any message logged during early postmaster startup. Maybe we should just drop the "not safe" message. It's not conveying anything very helpful, I think. The useful bit of the behavior is to shove the original message out to std

Re: [BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> Anyway, you'll get the same "not safe" bleat for any message >> logged during early postmaster startup. >> >> Maybe we should just drop the "not safe" message. It's not conveying >> anything very helpful, I think. The useful bit of the behavior is to

Re: [BUGS] auto-explain does not work with JSON & csvlog

2010-07-18 Thread Tom Lane
Tom Lane writes: > Andrew Dunstan writes: >> I thought we agreed back in November to stop the bleating. > Did we? I'd forgotten. You're right ... this conversation seems to be a repeat of the thread here: http://archives.postgresql.org/pgsql-hackers/2009-11/msg01260.php I'll go fix it now bef