Re: [BUGS] BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

2010-06-06 Thread Robert Haas
On Jun 5, 2010, at 4:02 PM, Dimitri Fontaine wrote: Alvaro Herrera writes: I don't think "dumps must be human-readable" is an argument to reject such a switch, as long as it's off by default. And I haven't seen any other valid argument either, so +1 from me. Well as Bruce said this opti

Re: [BUGS] BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

2010-06-06 Thread Dimitri Fontaine
Robert Haas writes: >> Well as Bruce said this option won't solve the OP's problem, unless the >> application he's using for managing the backups do use the option. > > Well, that's a pretty trivial change to the backup script. +1 from me on > providing a pg_dump option. The application still ha

Re: [BUGS] Re: BUG #5490: Using distinct for select list causes insert of timestamp string literal to fail

2010-06-06 Thread Dimitri Fontaine
Farid Zidan writes: > I see no technical analysis in your response. I made a clear reference to what others have been saying, and that you have been refusing to read. I don't see any point in getting technical again, as I'm sure you will refuse to understand what is happening to you here. But a

Re: [BUGS] BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

2010-06-06 Thread Robert Haas
On Sun, Jun 6, 2010 at 2:53 PM, Dimitri Fontaine wrote: > Robert Haas writes: >>> Well as Bruce said this option won't solve the OP's problem, unless the >>> application he's using for managing the backups do use the option. >> >> Well, that's a pretty trivial change to the backup script.  +1 fro

Re: [BUGS] BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

2010-06-06 Thread Tom Lane
Robert Haas writes: > I think as a community we can sometimes be a bit intolerant of people > who don't do things exactly the right way and get themselves into > trouble. Casting aside the sweeping generalizations for a moment ... this is about how much effort we are willing to put into making up

Re: [BUGS] Re: BUG #5490: Using distinct for select list causes insert of timestamp string literal to fail

2010-06-06 Thread Craig Ringer
On 7/06/2010 3:51 AM, Dimitri Fontaine wrote: - other products are happy to solve the DISTINCT restriction without any hint as far as what the datatype really is ... and so is Pg. That's not the problem; Pg complains after resolving the SELECT DISTINCT, when it finds that it's trying to

Re: [BUGS] BUG #5490: Using distinct for select list causes insert of timestamp string literal to fail

2010-06-06 Thread Craig Ringer
I know it's not what you want (Pg behaving how you expect out of the box) but creating implicit casts to the desired types will resolve your immediate issue. You still have to run some Pg-specific code, but it can be restricted to your DDL where there's (presumably) already plenty. See: http: