Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Mikael Krantz
On Wed, May 6, 2009 at 6:26 PM, Heikki Linnakangas wrote: >> How to reproduce: >> >>  * restore from backup >>  * SELECT pg_start_backup('label'); >>  * take a new backup >>  * SELECT pg_stop_backup(); >>  * copy the relevant WAL-files >>  * try to restore the backup > > I failed to reproduce this

Re: [BUGS] BUG #4785: Installation fails

2009-05-07 Thread Dave Page
[Please keep the list CC'd] On Thu, May 7, 2009 at 3:14 AM, Krimstock, Roger I (Roger) wrote: > > The command that seems to be failing appears to be: > > echo y|cacls "C:\Program Files\PostgreSQL\8.4\data" /T /G "":F > > where is your current username as returned by a scripting object. > Can yo

Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Heikki Linnakangas
Mikael Krantz wrote: On Wed, May 6, 2009 at 6:26 PM, Heikki Linnakangas wrote: How to reproduce: * restore from backup * SELECT pg_start_backup('label'); * take a new backup * SELECT pg_stop_backup(); * copy the relevant WAL-files * try to restore the backup I failed to reproduce this.

Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Heikki Linnakangas
I wrote: I'll make pg_start_backup() to request xlog switch before the checkpoint as you suggested. That's an easy fix that can be easily back-patched. Done. I only back-patched it down to 8.2, because earlier versions didn't have pg_xlog_switch(). They would've required more invasive changes

Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Simon Riggs
On Thu, 2009-05-07 at 12:15 +0300, Heikki Linnakangas wrote: > Yeah, I think you're right. If you omit pg_xlog from the base backup, > as we recommend in the manual, and clear the old files from the > archive too, then you won't have the old history file around. Sorry about this, but I don't agr

Re: [BUGS] Bug (8.4beta): FailedAssertion("!(bms_is_subset(relids, qualscope))", File: "initsplan.c", Line: 915)

2009-05-07 Thread Stefan Huehner
On Wed, May 06, 2009 at 03:47:46PM -0400, Tom Lane wrote: > I wrote: > > I suppose the change I made here > > http://archives.postgresql.org/pgsql-committers/2009-04/msg00329.php > > to improve constant-join-qual handling is what is preventing the > > assertion failure, though I'm still not quite s

Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Heikki Linnakangas
Simon Riggs wrote: On Thu, 2009-05-07 at 12:15 +0300, Heikki Linnakangas wrote: Yeah, I think you're right. If you omit pg_xlog from the base backup, as we recommend in the manual, and clear the old files from the archive too, then you won't have the old history file around. ... A more useful

Re: [HACKERS] Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Simon Riggs
On Thu, 2009-05-07 at 17:54 +0300, Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Thu, 2009-05-07 at 12:15 +0300, Heikki Linnakangas wrote: > > > >> Yeah, I think you're right. If you omit pg_xlog from the base backup, > >> as we recommend in the manual, and clear the old files from the >

Re: [HACKERS] Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Heikki Linnakangas
Simon Riggs wrote: On Thu, 2009-05-07 at 17:54 +0300, Heikki Linnakangas wrote: Simon Riggs wrote: A more useful thing might be to do an xlog switch before we do the shutdown checkpoint at end of recovery. That gives the same sequence of actions without modifying the existing sequence of activi

Re: [HACKERS] Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Simon Riggs
On Thu, 2009-05-07 at 18:57 +0300, Heikki Linnakangas wrote: > I don't see any user error here. Just observing that the error occurs because we rely on a file being there when we haven't even documented that it needs to be there for it to work. File deletion with %r from the archive would not hav

Re: [HACKERS] Re: [BUGS] BUG #4796: Recovery followed by backup creates unrecoverable WAL-file

2009-05-07 Thread Heikki Linnakangas
Simon Riggs wrote: On Thu, 2009-05-07 at 18:57 +0300, Heikki Linnakangas wrote: I don't see any user error here. Just observing that the error occurs because we rely on a file being there when we haven't even documented that it needs to be there for it to work. File deletion with %r from the a