Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread David Newall
I didn't get it either. The original report was posted to pgsql-bugs on October 10. It might be lag; it'll probably turn up, about 6 seconds after I press *S Original Message ---- Subject: Re: [BUGS] rollback to savepoint leads to transaction already in prog

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Michael Meskes
Takahiro-san, I think the string-comparison is unreliable. So, I'd like to replace the code to use PQtransactionStatus(). I have two patches to do it: The first one (ecpg-trans-quick_20101014.patch) is a quick fix that replaces only the above test. The second one (ecpg-trans-full_20101014.patch)

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Itagaki Takahiro
On Mon, Oct 11, 2010 at 7:42 AM, David Newall wrote: > Trivial program to demonstrate problem: > > main() { >    ECPGdebug(1,stderr); >    exec sql connect to postgres; >    exec sql set autocommit to off; >    exec sql start transaction; >    exec sql savepoint s; >    exec sql rollback to s; >  

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 6:53 AM, Michael Meskes wrote: > Am 14.10.2010 08:52, schrieb David Newall: >> >> On 14/10/10 12:14, Itagaki Takahiro wrote: >>> >>> Which solution is better? Or, another idea? >> >> This does seem to be an new bug in previously working code. While any >> solution that fixe

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Michael Meskes
Am 14.10.2010 08:52, schrieb David Newall: On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that fixes the problem is good, it might pay to look the code that worked before. As

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 3:52 PM, David Newall wrote: > This does seem to be an new bug in previously working code.  While any > solution that fixes the problem is good, it might pay to look the code that > worked before.  As reported, it worked for ecpg (PostgreSQL 8.3.8) 4.4.1. It works on 8.3,

Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread David Newall
On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that fixes the problem is good, it might pay to look the code that worked before. As reported, it worked for ecpg (Postgr