Re: [BUGS] Cannot dump 8.4.8 database using later versions

2012-08-16 Thread Bruce Momjian
I don't think we ever addressed this, but since we have had minimal complaints about it, I guess we are OK. --- On Tue, Nov 15, 2011 at 10:04:57PM -0500, Tom Lane wrote: > Robert Haas writes: > > On Tue, Nov 15, 2011 at 5:1

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-16 Thread Josh Berkus
> The least painful solution might be to always quote *every* identifier > in commands sent to the source server, since we don't especially care > how nice-looking those are. I've never been clear on why we don't do that in the first place. -- Josh Berkus PostgreSQL Experts Inc. http://pgexpert

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-15 Thread Pavel Golub
Hello, Tom. You wrote: TL> Robert Haas writes: >> On Tue, Nov 15, 2011 at 5:16 AM, Heikki Linnakangas >> wrote: >>> NEW used to be a reserved keyword, but it's not so in 9.0 anymore. So 9.0 >>> pg_dump thinks it doesn't need to be quoted. >> Why isn't it correct? TL> It's correct to not quote

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-15 Thread Tom Lane
Robert Haas writes: > On Tue, Nov 15, 2011 at 5:16 AM, Heikki Linnakangas > wrote: >> NEW used to be a reserved keyword, but it's not so in 9.0 anymore. So 9.0 >> pg_dump thinks it doesn't need to be quoted. > Why isn't it correct? It's correct to not quote it in pg_dump's output (since we make

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-15 Thread Robert Haas
On Tue, Nov 15, 2011 at 5:16 AM, Heikki Linnakangas wrote: > NEW used to be a reserved keyword, but it's not so in 9.0 anymore. So 9.0 > pg_dump thinks it doesn't need to be quoted. Why isn't it correct? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-15 Thread Andreas Lange
On 2011-11-15 v46 01.43, Josh Berkus wrote: ... somehow the query to dump the sequences is getting mangled. Any clue how? Seems you have a sequence called "new"; seems we don't handle that well. So, tested this some more. For some reason, 8.4's pg_dump would recognize NEW as a reserved word

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-15 Thread Heikki Linnakangas
On 15.11.2011 02:43, Josh Berkus wrote: ... somehow the query to dump the sequences is getting mangled. Any clue how? Seems you have a sequence called "new"; seems we don't handle that well. So, tested this some more. For some reason, 8.4's pg_dump would recognize NEW as a reserved word

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-14 Thread Josh Berkus
>> ... somehow the query to dump the sequences is getting mangled. Any >> clue how? > > Seems you have a sequence called "new"; seems we don't handle that > well. So, tested this some more. For some reason, 8.4's pg_dump would recognize NEW as a reserved word and quote it before dumping. 9.0

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-14 Thread Bruce Momjian
Josh Berkus wrote: > Severity: normal > > Versions tested: 9.0.4 and 9.1.1 > Installed from packages on Ubuntu > > Reproduceability: 100% on this server > have not tried a test case yet > > Steps: > > 1. large running 8.4.8 PostgreSQL database > > 2. /usr/lib/postgresql/9.1/bin/pg_

Re: [BUGS] Cannot dump 8.4.8 database using later versions

2011-11-14 Thread Josh Berkus
> Seems you have a sequence called "new"; seems we don't handle that > well. Hmmm ... yes, you're correct. Idiot users. Interestingly, the sequence is no problem until 9.0. 8.4 handled it fine. I'd guess this is another example of where merging in plpgsql broke something. -- Josh Berkus Po