I wrote:
> In particular, I suggest the attached patch (code-complete, but sans
> documentation changes).
Applied with doc fixes. I waited till after alpha4 was cut, though.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make change
Robert Haas writes:
> On Wed, Mar 9, 2011 at 12:45 AM, Tom Lane wrote:
>>> along with the change you made for PLs.
>> Huh?
> In 9.0, to comment on a procedural language, you must be superuser.
> But your recent commit changed it to check for language ownership.
Oh. That's just a bug fix: it s
On Wed, Mar 9, 2011 at 12:45 AM, Tom Lane wrote:
> How that gets boiled down into a release note will depend on whoever
> writes the release notes.
>
>> along with the change you made for PLs.
In 9.0, to comment on a procedural language, you must be superuser.
But your recent commit changed it to
Robert Haas writes:
> On Tue, Mar 8, 2011 at 11:48 PM, Tom Lane wrote:
>> In particular, I suggest the attached patch (code-complete, but sans
>> documentation changes).
> I think it's a good change, but we should make sure to release-note it
> properly,
I had already drafted a commit message:
On Tue, Mar 8, 2011 at 11:48 PM, Tom Lane wrote:
> I wrote:
>> I thought there was nothing particularly unreasonable about Owen's
>> suggestion: let users with the CREATEROLE attribute comment on any role.
>> I don't think COMMENT added to CREATE ROLE would be a very nice fix
>> (aside from being
I wrote:
> I thought there was nothing particularly unreasonable about Owen's
> suggestion: let users with the CREATEROLE attribute comment on any role.
> I don't think COMMENT added to CREATE ROLE would be a very nice fix
> (aside from being ugly, what if you want to change the comment later?).
>
Alvaro Herrera writes:
> Excerpts from Euler Taveira de Oliveira's message of mar mar 08 02:06:13
> -0300 2011:
>> Em 07-03-2011 16:53, Owen Jacobson escreveu:
>>> psql:repro.sql:2: ERROR: must be member of role "commented_role" to
>>> comment upon it
>> This isn't a bug; let say it is a limita
Excerpts from Euler Taveira de Oliveira's message of mar mar 08 02:06:13 -0300
2011:
> Em 07-03-2011 16:53, Owen Jacobson escreveu:
> > psql:repro.sql:2: ERROR: must be member of role "commented_role" to
> > comment upon it
> >
> This isn't a bug; let say it is a limitation (and a documented one
Em 07-03-2011 16:53, Owen Jacobson escreveu:
psql:repro.sql:2: ERROR: must be member of role "commented_role" to
comment upon it
This isn't a bug; let say it is a limitation (and a documented one [1]).
Unfortunately only the role, superuser or its members can add/drop comments.
[1] http://w
