Re: [BUGS] Bug #925: typing error in src/backend/libpq/be-secure.c

2003-03-28 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Actually, the docs say SSL_read/write can error needing READ or WRITE: > http://www.openssl.org/docs/ssl/SSL_read.html# Only when using a non-blocking BIO, which the backend had better not be doing. But a few lines of useless code aren't a big dea

Re: [BUGS] Bug #925: typing error in src/backend/libpq/be-secure.c

2003-03-28 Thread Bruce Momjian
Actually, the docs say SSL_read/write can error needing READ or WRITE: http://www.openssl.org/docs/ssl/SSL_read.html# The SSL_write docs are the same. I have applied the following patch to handle both new cases. Does this help the SSL test program you have? ---

Re: [BUGS] Bug #925: typing error in src/backend/libpq/be-secure.c

2003-03-28 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Yep, typo. Patched to CVS current and backpatched to 7.3.X. I think this fix is exactly backward. Why would SSL_write need to return ERROR_WANT_WRITE? It couldn't. The correct fix is that SSL_write might return ERROR_WANT_READ, for which reading woul

Re: [BUGS] Bug #925: typing error in src/backend/libpq/be-secure.c

2003-03-28 Thread Bruce Momjian
Yep, typo. Patched to CVS current and backpatched to 7.3.X. --- [EMAIL PROTECTED] wrote: > Sergey N. Yatskevich ([EMAIL PROTECTED]) reports a bug with a severity of 4 > The lower the number the more severe it is. > > Short