Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-25 Thread Tom Lane
Craig Ringer writes: > On 21/09/2011 4:25 PM, Lionel Elie Mamane wrote: >> I added my initial patch, and as far as I understand, I have to send >> the revised patch to the list before I can register it at the >> commitfest. So here is my revised patch, that uses "const char *const * " >> like else

Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-22 Thread Craig Ringer
On 21/09/2011 4:25 PM, Lionel Elie Mamane wrote: I added my initial patch, and as far as I understand, I have to send the revised patch to the list before I can register it at the commitfest. So here is my revised patch, that uses "const char *const * " like elsewhere in the same file instead of

Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-21 Thread Lionel Elie Mamane
ghtOn Wed, Sep 21, 2011 at 07:29:23AM +0800, Craig Ringer wrote: > On 21/09/2011 12:05 AM, Lionel Elie Mamane wrote: >>Bug reference: 6216 >>Logged by: Lionel Elie Mamane >>Email address: lio...@mamane.lu >> In C++, a "char**" value is not convertible to a "const char**" >> val

Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-20 Thread Tom Lane
Craig Ringer writes: > As for wording: my *personal* preference is "const char * const" but I > don't know what the opinions of those who work with the code day-to-day are. +1. Isn't the other ordering deprecated by recent C standards? (Or maybe I'm just thinking of where you're supposed to put

Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-20 Thread Craig Ringer
On 21/09/2011 12:05 AM, Lionel Elie Mamane wrote: The following bug has been logged online: Bug reference: 6216 Logged by: Lionel Elie Mamane Email address: lio...@mamane.lu PostgreSQL version: 9.1.0 Operating system: Debian GNU/Linux Description:Calling PQconnectdbP

Re: [BUGS] BUG #6216: Calling PQconnectdbParams from C++ with a char**

2011-09-20 Thread Merlin Moncure
On Tue, Sep 20, 2011 at 11:05 AM, Lionel Elie Mamane wrote: > > The following bug has been logged online: > > Bug reference:      6216 > Logged by:          Lionel Elie Mamane > Email address:      lio...@mamane.lu > PostgreSQL version: 9.1.0 > Operating system:   Debian GNU/Linux > Description: