Re: [BUGS] stopping server does not remove external_pid_file

2006-06-07 Thread Euler Taveira de Oliveira
Tom Lane wrote: > No, because the external pidfile has zero to do with Postgres' internal > behavior. > +1. So we have two options: have external_pid_file mimics the internal behavior or deprecates it. I couldn't find the discussion about it; just the patch [1]. IIRC this 'feature' was proposed

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-07 Thread Jim C. Nasby
On Tue, Jun 06, 2006 at 11:32:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Doesn't removing the file reduce the chances of failing to start later > > in case another postmaster already has that pid? > > No, because the external pidfile has zero to do with Postgres' internal > behavior.

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Doesn't removing the file reduce the chances of failing to start later > > in case another postmaster already has that pid? > > No, because the external pidfile has zero to do with Postgres' internal > behavior. > > Personally I always thought that the

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-06 Thread Tom Lane
Bruce Momjian writes: > Doesn't removing the file reduce the chances of failing to start later > in case another postmaster already has that pid? No, because the external pidfile has zero to do with Postgres' internal behavior. Personally I always thought that the external pidfile was a "feature

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-06 Thread Bruce Momjian
Tom Lane wrote: > Euler Taveira de Oliveira <[EMAIL PROTECTED]> writes: > > Martin Pitt wrote: > >> I just played around with external_pid_file in 8.1.4. I noticed that > >> the file is created and filled properly, but it is not removed again > >> when the server is stopped. > >> > > Looking at th

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-06 Thread Tom Lane
Euler Taveira de Oliveira <[EMAIL PROTECTED]> writes: > Martin Pitt wrote: >> I just played around with external_pid_file in 8.1.4. I noticed that >> the file is created and filled properly, but it is not removed again >> when the server is stopped. >> > Looking at the code I see this comment in >

Re: [BUGS] stopping server does not remove external_pid_file

2006-06-06 Thread Euler Taveira de Oliveira
Martin Pitt wrote: > I just played around with external_pid_file in 8.1.4. I noticed that > the file is created and filled properly, but it is not removed again > when the server is stopped. > Looking at the code I see this comment in src/backend/postmaster/postmaster.c /* Should we remove the p

[BUGS] stopping server does not remove external_pid_file

2006-06-05 Thread Martin Pitt
Hi PostgreSQL developers, I just played around with external_pid_file in 8.1.4. I noticed that the file is created and filled properly, but it is not removed again when the server is stopped. Thank you, Martin -- Martin Pitthttp://www.piware.de Ubuntu Developer http://www.ubuntu.com D