Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Tom Lane
Ronan Dunklau writes: > How will this bug be handled with regards to releases ? It'll be fixed in next week's releases. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Ronan Dunklau
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for the response. How will this bug be handled with regards to releases ? If the fix is going to take a while to be released, we could rename our servers to valid names but we would prefer not to. Regards, - -- Ronan Dunklau -BEGIN PGP

Re: [BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Tom Lane
Ronan Dunklau writes: > When dumping foreign tables, the server name is not properly quoted, > which leads to unrestorable dumps. Clearly a bug. > Please look at the attached test case and the proposed patch. I think this patch is not in keeping with typical coding practices in pg_dump. Usuall

[BUGS] pg_dump - foreign table - server name is not quoted

2011-11-28 Thread Ronan Dunklau
Hello. I noticed what I think is a bug in pg_dump. When dumping foreign tables, the server name is not properly quoted, which leads to unrestorable dumps. eg, a foreign table attached to a foreign server named "file-test" is dumped as: CREATE FOREIGN TABLE "test-table" ( col1 integer ) SERV