Re: [BUGS] fix: plpgsql: return query and dropped columns problem

There is fixed patch. Please, Jaime, can you look on it? Thank You Pavel 2009/7/30 Tom Lane : > Jaime Casanova writes: >>> On Mon, Jul 20, 2009 at 10:09 AM, Alvaro Getting rid of the check on natts was "ungood" ... it needs to compare the number of undropped columns of both tupdescs. >

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

2009/7/30 Tom Lane : > Jaime Casanova writes: >>> On Mon, Jul 20, 2009 at 10:09 AM, Alvaro Getting rid of the check on natts was "ungood" ... it needs to compare the number of undropped columns of both tupdescs. > >> patch attached > > This patch is *still* introducing more bugs than it

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

Jaime Casanova writes: >> On Mon, Jul 20, 2009 at 10:09 AM, Alvaro >>> Getting rid of the check on natts was "ungood" ... it needs to compare >>> the number of undropped columns of both tupdescs. > patch attached This patch is *still* introducing more bugs than it fixes. The reason is that it h

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

2009/7/28 Robert Haas : > On Tue, Jul 28, 2009 at 1:19 PM, Jaime > Casanova wrote: >> On Tue, Jul 28, 2009 at 12:12 PM, Robert Haas wrote: > > patch attached > super, thanks Pavel >>> >>> So is this Ready for Committer? >>> >> >> i think so... but being me who added the l

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Tue, Jul 28, 2009 at 1:19 PM, Jaime Casanova wrote: > On Tue, Jul 28, 2009 at 12:12 PM, Robert Haas wrote: patch attached >>> super, thanks >>> >>> Pavel >> >> So is this Ready for Committer? >> > > i think so... but being me who added the last bit of code i didn't > felt confiden

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Tue, Jul 28, 2009 at 12:12 PM, Robert Haas wrote: >>> >>> patch attached >>> >> super, thanks >> >> Pavel > > So is this Ready for Committer? > i think so... but being me who added the last bit of code i didn't felt confident to mark it as such... -- Atentamente, Jaime Casanova Soporte y capa

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Tue, Jul 21, 2009 at 2:13 AM, Pavel Stehule wrote: > 2009/7/21 Jaime Casanova : >> On Mon, Jul 20, 2009 at 11:34 AM, Jaime >> Casanova wrote: >>> On Mon, Jul 20, 2009 at 10:09 AM, Alvaro Getting rid of the check on natts was "ungood" ... it needs to compare the number of undropped

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

2009/7/21 Jaime Casanova : > On Mon, Jul 20, 2009 at 11:34 AM, Jaime > Casanova wrote: >> On Mon, Jul 20, 2009 at 10:09 AM, Alvaro >>> >>> Getting rid of the check on natts was "ungood" ... it needs to compare >>> the number of undropped columns of both tupdescs. >>> >> >> ah! ok, i see... i will m

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Mon, Jul 20, 2009 at 11:34 AM, Jaime Casanova wrote: > On Mon, Jul 20, 2009 at 10:09 AM, Alvaro >> >> Getting rid of the check on natts was "ungood" ... it needs to compare >> the number of undropped columns of both tupdescs. >> > > ah! ok, i see... i will mark the patch as "waiting on author" a

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Mon, Jul 20, 2009 at 10:09 AM, Alvaro Herrera wrote: > Tom Lane escribió: >> Jaime Casanova writes: >> > this one applies, compiles and it actually fixes the bug... >> >> And introduces a bunch of new ones.  Surely you don't think that version >> of compatible_tupdesc() is good enough. > > Gett

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

Tom Lane escribió: > Jaime Casanova writes: > > this one applies, compiles and it actually fixes the bug... > > And introduces a bunch of new ones. Surely you don't think that version > of compatible_tupdesc() is good enough. Getting rid of the check on natts was "ungood" ... it needs to compar

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Mon, Jul 20, 2009 at 9:55 AM, Tom Lane wrote: > Jaime Casanova writes: >> this one applies, compiles and it actually fixes the bug... > > And introduces a bunch of new ones.  Surely you don't think that version > of compatible_tupdesc() is good enough. > i guess you're talking about my adapted

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

Jaime Casanova writes: > this one applies, compiles and it actually fixes the bug... And introduces a bunch of new ones. Surely you don't think that version of compatible_tupdesc() is good enough. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgr

Re: [BUGS] fix: plpgsql: return query and dropped columns problem

On Sun, Jul 12, 2009 at 10:28 AM, Pavel Stehule wrote: > Hello > > there is fix for bug Re: [BUGS] BUG #4907: stored procedures and changed > tables > this one applies, compiles and it actually fixes the bug... it should be backpatched until 8.3... but applies cleanly only until 8.4 (what a surpr

[BUGS] fix: plpgsql: return query and dropped columns problem

Hello there is fix for bug Re: [BUGS] BUG #4907: stored procedures and changed tables regards Pavel Stehule 2009/7/10 Sergey Burladyan : > Sergey Burladyan writes: > >> Alvaro Herrera writes: >> >> > Michael Tenenbaum wrote: >> > >> > > If I have a stored procedure that returns a set of recor