Re: [BUGS] Seg-fault in format(text)

2011-05-23 Thread Heikki Linnakangas
On 23.05.2011 18:36, Tom Lane wrote: Heikki Linnakangas writes: It's a stretch that we'd ever support two billion arguments in any form, but an explicit check for "arg< 0" would make me feel better. No objection here, especially since I've just determined that bug #6035 is also some kind of

Re: [BUGS] Seg-fault in format(text)

2011-05-23 Thread Heikki Linnakangas
On 23.05.2011 18:36, Tom Lane wrote: Heikki Linnakangas writes: It's a stretch that we'd ever support two billion arguments in any form, but an explicit check for "arg< 0" would make me feel better. No objection here, especially since I've just determined that bug #6035 is also some kind of

Re: [BUGS] Seg-fault in format(text)

2011-05-23 Thread Tom Lane
Heikki Linnakangas writes: > It's a stretch that we'd ever support two billion arguments in any form, > but an explicit check for "arg < 0" would make me feel better. No objection here, especially since I've just determined that bug #6035 is also some kind of unhandled-overflow problem... Do yo

Re: [BUGS] Seg-fault in format(text)

2011-05-23 Thread Heikki Linnakangas
On 23.05.2011 17:33, Tom Lane wrote: Not sure I trust this fix to catch all cases --- seems like the addition could still overflow. It'd probably be better if we made this code look like the overflow test in scanint8: int64 newtmp = tmp * 10 + (*ptr++ - '0');

Re: [BUGS] Seg-fault in format(text)

2011-05-23 Thread Tom Lane
Dean Rasheed writes: > Testing 9.1beta: > select format('Hello %s, %2147483648$s', 'World'); > server closed the connection unexpectedly Yeah, same here. > do > { > /* Treat overflowing arg position as > unterminated. */

[BUGS] Seg-fault in format(text)

2011-05-23 Thread Dean Rasheed
Testing 9.1beta: select format('Hello %s, %2147483648$s', 'World'); server closed the connection unexpectedly This probably means the server terminated abnormally before or while processing the request. The connection to the server was lost. Attempting reset: Failed. The problem i